On Tue, Mar 10, 2020 at 04:44:11PM -0400, Eli Schwartz wrote:
> On 3/10/20 2:58 PM, Patrick Steinhardt wrote:
> > In order to support the Argon2 key derival function for LUKS2, we
> > obviously need to implement Argon2. It doesn't make a lot of sense to
> > hand-code any crypto, which is why this commit instead imports Argon2
> > from the cryptsetup project. This commit thus imports the code from the
> > official reference implementation located at [1].
> 
> Which one is it? :p
> 
> Perhaps, "which is why this commit instead imports the Argon2
> implementation used by the cryptsetup project, that is, the official
> reference implementation located at [1]."

Oops, yes. This is an artifact caused by switching implementations from
cryptsetup to the reference implementation midway through. Thanks for
pointing out, will fix!

> 
> > The code is licensed
> > under CC0 1.0 Universal/Apache 2.0. Given that both LGPLv2.1+ and Apache
> > 2.0 are compatible with GPLv3, it should be fine to import that code.
> > 
> > The code is imported from commit 62358ba (Merge pull request #270 from
> > bitmark-property-system/master, 2019-05-20). To make it work for GRUB,
> > several adjustments were required that have beed documented in
> > "grub-dev.texi".
> 
> typo:
> 
> "beed" -> "been"

Ditto.

Patrick