From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jBmeM-0001lo-Op for mharc-grub-devel@gnu.org; Tue, 10 Mar 2020 17:42:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58165) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBmeJ-0001fG-SF for grub-devel@gnu.org; Tue, 10 Mar 2020 17:42:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBmeI-0006gL-4w for grub-devel@gnu.org; Tue, 10 Mar 2020 17:42:51 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56313) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBmeH-0006bq-9F for grub-devel@gnu.org; Tue, 10 Mar 2020 17:42:50 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 35FCB21FBA for ; Tue, 10 Mar 2020 17:42:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 10 Mar 2020 17:42:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=fm3; bh=zx/1TG2l3warKMfPyHZhWBkeDpFIv1pqgMpO1fWx tOQ=; b=SDNv16Wqw2D8bNfotXcFjZ9PvOcd16mGUWw5m2rBfcWfEF1mqONKvgjy 0NHbnd1NbVC4uUE6sD2KXOrW2Mf0ZNu46zoS1B20AhhLx1SjVOiZwotYqijaI8sN QenS7zJMhJePG2lKeJUiLZgyxy2fVmlaTzmSt7snmhVyd9zK/uCMki9be+RU3Y2t +Y6w0B+p+qYXrhh89A03EZSDRPB2xsfRIA7+hTJVeowH0gKfVr0HtUhY40EKrI2e BuKgZ4pb3wgVzZF4b577VsPRXxBgUC2ZfE9RzzH8izRzGMfBBcc7r0+pqB1eRhpL jUNIk/a70NP2UbfUDdxTS7fTDXh46Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zx/1TG 2l3warKMfPyHZhWBkeDpFIv1pqgMpO1fWxtOQ=; b=hUdwAtrPnq/cmisimX41LC h/Rg6mSTnMBvMG6GXYI1Dx6QD8LBJGSJ5IYCqDTzhGKmH/Bh6QosZY3jcxXpSRzB 7mzV/D+PuOgk1xxiQkVasuHFNATwkMNT7UtXzA013vdSiatQp2dGeMqOCQYo2wjT RJhHox9RYMNPPNueRz7V7/lQsNZueIYd8wNSS4HrzudsNABSME7H/pK6wrNYykNt MuZ8oWngu5gTzb21g+3bJiopTuoacsnBLplyy0I6cUlY3sxII9yaBIcnFZ4ryJS7 gCq3nPnv1v73sUz45cvVcMd3HR01BZdezHqy3hyeymBh0WkooUSw/VuSlu2jDgkg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvtddgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecukfhppeekledrud dvrddvheegrddvheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail (x590cfe19.dyn.telefonica.de [89.12.254.25]) by mail.messagingengine.com (Postfix) with ESMTPA id AA2123280063 for ; Tue, 10 Mar 2020 17:42:47 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail (OpenSMTPD) with ESMTPSA id f0df4f87 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 10 Mar 2020 21:42:44 +0000 (UTC) Date: Tue, 10 Mar 2020 22:42:44 +0100 From: Patrick Steinhardt To: The development of GNU GRUB Subject: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup Message-ID: <20200310214244.GA6876@ncase> References: <1f64edde-3e20-951b-02d7-9880af1835c8@archlinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <1f64edde-3e20-951b-02d7-9880af1835c8@archlinux.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2020 21:42:53 -0000 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2020 at 04:44:11PM -0400, Eli Schwartz wrote: > On 3/10/20 2:58 PM, Patrick Steinhardt wrote: > > In order to support the Argon2 key derival function for LUKS2, we > > obviously need to implement Argon2. It doesn't make a lot of sense to > > hand-code any crypto, which is why this commit instead imports Argon2 > > from the cryptsetup project. This commit thus imports the code from the > > official reference implementation located at [1]. >=20 > Which one is it? :p >=20 > Perhaps, "which is why this commit instead imports the Argon2 > implementation used by the cryptsetup project, that is, the official > reference implementation located at [1]." Oops, yes. This is an artifact caused by switching implementations from cryptsetup to the reference implementation midway through. Thanks for pointing out, will fix! >=20 > > The code is licensed > > under CC0 1.0 Universal/Apache 2.0. Given that both LGPLv2.1+ and Apache > > 2.0 are compatible with GPLv3, it should be fine to import that code. > >=20 > > The code is imported from commit 62358ba (Merge pull request #270 from > > bitmark-property-system/master, 2019-05-20). To make it work for GRUB, > > several adjustments were required that have beed documented in > > "grub-dev.texi". >=20 > typo: >=20 > "beed" -> "been" Ditto. Patrick --17pEHd4RhPHOinZp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl5oCc4ACgkQEXxntp6r 8SymPhAAmdqxhfr7qAP85Xmd27Bhv70Ofw0Cu3bsm7U936QIz3kwa01wJ9DoCpvI T/gcDDlIzNJT7kHgCtPSo+l6X+flXP1ThP0L6AHraCcQ2vKFXHMS8wF2LPnT46zt +BfAogmM2zSs6t4RzcZWdjSTpdlrZSnlbwwoXRHclzXdiLERhdZLyO3o3XolYNDZ c4jmTOarC73rJP1A2eJguUdDmiHvv3p97W/suYKhPi9bN9bWPP6RZzqJ4nGmhltU cKcpc/G1XCGkQtAIf1XCJGROnKibe9NlIBYf/IW3VF3G23RTDNweImjwhFPnjw1p 7nogqykV5KtukKS0qchbHQBhHdZHXrS/6tN8JTsxXaLEIZqJpqf5o9mnx0eVJ7qE GtHZutVJfKBRJvmK38LVnOBmYzRNldDSljJQ5SrMye2wori5APAQt/rEeXiKSbh7 y+u9II+YujE/YlbjQAqIE0fh8EzcZ2saq9dml4ytp8K/PBZKEgnADCA8brp5VNYT 5GD6fZjKckBmf+UVC4lEKc9bY8maTxQtR2yg5Wcm+0c66q5O4EAY4O7ci1ttg9Hr KoPKkpTfl3CPfszMolRAlP1orbLFxTM7zVlPbiWyT6XUUI2sMANh+5BtvZKjFthZ jzQMTOl2tieAxOYRVAEEOz6NIOqHaYC6JZK3O7Oi1VUCqCygV1o= =m6yc -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--