All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: rcu@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: Clang warning in kernel/rcu/tasks.h
Date: Tue, 10 Mar 2020 14:56:16 -0700	[thread overview]
Message-ID: <20200310215616.GI2935@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200310204941.GA53917@ubuntu-m2-xlarge-x86>

On Tue, Mar 10, 2020 at 01:49:41PM -0700, Nathan Chancellor wrote:
> Hi Paul,
> 
> It appears that the commits 37564025a3d7 ("rcu-tasks: Refactor RCU-tasks
> to allow variants to be added") and cbd703932774 ("rcu-tasks: Add an
> RCU-tasks rude variant") both add a forward declaration to rcu_tasks and
> the rcu_tasks_gp_func_t typedef, resulting in the following clang
> warning:
> 
> In file included from kernel/rcu/update.c:563:
> kernel/rcu/tasks.h:24:16: warning: redefinition of typedef 'rcu_tasks_gp_func_t' is a C11 feature [-Wtypedef-redefinition]
> typedef void (*rcu_tasks_gp_func_t)(struct rcu_tasks *rtp);
>                ^
> kernel/rcu/tasks.h:17:16: note: previous definition is here
> typedef void (*rcu_tasks_gp_func_t)(struct rcu_tasks *rtp);
>                ^
> 1 warning generated.
> 
> Maybe a rebase or merge gone wrong? Would you mind taking a look and
> fixing it up if possible?

Will do, good catch, thank you!

							Thanx, Paul

      reply	other threads:[~2020-03-10 21:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 20:49 Clang warning in kernel/rcu/tasks.h Nathan Chancellor
2020-03-10 21:56 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310215616.GI2935@paulmck-ThinkPad-P72 \
    --to=paulmck@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=natechancellor@gmail.com \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.