From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
shakeelb@google.com, syzkaller@googlegroups.com
Subject: Re: [PATCH net] net: memcg: fix lockdep splat in inet_csk_accept()
Date: Wed, 11 Mar 2020 23:58:23 -0700 (PDT) [thread overview]
Message-ID: <20200311.235823.220996291757645509.davem@davemloft.net> (raw)
In-Reply-To: <20200311184426.39253-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 11 Mar 2020 11:44:26 -0700
> Locking newsk while still holding the listener lock triggered
> a lockdep splat [1]
>
> We can simply move the memcg code after we release the listener lock,
> as this can also help if multiple threads are sharing a common listener.
>
> Also fix a typo while reading socket sk_rmem_alloc.
...
> Fixes: d752a4986532 ("net: memcg: late association of sock to memcg")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Shakeel Butt <shakeelb@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
Applied, thanks Eric.
prev parent reply other threads:[~2020-03-12 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 18:44 [PATCH net] net: memcg: fix lockdep splat in inet_csk_accept() Eric Dumazet
2020-03-12 6:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311.235823.220996291757645509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.