From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D8F5C10F27 for ; Wed, 11 Mar 2020 06:56:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 238012146E for ; Wed, 11 Mar 2020 06:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583909794; bh=3Ep2wKxBTGsfUCNfCDQweZjSglb96ycg3qXDrlrC05M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Gr6I/JfbTFBgCOpyARTAOeIXzz0c0HWH1CbLXG1LhRosx5OUsRdaUVbb4gIucfIi/ kueSY6DGlItkWRmhkBJ8CgGBi8OR4HTy2WaG4+Q//2MGWpcgkC40BbdXPogbvwwlff Q/b/XCY1Z/Ym9bsAS7FYjS/BJAPVeuc2OdPWkuig= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728241AbgCKG4d (ORCPT ); Wed, 11 Mar 2020 02:56:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:59356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgCKG4d (ORCPT ); Wed, 11 Mar 2020 02:56:33 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0AD7020873; Wed, 11 Mar 2020 06:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583909791; bh=3Ep2wKxBTGsfUCNfCDQweZjSglb96ycg3qXDrlrC05M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rVzNJa8SINpMAGDvZuXfce5ih+vZdIp0wz/8nMSNOj+/uZcR9HvU0e4rkY4GJ56i8 ipi7k6j6ufA4xQIVBFPZNf7UiuSGPe40TJeYTgswZrH1jolWxX0Hyv331FgIBRH4bT 6W1CfKWDZMtFvcbT2KmNFSMb+P/dN2muSCamoCdk= Date: Wed, 11 Mar 2020 08:56:28 +0200 From: Leon Romanovsky To: "Kiyanovski, Arthur" Cc: Jakub Kicinski , "davem@davemloft.net" , "netdev@vger.kernel.org" , "Belgazal, Netanel" , "Tzalik, Guy" , "irusskikh@marvell.com" , "f.fainelli@gmail.com" , "bcm-kernel-feedback-list@broadcom.com" , "rmody@marvell.com" , "GR-Linux-NIC-Dev@marvell.com" , "aelior@marvell.com" , "skalluru@marvell.com" , "GR-everest-linux-l2@marvell.com" , "opendmb@gmail.com" , "siva.kallam@broadcom.com" , "prashant@broadcom.com" , "mchan@broadcom.com" , "dchickles@marvell.com" , "sburla@marvell.com" , "fmanlunas@marvell.com" , "tariqt@mellanox.com" , "vishal@chelsio.com" , "leedom@chelsio.com" , "ulli.kroll@googlemail.com" , "linus.walleij@linaro.org" Subject: Re: [PATCH net-next 01/15] net: ena: reject unsupported coalescing params Message-ID: <20200311065628.GD4215@unreal> References: <20200310021512.1861626-1-kuba@kernel.org> <20200310021512.1861626-2-kuba@kernel.org> <20200310183147.GM242734@unreal> <4d4d26f2e1994d4bb22a8ab9d5f49491@EX13D22EUA004.ant.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d4d26f2e1994d4bb22a8ab9d5f49491@EX13D22EUA004.ant.amazon.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 10, 2020 at 08:55:33PM +0000, Kiyanovski, Arthur wrote: > > > > -----Original Message----- > > From: Leon Romanovsky > > Sent: Tuesday, March 10, 2020 8:32 PM > > To: Kiyanovski, Arthur > > Cc: Jakub Kicinski ; davem@davemloft.net; > > netdev@vger.kernel.org; Belgazal, Netanel ; Tzalik, > > Guy ; irusskikh@marvell.com; f.fainelli@gmail.com; > > bcm-kernel-feedback-list@broadcom.com; rmody@marvell.com; GR-Linux-NIC- > > Dev@marvell.com; aelior@marvell.com; skalluru@marvell.com; GR-everest- > > linux-l2@marvell.com; opendmb@gmail.com; siva.kallam@broadcom.com; > > prashant@broadcom.com; mchan@broadcom.com; dchickles@marvell.com; > > sburla@marvell.com; fmanlunas@marvell.com; tariqt@mellanox.com; > > vishal@chelsio.com; leedom@chelsio.com; ulli.kroll@googlemail.com; > > linus.walleij@linaro.org > > Subject: RE: [EXTERNAL][PATCH net-next 01/15] net: ena: reject unsupported > > coalescing params > > > > CAUTION: This email originated from outside of the organization. Do not click > > links or open attachments unless you can confirm the sender and know the > > content is safe. > > > > > > > > On Tue, Mar 10, 2020 at 02:16:03PM +0000, Kiyanovski, Arthur wrote: > > > > -----Original Message----- > > > > From: Jakub Kicinski > > > > Sent: Tuesday, March 10, 2020 4:15 AM > > > > To: davem@davemloft.net > > > > Cc: netdev@vger.kernel.org; Kiyanovski, Arthur ; > > > > Belgazal, Netanel ; Tzalik, Guy > > > > ; irusskikh@marvell.com; f.fainelli@gmail.com; > > > > bcm-kernel-feedback- list@broadcom.com; rmody@marvell.com; > > > > GR-Linux-NIC-Dev@marvell.com; aelior@marvell.com; > > > > skalluru@marvell.com; GR-everest-linux-l2@marvell.com; > > > > opendmb@gmail.com; siva.kallam@broadcom.com; > > prashant@broadcom.com; > > > > mchan@broadcom.com; dchickles@marvell.com; sburla@marvell.com; > > > > fmanlunas@marvell.com; tariqt@mellanox.com; vishal@chelsio.com; > > > > leedom@chelsio.com; ulli.kroll@googlemail.com; > > > > linus.walleij@linaro.org; Jakub Kicinski > > > > Subject: [EXTERNAL][PATCH net-next 01/15] net: ena: reject > > > > unsupported coalescing params > > > > > > > > CAUTION: This email originated from outside of the organization. Do > > > > not click links or open attachments unless you can confirm the > > > > sender and know the content is safe. > > > > > > > > > > > > > > > > Set ethtool_ops->supported_coalesce_params to let the core reject > > > > unsupported coalescing parameters. > > > > > > > > Signed-off-by: Jakub Kicinski > > > > --- > > > > drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c > > > > b/drivers/net/ethernet/amazon/ena/ena_ethtool.c > > > > index 868265a2ec00..552d4cbf6dbd 100644 > > > > --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c > > > > +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c > > > > @@ -826,6 +826,8 @@ static int ena_set_tunable(struct net_device > > > > *netdev, } > > > > > > > > static const struct ethtool_ops ena_ethtool_ops = { > > > > + .supported_coalesce_params = ETHTOOL_COALESCE_USECS | > > > > + > > > > + ETHTOOL_COALESCE_USE_ADAPTIVE_RX, > > > > .get_link_ksettings = ena_get_link_ksettings, > > > > .get_drvinfo = ena_get_drvinfo, > > > > .get_msglevel = ena_get_msglevel, > > > > -- > > > > 2.24.1 > > > > > > > > > Acked-by: Sameeh Jubran > > > > FROM author of this reply and Acked-by doesn't look the same. > > Which one is correct? > > > > Thanks > > Sameeh did the check, I sent the email. > So the correct one is the one written in the email: > Acked-by: Sameeh Jubran > > Sorry for the confusion. It is important that the one who adds "-by" writes the email and uses same name, because get-lore-mbox.py (the new tool that used by many maintainers to grab patches) performs strict check between From and tags to be on the safe side. Thanks