From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5965AC10F29 for ; Wed, 11 Mar 2020 07:12:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32099208E4 for ; Wed, 11 Mar 2020 07:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583910772; bh=c86VT5FpHpio5aGVvnNUNSuNXdICskgx/YVnnbeBvYs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wOzJV8aY1rtoIxqOH8MgCzVlnvPuv4sQNuNHhtLuJ6GLOTIG6vHVu/7+KoMamEiEV dBj9GFm/PH52f8YfcrqvHV+q8DmXUehWlp+5bCTI8ZcmrtULu/9ei6WGvNH/g5Ron4 BwLeHy8eHKWjUezR3w9fdLZAWNagrG6DC46TRpH8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbgCKHMv (ORCPT ); Wed, 11 Mar 2020 03:12:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:36930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgCKHMu (ORCPT ); Wed, 11 Mar 2020 03:12:50 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64FAF21655; Wed, 11 Mar 2020 07:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583910770; bh=c86VT5FpHpio5aGVvnNUNSuNXdICskgx/YVnnbeBvYs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jXbnu6+TTEJZqPKG4EjBUyEhzRF4u40qvs9WeYqHMGOTZgQkr/kwVIaJjcU/o3FGl PTWzoUmJqHN3QMNfA3HR5pLY/QaQoqdMYjytG+ZbwUL9mh8YJpmbN72Q0cXpsGAUTy w78Jnxaaj4J19EiLgOlTZohVkJjHn2bgf6TlFqRA= Date: Wed, 11 Mar 2020 15:12:42 +0800 From: Shawn Guo To: Anson Huang Cc: mturquette@baylibre.com, sboyd@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, leonard.crestez@nxp.com, abel.vesa@nxp.com, peng.fan@nxp.com, ping.bai@nxp.com, fugang.duan@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH 1/4] clk: imx8mn: A53 core clock no need to be critical Message-ID: <20200311071241.GJ29269@dragon> References: <1582620554-32689-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582620554-32689-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2020 at 04:49:11PM +0800, Anson Huang wrote: > 'A53_CORE' is just a mux and no need to be critical, being critical > will cause its parent clock always ON which does NOT make sense, > to make sure CPU's hardware clock source NOT being disabled during > clock tree setup, need to move the 'A53_SRC'/'A53_CORE' reparent > operations to after critical clock 'ARM_CLK' setup finished. > > Signed-off-by: Anson Huang Applied all, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37EF3C10F25 for ; Wed, 11 Mar 2020 07:13:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08A81208E4 for ; Wed, 11 Mar 2020 07:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KrlJUtSf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jXbnu6+T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08A81208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hS9CTJrQYmoEY6or4BshVK+i3+lEFhD1+V7Jr2B+u6U=; b=KrlJUtSfUOuj4h dczMAdxsBAhmp+8vo4NATdGCAiiD6qYmZhLklpUHTeytBNWhH641lXoc36Oqo1LkjmM8hsaiLXzUP Sqm+lzWLwf9+tVi1xeZVSvPkGCo8bqf9JQlOyo9HzrraiurzIa56N1wflf9lO4NRhpQxfrXh9KPo2 IibL2h71e0oLV9+tt9T6D4vQgepWgYRZXaXx9RqbTSgUUQOhlvq/skIez9XPkjWK81m11pNhP4q47 Cv8UQhJ4cPURc/HatyzFpJhDEAioNMnNnLhKwbWfwjytrt62Gpdl+Ah8hQpM2/dqa9SGkT/ASO67Q Ay5njpd2DQXDjFLu3zVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBvY3-0003fT-1c; Wed, 11 Mar 2020 07:12:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBvXu-0003Wn-LR for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 07:12:51 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64FAF21655; Wed, 11 Mar 2020 07:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583910770; bh=c86VT5FpHpio5aGVvnNUNSuNXdICskgx/YVnnbeBvYs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jXbnu6+TTEJZqPKG4EjBUyEhzRF4u40qvs9WeYqHMGOTZgQkr/kwVIaJjcU/o3FGl PTWzoUmJqHN3QMNfA3HR5pLY/QaQoqdMYjytG+ZbwUL9mh8YJpmbN72Q0cXpsGAUTy w78Jnxaaj4J19EiLgOlTZohVkJjHn2bgf6TlFqRA= Date: Wed, 11 Mar 2020 15:12:42 +0800 From: Shawn Guo To: Anson Huang Subject: Re: [PATCH 1/4] clk: imx8mn: A53 core clock no need to be critical Message-ID: <20200311071241.GJ29269@dragon> References: <1582620554-32689-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1582620554-32689-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_001250_731106_A6D09712 X-CRM114-Status: UNSURE ( 8.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peng.fan@nxp.com, fugang.duan@nxp.com, abel.vesa@nxp.com, sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, leonard.crestez@nxp.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, ping.bai@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 25, 2020 at 04:49:11PM +0800, Anson Huang wrote: > 'A53_CORE' is just a mux and no need to be critical, being critical > will cause its parent clock always ON which does NOT make sense, > to make sure CPU's hardware clock source NOT being disabled during > clock tree setup, need to move the 'A53_SRC'/'A53_CORE' reparent > operations to after critical clock 'ARM_CLK' setup finished. > > Signed-off-by: Anson Huang Applied all, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel