From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43202C18E5B for ; Wed, 11 Mar 2020 10:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25E1F2192A for ; Wed, 11 Mar 2020 10:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729002AbgCKKnz (ORCPT ); Wed, 11 Mar 2020 06:43:55 -0400 Received: from elvis.franken.de ([193.175.24.41]:34049 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbgCKKnz (ORCPT ); Wed, 11 Mar 2020 06:43:55 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jByq3-0008R7-00; Wed, 11 Mar 2020 11:43:47 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9B343C0FE2; Wed, 11 Mar 2020 11:42:17 +0100 (CET) Date: Wed, 11 Mar 2020 11:42:17 +0100 From: Thomas Bogendoerfer To: afzal mohammed Cc: Nathan Chancellor , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , Paul Burton , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "Maciej W. Rozycki" , Jiaxun Yang , Keguang Zhang , Huacai Chen , John Crispin Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq() Message-ID: <20200311104217.GA10615@alpha.franken.de> References: <20200304203144.GA4323@alpha.franken.de> <20200305115759.3186-1-afzal.mohd.ma@gmail.com> <20200311053126.GA48442@ubuntu-m2-xlarge-x86> <20200311090308.GA5060@afzalpc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311090308.GA5060@afzalpc> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 02:33:08PM +0530, afzal mohammed wrote: > diff --git a/arch/mips/kernel/cevt-r4k.c b/arch/mips/kernel/cevt-r4k.c > index 64e917dfe6b2..d24e4f2985c3 100644 > --- a/arch/mips/kernel/cevt-r4k.c > +++ b/arch/mips/kernel/cevt-r4k.c > @@ -252,7 +252,7 @@ unsigned int __weak get_c0_compare_int(void) > > int r4k_clockevent_init(void) > { > - unsigned long flags = IRQF_PERCPU | IRQF_TIMER | IRQF_SHARED; > + unsigned long flags = IRQF_PERCPU | IRQF_TIMER; > unsigned int cpu = smp_processor_id(); > struct clock_event_device *cd; > unsigned int irq, min_delta; I don't see why this should help. In my tree only sgi-ip30 removes IRQF_SHARED from flags, but then it uses setup_percpu_irq(). What do I miss ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D61C10F27 for ; Wed, 11 Mar 2020 10:44:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2465F2192A for ; Wed, 11 Mar 2020 10:44:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pRJKnwg+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2465F2192A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jT2QcrooqjFTbN6kqz4urmlBTJK6pcSdHT7k3vuN+b8=; b=pRJKnwg+GqZTIx JA9Nyv8zdHtauvKDDjC2ntsfyMAxUA6ULx9N111hGl7xADe+gpdR58VlZ/lSxiJqJAVmcUPJ5SCRE Cwg59uGa0v+c+BMLZoz3INpU667FwzoJt2dgNcZTMV91pH2UfY7EbS38jqeTQAKRLh8RUDhOLaXoK 8nniemOcYUNY24X7bRetoMBld93CKlGE2Mib9qyVOQz7Qdf2JN4MYD6zxv1bFrxbLzWm1VBRH4/iq 0Emj02WLQGzTyFIxEup4JnwCy7IAHZGPs0Vb2k7nYSZ8KGSQ3f7Y9/jULWKdDH+gajWCLCur399UF xMXos9mnZwPAZJBZxsCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jByqG-0003os-FP; Wed, 11 Mar 2020 10:44:00 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jByqD-0003o3-NR for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 10:43:59 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jByq3-0008R7-00; Wed, 11 Mar 2020 11:43:47 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9B343C0FE2; Wed, 11 Mar 2020 11:42:17 +0100 (CET) Date: Wed, 11 Mar 2020 11:42:17 +0100 From: Thomas Bogendoerfer To: afzal mohammed Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq() Message-ID: <20200311104217.GA10615@alpha.franken.de> References: <20200304203144.GA4323@alpha.franken.de> <20200305115759.3186-1-afzal.mohd.ma@gmail.com> <20200311053126.GA48442@ubuntu-m2-xlarge-x86> <20200311090308.GA5060@afzalpc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200311090308.GA5060@afzalpc> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_034357_912701_7F78652D X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Paul Burton , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Jiaxun Yang , "Maciej W. Rozycki" , John Crispin , Huacai Chen , Nathan Chancellor , Keguang Zhang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 11, 2020 at 02:33:08PM +0530, afzal mohammed wrote: > diff --git a/arch/mips/kernel/cevt-r4k.c b/arch/mips/kernel/cevt-r4k.c > index 64e917dfe6b2..d24e4f2985c3 100644 > --- a/arch/mips/kernel/cevt-r4k.c > +++ b/arch/mips/kernel/cevt-r4k.c > @@ -252,7 +252,7 @@ unsigned int __weak get_c0_compare_int(void) > > int r4k_clockevent_init(void) > { > - unsigned long flags = IRQF_PERCPU | IRQF_TIMER | IRQF_SHARED; > + unsigned long flags = IRQF_PERCPU | IRQF_TIMER; > unsigned int cpu = smp_processor_id(); > struct clock_event_device *cd; > unsigned int irq, min_delta; I don't see why this should help. In my tree only sgi-ip30 removes IRQF_SHARED from flags, but then it uses setup_percpu_irq(). What do I miss ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel