From: Kees Cook <keescook@chromium.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
stable@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeff Vander Stoep <jeffv@google.com>,
Jessica Yu <jeyu@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] kmod: make request_module() return an error when autoloading is disabled
Date: Wed, 11 Mar 2020 10:50:48 -0700 [thread overview]
Message-ID: <202003111050.B5D4423DA@keescook> (raw)
In-Reply-To: <20200311174134.GB20006@gmail.com>
On Wed, Mar 11, 2020 at 10:41:34AM -0700, Eric Biggers wrote:
> On Wed, Mar 11, 2020 at 10:28:07AM -0700, Kees Cook wrote:
> > On Tue, Mar 10, 2020 at 03:37:31PM -0700, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@google.com>
> > >
> > > It's long been possible to disable kernel module autoloading completely
> > > by setting /proc/sys/kernel/modprobe to the empty string. This can be
> >
> > Hunh. I've never seen that before. :) I've always used;
> >
> > echo 1 > /proc/sys/kernel/modules_disabled
> >
> > Regardless,
> >
> > Reviewed-by: Kees Cook <keescook@chromium.org>
> >
>
> modules_disabled is different because it disables *all* module loading, not just
> autoloading.
Yes, quite true. Some day I'd love to revisit this series to improve
autoloading sanity checking:
https://github.com/KSPP/linux/issues/24
--
Kees Cook
next prev parent reply other threads:[~2020-03-11 17:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 22:37 [PATCH] kmod: make request_module() return an error when autoloading is disabled Eric Biggers
2020-03-11 4:32 ` Luis Chamberlain
2020-03-11 5:26 ` Eric Biggers
2020-03-11 6:31 ` Luis Chamberlain
2020-03-11 17:35 ` Eric Biggers
2020-03-11 18:00 ` Luis Chamberlain
2020-03-11 18:21 ` Eric Biggers
2020-03-11 18:40 ` Luis Chamberlain
2020-03-11 5:55 ` Josh Triplett
2020-03-11 6:32 ` Luis Chamberlain
2020-03-11 17:28 ` Kees Cook
2020-03-11 17:41 ` Eric Biggers
2020-03-11 17:50 ` Kees Cook [this message]
2020-03-11 18:01 ` Luis Chamberlain
2020-03-11 18:08 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003111050.B5D4423DA@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeffv@google.com \
--cc=jeyu@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.