From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 750F6C18E5A for ; Wed, 11 Mar 2020 11:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5668D20848 for ; Wed, 11 Mar 2020 11:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729089AbgCKLWX (ORCPT ); Wed, 11 Mar 2020 07:22:23 -0400 Received: from foss.arm.com ([217.140.110.172]:48288 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbgCKLWW (ORCPT ); Wed, 11 Mar 2020 07:22:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E20051FB; Wed, 11 Mar 2020 04:22:21 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 06B013F6CF; Wed, 11 Mar 2020 04:22:20 -0700 (PDT) Date: Wed, 11 Mar 2020 11:22:18 +0000 From: Andre Przywara To: Chen-Yu Tsai Cc: Maxime Ripard , devicetree@vger.kernel.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, juanesf91@gmail.com Subject: Re: [PATCH 2/3] ARM: dts: sun8i: r40: Fix register base address for SPI2 and SPI3 Message-ID: <20200311112218.3537478b@donnerap.cambridge.arm.com> In-Reply-To: <20200310174709.24174-3-wens@kernel.org> References: <20200310174709.24174-1-wens@kernel.org> <20200310174709.24174-3-wens@kernel.org> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2020 01:47:08 +0800 Chen-Yu Tsai wrote: Hi Chen-Yu, sorry, didn't spot this before posting my version! > From: Chen-Yu Tsai > > When the SPI device nodes were added, SPI2 and SPI3 had incorrect > register base addresses. > > Fix the base address for both of them. > > Fixes: 554581b79139 ("ARM: dts: sun8i: R40: Add SPI controllers nodes and pinmuxes") > Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara As you suggested, it would be nice to add Juan's reported by, since he reported this before: https://groups.google.com/forum/#!topic/linux-sunxi/5ZzkDXx2F-M Cheers, Andre > --- > arch/arm/boot/dts/sun8i-r40.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi > index b278686d0c22..81cc92ddc78b 100644 > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > @@ -718,10 +718,10 @@ spi1: spi@1c06000 { > #size-cells = <0>; > }; > > - spi2: spi@1c07000 { > + spi2: spi@1c17000 { > compatible = "allwinner,sun8i-r40-spi", > "allwinner,sun8i-h3-spi"; > - reg = <0x01c07000 0x1000>; > + reg = <0x01c17000 0x1000>; > interrupts = ; > clocks = <&ccu CLK_BUS_SPI2>, <&ccu CLK_SPI2>; > clock-names = "ahb", "mod"; > @@ -731,10 +731,10 @@ spi2: spi@1c07000 { > #size-cells = <0>; > }; > > - spi3: spi@1c0f000 { > + spi3: spi@1c1f000 { > compatible = "allwinner,sun8i-r40-spi", > "allwinner,sun8i-h3-spi"; > - reg = <0x01c0f000 0x1000>; > + reg = <0x01c1f000 0x1000>; > interrupts = ; > clocks = <&ccu CLK_BUS_SPI3>, <&ccu CLK_SPI3>; > clock-names = "ahb", "mod"; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1509CC10F27 for ; Wed, 11 Mar 2020 11:22:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBE3921655 for ; Wed, 11 Mar 2020 11:22:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d34fnH3q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBE3921655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9SXghySkxrTyEqyJL9LxTyTHkSDWV6qaJh0/frt3TWE=; b=d34fnH3qODI7qI RLx391XWo8YhYI3tGwpINYKxUjbpbHB12whznYKVCQremXpIXbnTprQL+lMnvwhWLLMHxIcq7jBGO BwUcSU1JJlChPaEEnkS8/2oP45yUNxK0p6x/djlB2mTEfZsExSwADB5sBIQ5zp6XlGLCvLz6pz6kp +JTGCzOqk1edRYrJQsmvUNGITCxQYje8+S52j4Mkc6Qy2qd3jGVWIRwQgwPJM7AEkC1BhEPl50fVk 2OnbnoO80N6GSXLvVYDFCBXUedyQplmMxBqiCFGK1Io7lfO5WGnLqoErJvV8RxVOa+tJ1RhKX1dFj dPx/lzUwBpd1EyVBQFNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBzRR-0005Pk-9P; Wed, 11 Mar 2020 11:22:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBzRO-0005PD-HX for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 11:22:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E20051FB; Wed, 11 Mar 2020 04:22:21 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 06B013F6CF; Wed, 11 Mar 2020 04:22:20 -0700 (PDT) Date: Wed, 11 Mar 2020 11:22:18 +0000 From: Andre Przywara To: Chen-Yu Tsai Subject: Re: [PATCH 2/3] ARM: dts: sun8i: r40: Fix register base address for SPI2 and SPI3 Message-ID: <20200311112218.3537478b@donnerap.cambridge.arm.com> In-Reply-To: <20200310174709.24174-3-wens@kernel.org> References: <20200310174709.24174-1-wens@kernel.org> <20200310174709.24174-3-wens@kernel.org> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_042222_624238_DFD7A022 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, juanesf91@gmail.com, Chen-Yu Tsai , Maxime Ripard , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 11 Mar 2020 01:47:08 +0800 Chen-Yu Tsai wrote: Hi Chen-Yu, sorry, didn't spot this before posting my version! > From: Chen-Yu Tsai > > When the SPI device nodes were added, SPI2 and SPI3 had incorrect > register base addresses. > > Fix the base address for both of them. > > Fixes: 554581b79139 ("ARM: dts: sun8i: R40: Add SPI controllers nodes and pinmuxes") > Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara As you suggested, it would be nice to add Juan's reported by, since he reported this before: https://groups.google.com/forum/#!topic/linux-sunxi/5ZzkDXx2F-M Cheers, Andre > --- > arch/arm/boot/dts/sun8i-r40.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi > index b278686d0c22..81cc92ddc78b 100644 > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > @@ -718,10 +718,10 @@ spi1: spi@1c06000 { > #size-cells = <0>; > }; > > - spi2: spi@1c07000 { > + spi2: spi@1c17000 { > compatible = "allwinner,sun8i-r40-spi", > "allwinner,sun8i-h3-spi"; > - reg = <0x01c07000 0x1000>; > + reg = <0x01c17000 0x1000>; > interrupts = ; > clocks = <&ccu CLK_BUS_SPI2>, <&ccu CLK_SPI2>; > clock-names = "ahb", "mod"; > @@ -731,10 +731,10 @@ spi2: spi@1c07000 { > #size-cells = <0>; > }; > > - spi3: spi@1c0f000 { > + spi3: spi@1c1f000 { > compatible = "allwinner,sun8i-r40-spi", > "allwinner,sun8i-h3-spi"; > - reg = <0x01c0f000 0x1000>; > + reg = <0x01c1f000 0x1000>; > interrupts = ; > clocks = <&ccu CLK_BUS_SPI3>, <&ccu CLK_SPI3>; > clock-names = "ahb", "mod"; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel