From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FDAC3F2C6 for ; Wed, 11 Mar 2020 13:06:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9479221D56 for ; Wed, 11 Mar 2020 13:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583931997; bh=PlaS74TA52+HyUfV2WJZ2U19MoadXqctbqu4D164gSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wn2WT6hoAohG9S03TOCL6KnGnsh6k6Vk6Cxi7SL6khO+l1YyWAR88KAJAnvZ8NmGJ P2BjUHHU3O4neiWjt9RsKpXaBAVN5TWWYKbkLDqkom1Hu95Sl264hE3B1l0LG4hIzZ Dii8Wi6h5SNDZlhLoi4UoFlF3aXbMXWsaHoJBFHM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729523AbgCKNGg (ORCPT ); Wed, 11 Mar 2020 09:06:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:42368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729345AbgCKNGg (ORCPT ); Wed, 11 Mar 2020 09:06:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7570220873; Wed, 11 Mar 2020 13:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583931995; bh=PlaS74TA52+HyUfV2WJZ2U19MoadXqctbqu4D164gSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TeWdulkJWMeVeaaEZGETJ9tKpfFNWxoEk6v0ywm9ujxOMwzAYeGDhTcA3XLySgwfL akd7JVKlT7J59GDxrR5A/Xch7VLjquPNM57glysIry3yTkq+Cna3IsKyqc4IjdMpb3 xnNuXNI0w1ToAtKSsuA6q14naYS6uMTTkD1MTxcg= Date: Wed, 11 Mar 2020 14:06:28 +0100 From: Greg Kroah-Hartman To: Tom Lendacky Cc: Sean Christopherson , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Paolo Bonzini Subject: Re: [PATCH 4.14 057/126] KVM: SVM: Override default MMIO mask if memory encryption is enabled Message-ID: <20200311130628.GA3833342@kroah.com> References: <20200310124203.704193207@linuxfoundation.org> <20200310124207.819562318@linuxfoundation.org> <20200310181952.GF9305@linux.intel.com> <220a78d4-0e46-a321-49cd-5d1c5827aef0@amd.com> <0bab862b-0780-38c3-0c60-b078d61613de@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bab862b-0780-38c3-0c60-b078d61613de@amd.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 03:59:25PM -0500, Tom Lendacky wrote: > On 3/10/20 1:42 PM, Tom Lendacky wrote: > > On 3/10/20 1:19 PM, Sean Christopherson wrote: > >> Has this been tested on the stable kernels? There's a recent bug report[*] > >> that suggests the 4.19 backport of this patch may be causing issues. > > > > I missed this went the stable patches went by... when backported to the > > older version of kvm_mmu_set_mmio_spte_mask() in the stable kernels (4.14 > > and 4.19), the call should have been: > > > > kvm_mmu_set_mmio_spte_mask(mask, mask) and not: > > > > kvm_mmu_set_mmio_spte_mask(mask, PT_WRITABLE_MASK | PT_USER_MASK); > > > > The call in the original upstream patch was: > > > > kvm_mmu_set_mmio_spte_mask(mask, mask, PT_WRITABLE_MASK | PT_USER_MASK); > > Greg, > > I should have asked in the earlier email... how do you want to address this? I will fix this up now, thanks for pointing out what I got wrong... greg k-h