All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com
Subject: Re: [PATCH] kvm-unit-test: nVMX: Test Selector and Base Address fields of Guest Segment Registers on vmentry of nested guests
Date: Wed, 11 Mar 2020 08:19:59 -0700	[thread overview]
Message-ID: <20200311151959.GC21852@linux.intel.com> (raw)
In-Reply-To: <20200311150516.GB21852@linux.intel.com>

On Wed, Mar 11, 2020 at 08:05:16AM -0700, Sean Christopherson wrote:
> On Tue, Mar 10, 2020 at 06:51:49PM -0400, Krish Sadhukhan wrote:
> > +	/*
> > +	 * The address of TR, FS, GS and LDTR must be canonical.
> > +	 */
> > +	TEST_SEGMENT_BASE_ADDR_CANONICAL(GUEST_BASE_TR, "GUEST_BASE_TR");
> > +	TEST_SEGMENT_BASE_ADDR_CANONICAL(GUEST_BASE_FS, "GUEST_BASE_FS");
> > +	TEST_SEGMENT_BASE_ADDR_CANONICAL(GUEST_BASE_GS, "GUEST_BASE_GS");
> 
> FS/GS bases aren't checked if the segment is unusable.

Ah, I stand corrected, I misread the section on loading guest segs.   There
is an exception clause for FS/GS base inside the unusuable path.  And the
"checks on guest segments" clearly states FS/GS base are unconditionally
checked.

  reply	other threads:[~2020-03-11 15:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 22:51 [PATCH] kvm-unit-test: nVMX: Test Selector and Base Address fields of Guest Segment registers Krish Sadhukhan
2020-03-10 22:51 ` [PATCH] kvm-unit-test: nVMX: Test Selector and Base Address fields of Guest Segment Registers on vmentry of nested guests Krish Sadhukhan
2020-03-11 15:05   ` Sean Christopherson
2020-03-11 15:19     ` Sean Christopherson [this message]
2020-03-11 20:38     ` Krish Sadhukhan
2020-03-11 21:46       ` Sean Christopherson
2020-03-11 21:53         ` Nadav Amit
2020-03-11 22:54           ` Liran Alon
2020-03-11 23:12             ` Sean Christopherson
2020-03-11 23:21               ` Nadav Amit
2020-03-11 23:25                 ` Sean Christopherson
2020-03-11 23:35                   ` Nadav Amit
2020-03-11 23:22               ` Liran Alon
2020-03-11 23:30                 ` Sean Christopherson
2020-03-10 23:51 ` [PATCH] kvm-unit-test: nVMX: Test Selector and Base Address fields of Guest Segment registers Jim Mattson
     [not found]   ` <20200311152459.GD21852@linux.intel.com>
2020-03-12 23:37     ` Krish Sadhukhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311151959.GC21852@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=jmattson@google.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.