From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 55BD87DBEB for ; Wed, 11 Mar 2020 15:55:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730196AbgCKPyy (ORCPT ); Wed, 11 Mar 2020 11:54:54 -0400 Received: from bmailout2.hostsharing.net ([83.223.78.240]:58981 "EHLO bmailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730053AbgCKPyy (ORCPT ); Wed, 11 Mar 2020 11:54:54 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id C40B128008AFC; Wed, 11 Mar 2020 16:54:51 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 8B36DB1FCF; Wed, 11 Mar 2020 16:54:51 +0100 (CET) Date: Wed, 11 Mar 2020 16:54:51 +0100 From: Lukas Wunner To: Daniel Borkmann Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Martin Mares , Dmitry Safonov <0x7f454c46@gmail.com>, Thomas Graf , Alexei Starovoitov , David Miller Subject: Re: [PATCH nf-next 3/3] netfilter: Introduce egress hook Message-ID: <20200311155451.e3mtgrdvuiujgvs6@wunner.de> References: <14ab7e5af20124a34a50426fd570da7d3b0369ce.1583927267.git.lukas@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Archived-At: List-Archive: List-Post: On Wed, Mar 11, 2020 at 03:05:16PM +0100, Daniel Borkmann wrote: > no need to make the fast-path slower for exotic protocols > which can be solved through other means. As said the fast-path gets faster, not slower. > > * Without this commit: > > Result: OK: 34240933(c34238375+d2558) usec, 100000000 (60byte,0frags) > > 2920481pps 1401Mb/sec (1401830880bps) errors: 0 > > > > * With this commit: > > Result: OK: 33997299(c33994193+d3106) usec, 100000000 (60byte,0frags) > > 2941410pps 1411Mb/sec (1411876800bps) errors: 0 > > So you are suggesting that we've just optimized the stack by adding more > hooks to it ...? Since I've provided numbers to disprove your allegation, I think the onus is now on you to prove that your allegation holds any water. Please reproduce the measurements and let's go from there. This isn't much work, I've made it really easy by providing all the steps necessary in the commit message. Thanks, Lukas