Re: [Outreachy kernel] [PATCH] staging: sm750fb: makefile variable longline fix

[Stefano Brivio <sbrivio@redhat.com>]

Hi Veera,

Thanks, this mostly looks good, in general. A few notes:

- the commit title is typically in an imperative form, that is, for
  example, "[...]: Fix long line in Makefile variable"

Also,

On Wed, 11 Mar 2020 18:41:02 +0530
R Veera Kumar <vkor@vkten.in> wrote:

> A simple makefile variable longline definition fix

It would be nice to also mention if you used a tool to find this.

> 
> Signed-off-by: R Veera Kumar <vkor@vkten.in>
> ---
>  drivers/staging/sm750fb/Makefile | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/Makefile b/drivers/staging/sm750fb/Makefile
> index 1cf3849cef23..6f832916ba65 100644
> --- a/drivers/staging/sm750fb/Makefile
> +++ b/drivers/staging/sm750fb/Makefile
> @@ -1,5 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_FB_SM750)	+= sm750fb.o
>  
> -sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
> -sm750fb-objs		+= ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
> +sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o
> +sm750fb-objs		+= ddk750_chip.o ddk750_power.o ddk750_mode.o
> +sm750fb-objs		+= ddk750_display.o ddk750_swi2c.o ddk750_sii164.o
> +sm750fb-objs		+= ddk750_dvi.o ddk750_hwi2c.o

...and while this fixes the long lines for sure, a more common way is
to use backslashes at the end of the lines. Compare it with other
similar cases: you don't need to do something like:
	drivers/staging/wfx/Makefile

but what's done for example in:
	drivers/staging/comedi/Makefile

looks appropriate here (using 3 or 4 lines I guess).

If you send another version of this patch, don't forget to indicate
that under "---", see recent discussions on the outreachy-kernel list
for examples.

-- 
Stefano