From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54017C0044D for ; Wed, 11 Mar 2020 18:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBADE20691 for ; Wed, 11 Mar 2020 18:03:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730680AbgCKSDc convert rfc822-to-8bit (ORCPT ); Wed, 11 Mar 2020 14:03:32 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:37541 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730468AbgCKSDb (ORCPT ); Wed, 11 Mar 2020 14:03:31 -0400 Received: from 2.general.sarnold.us.vpn ([10.172.64.71] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jC5hY-0003jD-1j; Wed, 11 Mar 2020 18:03:28 +0000 Date: Wed, 11 Mar 2020 18:03:26 +0000 From: Seth Arnold To: Kees Cook Cc: Alexander Viro , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs_parse: Remove pr_notice() about each validation Message-ID: <20200311180326.GA2007141@millbarge> References: <202003061617.A8835CAAF@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <202003061617.A8835CAAF@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2020 at 04:20:02PM -0800, Kees Cook wrote: > This notice fills my boot logs with scary-looking asterisks but doesn't > really tell me anything. Let's just remove it; validation errors > are already reported separately, so this is just a redundant list of > filesystems. > > $ dmesg | grep VALIDATE > [ 0.306256] *** VALIDATE tmpfs *** > [ 0.307422] *** VALIDATE proc *** > [ 0.308355] *** VALIDATE cgroup *** > [ 0.308741] *** VALIDATE cgroup2 *** > [ 0.813256] *** VALIDATE bpf *** > [ 0.815272] *** VALIDATE ramfs *** > [ 0.815665] *** VALIDATE hugetlbfs *** > [ 0.876970] *** VALIDATE nfs *** > [ 0.877383] *** VALIDATE nfs4 *** > > Signed-off-by: Kees Cook Excellent, these messages haven't been useful in helping users diagnose problems and they look quite noisy considering how mundane they are. Reviewed-by: Seth Arnold Thanks > --- > fs/fs_parser.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/fs_parser.c b/fs/fs_parser.c > index 7e6fb43f9541..ab53e42a874a 100644 > --- a/fs/fs_parser.c > +++ b/fs/fs_parser.c > @@ -368,8 +368,6 @@ bool fs_validate_description(const char *name, > const struct fs_parameter_spec *param, *p2; > bool good = true; > > - pr_notice("*** VALIDATE %s ***\n", name); > - > for (param = desc; param->name; param++) { > /* Check for duplicate parameter names */ > for (p2 = desc; p2 < param; p2++) { > -- > 2.20.1 > > > -- > Kees Cook