From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6802590976179175424 X-Received: by 2002:a5d:8d90:: with SMTP id b16mr3867079ioj.9.1583946287206; Wed, 11 Mar 2020 10:04:47 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a5d:8787:: with SMTP id f7ls553680ion.3.gmail; Wed, 11 Mar 2020 10:04:45 -0700 (PDT) X-Google-Smtp-Source: ADFU+vscwqcSScIdTA20BP+ZyfjRj7Cntg9jru3WTr92Z0fJkvmB+1ogfe8GW/ZqIwvOMqFd8t3A X-Received: by 2002:a6b:5406:: with SMTP id i6mr3765324iob.188.1583946285497; Wed, 11 Mar 2020 10:04:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583946285; cv=none; d=google.com; s=arc-20160816; b=Z+bW7BsyZP7vPIPaivfqBov14m+u2LHf+y6Z6Nrc+Ouhy53ACEoXF7mg3sJAjb+wqQ Zb1MCcucje1DKSTmu3wawd6EOKWp9oFv8LgbAjPvLolioLLkLyEb/3K6dZl7pvyAWGLe h9vDd1Nvr5EQX9SGLMLbHiymLtzXYtZTlRpXAv+6rrA29X4aPVmrl1ug8CkGzSZKrc/S qNrDnjNb/07Yu5D2ozB09oRdSH2BDLgUeZC8lEyxtpm1neGY9ZUBI7jYy9Sxywj40acO 0aZAqW4O2uhfT0J7OSElpLSeSGO88GXl4+bZNFL4xwW3+x6bGPQ8g23w80+o+hu1QCfD HPJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=jykx3cJByb3AWCb0WV64LkUlnx3R9Hi3e1lE7ij8ROg=; b=ts7ervpwoIhgYDkdMtdjr46vrkoTTP715BfSJgY658CBSGTYpwibkVWqDMpymZqQ+s ZjRO3OKg2yN8dwzHrrlTJnyxgT10eaj7mPyt4ApqOvRSWZw4dUmZiuDIvSm5Nqitlu1L gxUc2JQZN11KipITgqt1Mbxn0c5Qj1FLfrzhK1TYGKRtCOKehArozFg/K9zCc6sZ96/F YoiHL5Yuh4y0zTNJnWM2ejd6yzpqi2fcyfufCpY66u6sjNpS2q6dR0vpt32TFJ7oKt8E AhRNLJZJgpVGEdfvGMJ5SzTwaJxPr28FFdipR90fM7nYWpbL4xx9SOFO4UEsd+xSa/2I gvpg== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSWOdsI7; spf=pass (google.com: domain of sbrivio@redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=sbrivio@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com. [207.211.31.120]) by gmr-mx.google.com with ESMTPS id t64si97655iof.2.2020.03.11.10.04.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Mar 2020 10:04:45 -0700 (PDT) Received-SPF: pass (google.com: domain of sbrivio@redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSWOdsI7; spf=pass (google.com: domain of sbrivio@redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=sbrivio@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583946284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jykx3cJByb3AWCb0WV64LkUlnx3R9Hi3e1lE7ij8ROg=; b=XSWOdsI7jKXGkxrXUz+LY5oZdm1+A3z30b0kLKFdo823TlBRLLUqTsBd+bcDZIabFwC1Ig 5c/VL2s/FGhWhSl/6DWxfhyoo0hCVTjrDIDrz91fufSlkU6RBWhUDSSK4YspLSiPy2i33o Gc50xMUqvnZLKtE9DFesBAw6tIWBQmk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-fylXbBEaNUCy-xrSG-2R-A-1; Wed, 11 Mar 2020 13:04:39 -0400 X-MC-Unique: fylXbBEaNUCy-xrSG-2R-A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07B451937FC0; Wed, 11 Mar 2020 17:04:38 +0000 (UTC) Received: from elisabeth (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E1755D9C5; Wed, 11 Mar 2020 17:04:34 +0000 (UTC) Date: Wed, 11 Mar 2020 18:04:28 +0100 From: Stefano Brivio To: Shreeya Patel Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Subject: Re: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators Message-ID: <20200311180428.6489fe9b@elisabeth> In-Reply-To: <20200311131742.31068-1-shreeya.patel23498@gmail.com> References: <20200311131742.31068-1-shreeya.patel23498@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 On Wed, 11 Mar 2020 18:47:42 +0530 Shreeya Patel wrote: > Add space around operators for improving the code > readability. > Reported by checkpatch.pl > > git diff -w shows no difference. > diff of the .o files before and after the changes shows no difference. > > Signed-off-by: Shreeya Patel This looks good to me. Further clean-ups here could probably make this look less messy (there are long lines, unnecessary parentheses that are rather confusing, especially on that 4/5 factor, "magic" constants that might make sense to figure out the meaning of, etc.). Reviewed-by: Stefano Brivio -- Stefano From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 049F7C0044D for ; Wed, 11 Mar 2020 17:05:00 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58F5B206BE for ; Wed, 11 Mar 2020 17:05:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FPEs3uw4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58F5B206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9BC09226CF; Wed, 11 Mar 2020 17:04:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xvybCwDA+u+a; Wed, 11 Mar 2020 17:04:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 6A84C2094E; Wed, 11 Mar 2020 17:04:57 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D97841BF20F for ; Wed, 11 Mar 2020 17:04:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D4CAE84974 for ; Wed, 11 Mar 2020 17:04:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dO1i337cpLbS for ; Wed, 11 Mar 2020 17:04:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 862468496B for ; Wed, 11 Mar 2020 17:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583946293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jykx3cJByb3AWCb0WV64LkUlnx3R9Hi3e1lE7ij8ROg=; b=FPEs3uw4O44doXsUC8JLqfpAZavLwceIyb7QCzUsjKA+LblJxYS8eKLaRzHA2Kp4hJ+c5D kBqL98kYlRc9g4kUj0KUlFtxxAwjkSK0/4ziwWj2kbJCCkhUUnHJ+fFgrxJf1avnu95zmd CQCYoLQkgEpkN0VIy4mzaB6naIq5HyE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-fylXbBEaNUCy-xrSG-2R-A-1; Wed, 11 Mar 2020 13:04:39 -0400 X-MC-Unique: fylXbBEaNUCy-xrSG-2R-A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07B451937FC0; Wed, 11 Mar 2020 17:04:38 +0000 (UTC) Received: from elisabeth (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E1755D9C5; Wed, 11 Mar 2020 17:04:34 +0000 (UTC) Date: Wed, 11 Mar 2020 18:04:28 +0100 From: Stefano Brivio To: Shreeya Patel Subject: Re: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators Message-ID: <20200311180428.6489fe9b@elisabeth> In-Reply-To: <20200311131742.31068-1-shreeya.patel23498@gmail.com> References: <20200311131742.31068-1-shreeya.patel23498@gmail.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com, outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, nramas@linux.microsoft.com, Larry.Finger@lwfinger.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, 11 Mar 2020 18:47:42 +0530 Shreeya Patel wrote: > Add space around operators for improving the code > readability. > Reported by checkpatch.pl > > git diff -w shows no difference. > diff of the .o files before and after the changes shows no difference. > > Signed-off-by: Shreeya Patel This looks good to me. Further clean-ups here could probably make this look less messy (there are long lines, unnecessary parentheses that are rather confusing, especially on that 4/5 factor, "magic" constants that might make sense to figure out the meaning of, etc.). Reviewed-by: Stefano Brivio -- Stefano _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel