From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6046BC2BAEE for ; Wed, 11 Mar 2020 23:16:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44A952074E for ; Wed, 11 Mar 2020 23:16:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UjmjwKnw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44A952074E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCAaB-0000mS-AI for qemu-devel@archiver.kernel.org; Wed, 11 Mar 2020 19:16:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40144) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCAZV-0008Ty-CP for qemu-devel@nongnu.org; Wed, 11 Mar 2020 19:15:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCAZU-00009c-4K for qemu-devel@nongnu.org; Wed, 11 Mar 2020 19:15:29 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:23662 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCAZU-000091-0g for qemu-devel@nongnu.org; Wed, 11 Mar 2020 19:15:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583968527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6G/LMaO9hH21VN4cHb/mdjdgbMzewgKCwIzsylBbYjw=; b=UjmjwKnweNlQy5fLZiNNG9NqQ7gtTravPfmpGptesasMj6PI7EL4DoGxEWAPltsBVi4EfT RTeadsJXiWhU4kYVs3tkL3uavQCXiMKPqx4d4Zy81Q01vaUAYjWt+xyBjpCqvr7KM+/3aS /gyvSHkygoFhoRJaBiSVt66O99x/twc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-zO10iYHANP-C3ztaNJLhaw-1; Wed, 11 Mar 2020 19:15:25 -0400 X-MC-Unique: zO10iYHANP-C3ztaNJLhaw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 324381007272; Wed, 11 Mar 2020 23:15:24 +0000 (UTC) Received: from localhost (unused-10-15-17-6.yyz.redhat.com [10.15.17.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 895711001DC0; Wed, 11 Mar 2020 23:15:20 +0000 (UTC) Date: Wed, 11 Mar 2020 19:15:20 -0400 From: Eduardo Habkost To: "Michael S. Tsirkin" Subject: Re: [PATCH 1/2] Use -isystem for linux-headers dir Message-ID: <20200311231520.GP1187748@habkost.net> References: <20200311225130.1599619-1-ehabkost@redhat.com> <20200311225130.1599619-2-ehabkost@redhat.com> <20200311190458-mutt-send-email-mst@kernel.org> <20200311230806.GO1187748@habkost.net> MIME-Version: 1.0 In-Reply-To: <20200311230806.GO1187748@habkost.net> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Paolo Bonzini , jtomko@redhat.com, qemu-devel@nongnu.org, jingqi.liu@intel.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 11, 2020 at 07:08:06PM -0400, Eduardo Habkost wrote: > On Wed, Mar 11, 2020 at 07:05:45PM -0400, Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2020 at 06:51:29PM -0400, Eduardo Habkost wrote: > > > glibc and Linux-provided headers are known to generate macro > > > redefinition warnings when used together. For example: > > > and duplicate some macro definitions. > > >=20 > > > We normally never see those warnings because GCC suppresses > > > warnings generated by system headers. We carry our own copy of > > > Linux header files, though, and this makes those warnings not be > > > suppressed when glibc headers are included before Linux headers > > > (e.g. if is included before ). > > >=20 > > > Use -isystem instead of -I for linux-headers. This makes the > > > compiler treat our linux-headers directory the same way it treats > > > system-provided Linux headers, and suppress warnings generated by > > > them. > > >=20 > > > Signed-off-by: Eduardo Habkost > > > --- > > > Makefile.target | 2 +- > > > configure | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/Makefile.target b/Makefile.target > > > index 2d43dc586a..934a9f7431 100644 > > > --- a/Makefile.target > > > +++ b/Makefile.target > > > @@ -12,7 +12,7 @@ endif > > > =20 > > > $(call set-vpath, $(SRC_PATH):$(BUILD_DIR)) > > > ifdef CONFIG_LINUX > > > -QEMU_CFLAGS +=3D -I../linux-headers > > > +QEMU_CFLAGS +=3D -isystem ../linux-headers > > > endif > > > QEMU_CFLAGS +=3D -iquote .. -iquote $(SRC_PATH)/target/$(TARGET_BASE= _ARCH) -DNEED_CPU_H > > > =20 > > > diff --git a/configure b/configure > > > index cbf864bff1..04a2a7f2dd 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -899,7 +899,7 @@ Linux) > > > linux=3D"yes" > > > linux_user=3D"yes" > > > kvm=3D"yes" > > > - QEMU_INCLUDES=3D"-I\$(SRC_PATH)/linux-headers -I$PWD/linux-headers= $QEMU_INCLUDES" > > > + QEMU_INCLUDES=3D"-isystem \$(SRC_PATH)/linux-headers -I$PWD/linux-= headers $QEMU_INCLUDES" > >=20 > > Shouldn't both be -isystem? >=20 > I haven't noticed we had both. >=20 > This line looks weird, does anybody know why we have > $PWD/linux-headers here? This is why: commit a585140dd546ffb606ec506b362ab9decf1ab14e Author: Alexey Kardashevskiy Date: Wed May 29 23:30:43 2013 +1000 qemu: fix out of tree cross compile The symlink to "asm" platform linux headers is made in the build tree by the configure script but gcc is not told to look for them there. The patch fixes this. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Michael Tokarev --=20 Eduardo