From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B558CC1975A for ; Thu, 12 Mar 2020 06:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B90520575 for ; Thu, 12 Mar 2020 06:32:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="MdmdNzqJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387786AbgCLGcC (ORCPT ); Thu, 12 Mar 2020 02:32:02 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60674 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387875AbgCLGcB (ORCPT ); Thu, 12 Mar 2020 02:32:01 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02C6Rl2M011219; Thu, 12 Mar 2020 06:31:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=96anitlCLucRc7Rxq6Z65CxVwAN+xtGFFnozhiQVg1M=; b=MdmdNzqJUr1kCzQwNGsk6HMI/L73k9iHploydfbFztc9r64/ijOrEMVd+HU1+qYFMThc ELzN7uEZMjoJr3c9DVlne/xtxQrVnntXbZA2Pni/z4S6aXF/VHJvjIR24Q0dNyqJIOaB fCQ/Ke4ImT0F4+XjIBYB1ctJswnqqUjaYiV3lTUJLbreCZYYEvGc9FgyLU8Bj7Isfjew 0e32QVftWg9DjX5/kk7hE+/zVPWj0Kzw8vLZsA1jdsu1G4J1zGp/NX5TKQBOtRAks0cw Iq2aUhOhybIGJ64mdfDjlsoXDEeSjWbbk2Mu44/Fz0qJWK2L+S/PEjfniiTQhd+Pdg8Y AQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2yp7hmc1u3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 06:31:40 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02C6MLjp155279; Thu, 12 Mar 2020 06:31:40 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2yp8qymc4u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 06:31:40 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 02C6Vcfh025334; Thu, 12 Mar 2020 06:31:38 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 11 Mar 2020 23:31:37 -0700 Date: Thu, 12 Mar 2020 09:31:30 +0300 From: Dan Carpenter To: Chanwoo Choi Cc: Leonard Crestez , MyungJoo Ham , Kyungmin Park , Matthias Kaehlcke , Adam Ford , Artur =?utf-8?B?xZp3aWdvxYQ=?= , Krzysztof Kozlowski , "Rafael J. Wysocki" , Viresh Kumar , linux-imx@nxp.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PM / devfreq: Fix handling dev_pm_qos_remove_request result Message-ID: <20200312061800.GE11583@kadam> References: <780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9557 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003120033 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9557 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 priorityscore=1501 clxscore=1011 mlxscore=0 impostorscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003120033 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Mar 12, 2020 at 12:30:42PM +0900, Chanwoo Choi wrote: > On 3/12/20 12:15 PM, Leonard Crestez wrote: > > The dev_pm_qos_remove_request function can return 1 if > > "aggregated constraint value has changed" so only negative values should > > be reported as errors. > > > > Fixes: 27dbc542f651 ("PM / devfreq: Use PM QoS for sysfs min/max_freq") > > > > Reported-by: Dan Carpenter > > Signed-off-by: Leonard Crestez Since you're resending anyway, could you remove the blank line after the Fixes tag? All the tags go together at the end. (The blank line does not matter at all to anyone, purely aesthetic). regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F89C10DCE for ; Thu, 12 Mar 2020 06:31:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 285E520575 for ; Thu, 12 Mar 2020 06:31:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XZiMBnKX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="MdmdNzqJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 285E520575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IS+huZHMrTg71QVqCIzTGkKbBck2DZv46EuySIKjwRo=; b=XZiMBnKXDxFpFk 7boxb6i47p6YcDYoR7F3zB+nReORJMCmTFUg0c3paw/lzLjMcrddIMY5J1J8UsLHGB0JeGuoP9Mfa k61g54PAskiQakH8lRorSEVCq8BK5Dgs4kxwlIouF81+KbQOh+Fk5gN3gVZX4j4tdIZs4C3raTjEI 0W2lxwzia91IfOe51A5yO08IT11DbHWYz2Ni7pTJabhi+VxVoidtWuRJahHHsZ6v2hfoLlz5fKhKy ZdhQEGv9n9+mH+UrA1uRI45z32G9vRq05knpTKIflaE0wBEi2+t0R8ZewULZzSLaqJPM8rPJNvTIn FA3Kk1KTigjWgkpo9Y8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCHNm-0005Cc-VY; Thu, 12 Mar 2020 06:31:50 +0000 Received: from userp2120.oracle.com ([156.151.31.85]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCHNi-0005By-9k for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2020 06:31:49 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02C6Rl2M011219; Thu, 12 Mar 2020 06:31:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=96anitlCLucRc7Rxq6Z65CxVwAN+xtGFFnozhiQVg1M=; b=MdmdNzqJUr1kCzQwNGsk6HMI/L73k9iHploydfbFztc9r64/ijOrEMVd+HU1+qYFMThc ELzN7uEZMjoJr3c9DVlne/xtxQrVnntXbZA2Pni/z4S6aXF/VHJvjIR24Q0dNyqJIOaB fCQ/Ke4ImT0F4+XjIBYB1ctJswnqqUjaYiV3lTUJLbreCZYYEvGc9FgyLU8Bj7Isfjew 0e32QVftWg9DjX5/kk7hE+/zVPWj0Kzw8vLZsA1jdsu1G4J1zGp/NX5TKQBOtRAks0cw Iq2aUhOhybIGJ64mdfDjlsoXDEeSjWbbk2Mu44/Fz0qJWK2L+S/PEjfniiTQhd+Pdg8Y AQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2yp7hmc1u3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 06:31:40 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02C6MLjp155279; Thu, 12 Mar 2020 06:31:40 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2yp8qymc4u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 06:31:40 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 02C6Vcfh025334; Thu, 12 Mar 2020 06:31:38 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 11 Mar 2020 23:31:37 -0700 Date: Thu, 12 Mar 2020 09:31:30 +0300 From: Dan Carpenter To: Chanwoo Choi Subject: Re: [PATCH] PM / devfreq: Fix handling dev_pm_qos_remove_request result Message-ID: <20200312061800.GE11583@kadam> References: <780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <780efc9c-a85f-ef9f-e64f-68e5edce4cd3@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9557 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003120033 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9557 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 priorityscore=1501 clxscore=1011 mlxscore=0 impostorscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003120033 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_233147_088815_ACE60EA0 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Viresh Kumar , "Rafael J. Wysocki" , Artur =?utf-8?B?xZp3aWdvxYQ=?= , Krzysztof Kozlowski , Kyungmin Park , Matthias Kaehlcke , MyungJoo Ham , Leonard Crestez , Adam Ford , linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 12, 2020 at 12:30:42PM +0900, Chanwoo Choi wrote: > On 3/12/20 12:15 PM, Leonard Crestez wrote: > > The dev_pm_qos_remove_request function can return 1 if > > "aggregated constraint value has changed" so only negative values should > > be reported as errors. > > > > Fixes: 27dbc542f651 ("PM / devfreq: Use PM QoS for sysfs min/max_freq") > > > > Reported-by: Dan Carpenter > > Signed-off-by: Leonard Crestez Since you're resending anyway, could you remove the blank line after the Fixes tag? All the tags go together at the end. (The blank line does not matter at all to anyone, purely aesthetic). regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel