From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v1 3/3] drm/tegra: dc: Silence RGB output deferred-probe error Date: Thu, 12 Mar 2020 10:33:53 +0100 Message-ID: <20200312093353.GB1199023@ulmo> References: <20200308223809.23549-1-digetx@gmail.com> <20200308223809.23549-3-digetx@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bn2rw/3z4jIqBvZU" Return-path: Content-Disposition: inline In-Reply-To: <20200308223809.23549-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org --Bn2rw/3z4jIqBvZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 09, 2020 at 01:38:09AM +0300, Dmitry Osipenko wrote: > Driver fails to probe with -EPROBE_DEFER if display output isn't ready > yet. This produces a bit noisy error message in KMSG during kernel's boot > up on Tegra20 and Tegra30 because RGB output tends to be probed earlier > than a corresponding voltage regulator driver. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/tegra/dc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 56d933e81797..d7f2c4654b6b 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -2571,7 +2571,11 @@ static int tegra_dc_probe(struct platform_device *= pdev) > =20 > err =3D tegra_dc_rgb_probe(dc); > if (err < 0 && err !=3D -ENODEV) { > - dev_err(&pdev->dev, "failed to probe RGB output: %d\n", err); > + if (err =3D=3D -EPROBE_DEFER) > + dev_dbg(&pdev->dev, "RGB output probe deferred\n"); > + else > + dev_err(&pdev->dev, "failed to probe RGB output: %d\n", > + err); > return err; > } I'd prefer if we had just a single message and only differentiate on the kernel message level, something more along these lines: if (err < 0 && err !=3D -ENODEV) { const char *level =3D KERN_ERR; if (err =3D=3D -EPROBE_DEFER) level =3D KERN_DEBUG; dev_printk(level, dc->dev, "failed to probe RGB output: %d\n", err); return err; } Do you mind if I squash that into your patch? Thierry --Bn2rw/3z4jIqBvZU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl5qAf0ACgkQ3SOs138+ s6F7cw/+O35lxc5r6vj9s5CaQ62P06ket9HhkxwvO5/+Ja+IWAlbcn5oEGvk+hMh AhAKUG06jyhsQdTVB1AMzAkX9iNZ/08dThYj+/Ub2u4rU+zWkoDxGT8fKeXoPcDQ tbl4wq6s+7JL1Xwp2X4Owj3dxq89uZxRFryYjK0gcuaSkXF4IB14QZvca27kri8i MFA6Scoua9FlPbwGtYy1xqw00HxIPnk0f3iNp8M2VnpNpbMyrX6PFu8xF6SEBDaI JQkgQa8JfO97fFNdI+G9GnnoWlcrq5SFgtRGF134Cx36e9zxrErTNQzkOsEbY35Z 3M/fmNxAXV8d0erYR7UabwVPZR8FLUHEmjBQ+GoY43D/I+uQIZE5lZWwqLI8Lolx OnL4f0yBeUGgV7C4xwn2J4zBjGkPCRwmfZAc3OFRANHVf7NDWBF+N9awiKuwrMvV mq8+XR+mvPBrrrYxlHSDV0m24T/4xDHC88NoZ+fwSgwnV/XKxwbOeddMmL9JHVkb Mzj193AFrVuPGAEBguXBdVKndajsphdDIjqvUVqnPOJvOHG+5gOgqpzQwiPttaX4 Wh2q6nWMh7I9z5uOv+HgC3UOs44rjQY3XZtJWR3VWrKddevSUAqj1L3C0qnEbtP8 N/HKRWNj8I5bv2RmTBSujVivFFhxJD1mp03nF4PSiPefW3Zkgyg= =GCDB -----END PGP SIGNATURE----- --Bn2rw/3z4jIqBvZU-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5435FC10DCE for ; Thu, 12 Mar 2020 09:34:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 300CE20674 for ; Thu, 12 Mar 2020 09:34:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OLKx0puZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 300CE20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8026D6E0CB; Thu, 12 Mar 2020 09:33:59 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 076326E0CB for ; Thu, 12 Mar 2020 09:33:58 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id a141so5421364wme.2 for ; Thu, 12 Mar 2020 02:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gcUSGwWcahiMg4TCjkBZRNzVm/BoVmZE25MELfHaX/Q=; b=OLKx0puZQbng2hoGJNvGbLv4nYwbK6YtgBzfO/+Qzjn2v5uJ7Am+GkLSZc+abhwJQg UqN5RnghzyaTDZDq2V3RdqQZO0O/0JxsRGo/p2T7a52AAHxCFYbXWGu6MS1776CqdqsR 0/mhYyBp9njBBDRKeR+xPfb4B3T8kDuTytjG054p6ZswdGP3I4zl4TqI9XNjZrOUb/VK goJCzkMycWm2PG1BTLVcWI2vJFvr6FIYJU9YHP6tsseWz3p1lFWytMkCoqb3RX+CyOFu NsI0BjNhPUMxt1XN9E+EeYtkWHdg8+A6bpwOp3LdUu8hDotH0HfehRcqtB27Nz3MjRCJ DGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gcUSGwWcahiMg4TCjkBZRNzVm/BoVmZE25MELfHaX/Q=; b=HRYba3PwLjPNucsPBFXVb3RW3EdzIcGWWEVMPLGoAFZo6jSBuZF3IQRaBBFP6ubkOC SG2bZ/DFnrDK13CbGEk4PXseI3DPXdz3MipqAfACC2L9WKO0rhC5SuWJW55ZwWwiXxvG IlePSiYFz72OdnOdEgpG2ahorSA5iRqLOE84m9SsIdaOE0MPAVajJaaYR4iBIx/hiKjA Z6QNVF9knAxWerqIDKdSCRL5qz9PQWFbAIIQSKHPaEu5QYDtPO/aepOh2muXrsp+V78C 08bPhpYgx0mQ43aXAO9w1rSfOajGp05y5K6KMR+uPJ+tBEPYJHI/rp1uifMa50R6TA5q opBw== X-Gm-Message-State: ANhLgQ33CuhjU0zozUHCCYPQIWwzLe6RpmqGjTLq1+ozEwrwEvcVR3P3 S1ofUWKJqHO5mojpdCXNaBg= X-Google-Smtp-Source: ADFU+vuzaA9ysORGD0kQb/tfxKduSsjHe6qfz4cjYXNs5L/yF4WtVxV9kXqVxr4X8rEhGfdIx6Qjzw== X-Received: by 2002:a1c:b657:: with SMTP id g84mr3912841wmf.107.1584005636670; Thu, 12 Mar 2020 02:33:56 -0700 (PDT) Received: from localhost (pD9E516A9.dip0.t-ipconnect.de. [217.229.22.169]) by smtp.gmail.com with ESMTPSA id o16sm60475248wrj.5.2020.03.12.02.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 02:33:55 -0700 (PDT) Date: Thu, 12 Mar 2020 10:33:53 +0100 From: Thierry Reding To: Dmitry Osipenko Subject: Re: [PATCH v1 3/3] drm/tegra: dc: Silence RGB output deferred-probe error Message-ID: <20200312093353.GB1199023@ulmo> References: <20200308223809.23549-1-digetx@gmail.com> <20200308223809.23549-3-digetx@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200308223809.23549-3-digetx@gmail.com> User-Agent: Mutt/1.13.1 (2019-12-14) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: multipart/mixed; boundary="===============1002604369==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1002604369== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bn2rw/3z4jIqBvZU" Content-Disposition: inline --Bn2rw/3z4jIqBvZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 09, 2020 at 01:38:09AM +0300, Dmitry Osipenko wrote: > Driver fails to probe with -EPROBE_DEFER if display output isn't ready > yet. This produces a bit noisy error message in KMSG during kernel's boot > up on Tegra20 and Tegra30 because RGB output tends to be probed earlier > than a corresponding voltage regulator driver. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/tegra/dc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 56d933e81797..d7f2c4654b6b 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -2571,7 +2571,11 @@ static int tegra_dc_probe(struct platform_device *= pdev) > =20 > err =3D tegra_dc_rgb_probe(dc); > if (err < 0 && err !=3D -ENODEV) { > - dev_err(&pdev->dev, "failed to probe RGB output: %d\n", err); > + if (err =3D=3D -EPROBE_DEFER) > + dev_dbg(&pdev->dev, "RGB output probe deferred\n"); > + else > + dev_err(&pdev->dev, "failed to probe RGB output: %d\n", > + err); > return err; > } I'd prefer if we had just a single message and only differentiate on the kernel message level, something more along these lines: if (err < 0 && err !=3D -ENODEV) { const char *level =3D KERN_ERR; if (err =3D=3D -EPROBE_DEFER) level =3D KERN_DEBUG; dev_printk(level, dc->dev, "failed to probe RGB output: %d\n", err); return err; } Do you mind if I squash that into your patch? Thierry --Bn2rw/3z4jIqBvZU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl5qAf0ACgkQ3SOs138+ s6F7cw/+O35lxc5r6vj9s5CaQ62P06ket9HhkxwvO5/+Ja+IWAlbcn5oEGvk+hMh AhAKUG06jyhsQdTVB1AMzAkX9iNZ/08dThYj+/Ub2u4rU+zWkoDxGT8fKeXoPcDQ tbl4wq6s+7JL1Xwp2X4Owj3dxq89uZxRFryYjK0gcuaSkXF4IB14QZvca27kri8i MFA6Scoua9FlPbwGtYy1xqw00HxIPnk0f3iNp8M2VnpNpbMyrX6PFu8xF6SEBDaI JQkgQa8JfO97fFNdI+G9GnnoWlcrq5SFgtRGF134Cx36e9zxrErTNQzkOsEbY35Z 3M/fmNxAXV8d0erYR7UabwVPZR8FLUHEmjBQ+GoY43D/I+uQIZE5lZWwqLI8Lolx OnL4f0yBeUGgV7C4xwn2J4zBjGkPCRwmfZAc3OFRANHVf7NDWBF+N9awiKuwrMvV mq8+XR+mvPBrrrYxlHSDV0m24T/4xDHC88NoZ+fwSgwnV/XKxwbOeddMmL9JHVkb Mzj193AFrVuPGAEBguXBdVKndajsphdDIjqvUVqnPOJvOHG+5gOgqpzQwiPttaX4 Wh2q6nWMh7I9z5uOv+HgC3UOs44rjQY3XZtJWR3VWrKddevSUAqj1L3C0qnEbtP8 N/HKRWNj8I5bv2RmTBSujVivFFhxJD1mp03nF4PSiPefW3Zkgyg= =GCDB -----END PGP SIGNATURE----- --Bn2rw/3z4jIqBvZU-- --===============1002604369== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1002604369==--