From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA8BC10DCE for ; Thu, 12 Mar 2020 10:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB29D206FA for ; Thu, 12 Mar 2020 10:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="zQX0ru89" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726911AbgCLKLr (ORCPT ); Thu, 12 Mar 2020 06:11:47 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:40416 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgCLKLq (ORCPT ); Thu, 12 Mar 2020 06:11:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=w/IhOjRvXC482b0KYkKadqEdR2iC079En/fPLUwhOKA=; b=zQX0ru89FGMsRzrWSfb1/f9Sx 58KjHkMU8xb9ife2j0YCZEP6uKjBW9qqUf7GZa1VLXn/G2O0gLiqAh3PGq9lSvKs8YXoDzS2RxfDb RCptmxmBe+q0a8VQvqBItrRhf96aBtF4u4ws2M/4S9GIgmbXDs9TRAWalsFAwSj+WcrKDfAB0DGvi MpYnoDO4fRbMuJer11qOtU5WskxbvCuEDDoTQkejLesgwqD5JorY4XUljARGZaF5UnBtDcnd1x/oW bs3tDGtB6bzFsygvHfjpEZTXZRA6cW0hsVWYUyIpvWVMq34JSON8HBMjX3wJcFJ0NgyQV3EuL2EaH jxI7mzwmA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35400) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jCKoO-0000Wi-FR; Thu, 12 Mar 2020 10:11:32 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jCKoM-0006Eu-Ai; Thu, 12 Mar 2020 10:11:30 +0000 Date: Thu, 12 Mar 2020 10:11:30 +0000 From: Russell King - ARM Linux admin To: Joe Perches Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough; Message-ID: <20200312101130.GX25745@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 09:51:20PM -0700, Joe Perches wrote: > Convert the various uses of fallthrough comments to fallthrough; And the point of what on the face of it seems to be useless churn is? What compilers support this? I'd check the gcc manual, but debian doesn't provide it. > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches > --- > arch/arm/mach-rpc/riscpc.c | 2 +- > drivers/scsi/arm/fas216.c | 17 ++++++----------- > 2 files changed, 7 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/mach-rpc/riscpc.c b/arch/arm/mach-rpc/riscpc.c > index ea2c842..d23970b 100644 > --- a/arch/arm/mach-rpc/riscpc.c > +++ b/arch/arm/mach-rpc/riscpc.c > @@ -46,7 +46,7 @@ static int __init parse_tag_acorn(const struct tag *tag) > switch (tag->u.acorn.vram_pages) { > case 512: > vram_size += PAGE_SIZE * 256; > - /* Fall through - ??? */ > + fallthrough; /* ??? */ > case 256: > vram_size += PAGE_SIZE * 256; > default: > diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c > index 6c68c230..bb18be 100644 > --- a/drivers/scsi/arm/fas216.c > +++ b/drivers/scsi/arm/fas216.c > @@ -603,8 +603,7 @@ static void fas216_handlesync(FAS216_Info *info, char *msg) > msgqueue_flush(&info->scsi.msgs); > msgqueue_addmsg(&info->scsi.msgs, 1, MESSAGE_REJECT); > info->scsi.phase = PHASE_MSGOUT_EXPECT; > - /* fall through */ > - > + fallthrough; > case async: > dev->period = info->ifcfg.asyncperiod / 4; > dev->sof = 0; > @@ -916,8 +915,7 @@ static void fas216_disconnect_intr(FAS216_Info *info) > fas216_done(info, DID_ABORT); > break; > } > - /* else, fall through */ > - > + fallthrough; > default: /* huh? */ > printk(KERN_ERR "scsi%d.%c: unexpected disconnect in phase %s\n", > info->host->host_no, fas216_target(info), fas216_drv_phase(info)); > @@ -1413,8 +1411,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne > case STATE(STAT_STATUS, PHASE_DATAOUT): /* Data Out -> Status */ > case STATE(STAT_STATUS, PHASE_DATAIN): /* Data In -> Status */ > fas216_stoptransfer(info); > - /* fall through */ > - > + fallthrough; > case STATE(STAT_STATUS, PHASE_SELSTEPS):/* Sel w/ steps -> Status */ > case STATE(STAT_STATUS, PHASE_MSGOUT): /* Message Out -> Status */ > case STATE(STAT_STATUS, PHASE_COMMAND): /* Command -> Status */ > @@ -1426,8 +1423,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne > case STATE(STAT_MESGIN, PHASE_DATAOUT): /* Data Out -> Message In */ > case STATE(STAT_MESGIN, PHASE_DATAIN): /* Data In -> Message In */ > fas216_stoptransfer(info); > - /* fall through */ > - > + fallthrough; > case STATE(STAT_MESGIN, PHASE_COMMAND): /* Command -> Message In */ > case STATE(STAT_MESGIN, PHASE_SELSTEPS):/* Sel w/ steps -> Message In */ > case STATE(STAT_MESGIN, PHASE_MSGOUT): /* Message Out -> Message In */ > @@ -1581,8 +1577,7 @@ static void fas216_funcdone_intr(FAS216_Info *info, unsigned int stat, unsigned > fas216_message(info); > break; > } > - /* else, fall through */ > - > + fallthrough; > default: > fas216_log(info, 0, "internal phase %s for function done?" > " What do I do with this?", > @@ -1964,7 +1959,7 @@ static void fas216_kick(FAS216_Info *info) > switch (where_from) { > case TYPE_QUEUE: > fas216_allocate_tag(info, SCpnt); > - /* fall through */ > + fallthrough; > case TYPE_OTHER: > fas216_start_command(info, SCpnt); > break; > -- > 2.24.0 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF72FC4CECE for ; Thu, 12 Mar 2020 10:11:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EC8A206FA for ; Thu, 12 Mar 2020 10:11:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jvgH75RP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="zQX0ru89" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EC8A206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+FaOWPJ2+c7LDHczB9GTxClWooykG6QkeKCxtulYAWI=; b=jvgH75RPBQZU40 Vs6zMdzl/vDkdpZR/1Md/DMre9IB4Xc5lCBtpHUXn+BN7XEFwkN70/banxD7E6/a/Do8iTycuRfWR FBoUAiT0CFOzCfBkOdOye3DlnPxUrG4X8UonAVMHYKp/olkW5MNNmIB2u28mFRUv1saQE+KSDiWd3 SR4RZjuLVbQ+dbKn9BsNt2+Y00QnuQSmF371GTEjG/SvoeR+z4VvSDT34EfxUtnDqg0xen2e2BSiK 77ik4CPFRxzWMwdNirsyT9l0RXJ7NG9eZZPfqZJi40AJMH40uEAj9ILA1heusA1KK2qUC3K9i5lYy Y8WeEjmtrLRHQbtCAu9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCKoh-0000zV-K3; Thu, 12 Mar 2020 10:11:51 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCKoc-0000yI-T4 for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2020 10:11:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=w/IhOjRvXC482b0KYkKadqEdR2iC079En/fPLUwhOKA=; b=zQX0ru89FGMsRzrWSfb1/f9Sx 58KjHkMU8xb9ife2j0YCZEP6uKjBW9qqUf7GZa1VLXn/G2O0gLiqAh3PGq9lSvKs8YXoDzS2RxfDb RCptmxmBe+q0a8VQvqBItrRhf96aBtF4u4ws2M/4S9GIgmbXDs9TRAWalsFAwSj+WcrKDfAB0DGvi MpYnoDO4fRbMuJer11qOtU5WskxbvCuEDDoTQkejLesgwqD5JorY4XUljARGZaF5UnBtDcnd1x/oW bs3tDGtB6bzFsygvHfjpEZTXZRA6cW0hsVWYUyIpvWVMq34JSON8HBMjX3wJcFJ0NgyQV3EuL2EaH jxI7mzwmA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35400) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jCKoO-0000Wi-FR; Thu, 12 Mar 2020 10:11:32 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jCKoM-0006Eu-Ai; Thu, 12 Mar 2020 10:11:30 +0000 Date: Thu, 12 Mar 2020 10:11:30 +0000 From: Russell King - ARM Linux admin To: Joe Perches Subject: Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough; Message-ID: <20200312101130.GX25745@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_031147_103335_D9BF9A8F X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, "James E.J. Bottomley" , linux-arm-kernel@lists.infradead.org, "Martin K. Petersen" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 10, 2020 at 09:51:20PM -0700, Joe Perches wrote: > Convert the various uses of fallthrough comments to fallthrough; And the point of what on the face of it seems to be useless churn is? What compilers support this? I'd check the gcc manual, but debian doesn't provide it. > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches > --- > arch/arm/mach-rpc/riscpc.c | 2 +- > drivers/scsi/arm/fas216.c | 17 ++++++----------- > 2 files changed, 7 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/mach-rpc/riscpc.c b/arch/arm/mach-rpc/riscpc.c > index ea2c842..d23970b 100644 > --- a/arch/arm/mach-rpc/riscpc.c > +++ b/arch/arm/mach-rpc/riscpc.c > @@ -46,7 +46,7 @@ static int __init parse_tag_acorn(const struct tag *tag) > switch (tag->u.acorn.vram_pages) { > case 512: > vram_size += PAGE_SIZE * 256; > - /* Fall through - ??? */ > + fallthrough; /* ??? */ > case 256: > vram_size += PAGE_SIZE * 256; > default: > diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c > index 6c68c230..bb18be 100644 > --- a/drivers/scsi/arm/fas216.c > +++ b/drivers/scsi/arm/fas216.c > @@ -603,8 +603,7 @@ static void fas216_handlesync(FAS216_Info *info, char *msg) > msgqueue_flush(&info->scsi.msgs); > msgqueue_addmsg(&info->scsi.msgs, 1, MESSAGE_REJECT); > info->scsi.phase = PHASE_MSGOUT_EXPECT; > - /* fall through */ > - > + fallthrough; > case async: > dev->period = info->ifcfg.asyncperiod / 4; > dev->sof = 0; > @@ -916,8 +915,7 @@ static void fas216_disconnect_intr(FAS216_Info *info) > fas216_done(info, DID_ABORT); > break; > } > - /* else, fall through */ > - > + fallthrough; > default: /* huh? */ > printk(KERN_ERR "scsi%d.%c: unexpected disconnect in phase %s\n", > info->host->host_no, fas216_target(info), fas216_drv_phase(info)); > @@ -1413,8 +1411,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne > case STATE(STAT_STATUS, PHASE_DATAOUT): /* Data Out -> Status */ > case STATE(STAT_STATUS, PHASE_DATAIN): /* Data In -> Status */ > fas216_stoptransfer(info); > - /* fall through */ > - > + fallthrough; > case STATE(STAT_STATUS, PHASE_SELSTEPS):/* Sel w/ steps -> Status */ > case STATE(STAT_STATUS, PHASE_MSGOUT): /* Message Out -> Status */ > case STATE(STAT_STATUS, PHASE_COMMAND): /* Command -> Status */ > @@ -1426,8 +1423,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne > case STATE(STAT_MESGIN, PHASE_DATAOUT): /* Data Out -> Message In */ > case STATE(STAT_MESGIN, PHASE_DATAIN): /* Data In -> Message In */ > fas216_stoptransfer(info); > - /* fall through */ > - > + fallthrough; > case STATE(STAT_MESGIN, PHASE_COMMAND): /* Command -> Message In */ > case STATE(STAT_MESGIN, PHASE_SELSTEPS):/* Sel w/ steps -> Message In */ > case STATE(STAT_MESGIN, PHASE_MSGOUT): /* Message Out -> Message In */ > @@ -1581,8 +1577,7 @@ static void fas216_funcdone_intr(FAS216_Info *info, unsigned int stat, unsigned > fas216_message(info); > break; > } > - /* else, fall through */ > - > + fallthrough; > default: > fas216_log(info, 0, "internal phase %s for function done?" > " What do I do with this?", > @@ -1964,7 +1959,7 @@ static void fas216_kick(FAS216_Info *info) > switch (where_from) { > case TYPE_QUEUE: > fas216_allocate_tag(info, SCpnt); > - /* fall through */ > + fallthrough; > case TYPE_OTHER: > fas216_start_command(info, SCpnt); > break; > -- > 2.24.0 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel