From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42627C2BB1D for ; Thu, 12 Mar 2020 13:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16EF02067C for ; Thu, 12 Mar 2020 13:47:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727406AbgCLNr3 (ORCPT ); Thu, 12 Mar 2020 09:47:29 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36694 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725978AbgCLNr2 (ORCPT ); Thu, 12 Mar 2020 09:47:28 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02CDlCBO022469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2020 09:47:14 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id BD68C420E5E; Thu, 12 Mar 2020 09:47:12 -0400 (EDT) Date: Thu, 12 Mar 2020 09:47:12 -0400 From: "Theodore Y. Ts'o" To: Joe Perches Cc: Masahiro Yamada , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-arm-kernel , Linux Kernel Mailing List Subject: Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Message-ID: <20200312134712.GE7159@mit.edu> References: <891a42ad8d8fd7beca911845108e1ded022ef3f7.camel@perches.com> <20200312085606.GA154268@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 02:37:31AM -0700, Joe Perches wrote: > As I have suggested a few times, better still > would be to have a mechanism for scripted patches > applied possibly as single treewide patch. > > Likely applied only at an -rc1. > > The stated negatives to a treewide mechanism > have been difficulty to backport to -stable. Any time we do a massive, disruptive change to the code base, it's going to cause problems to -stable. It means that bug fix patches won't necessarily auto-apply, and some will require manual fixups afterwards Given that this change doesn't really fix any bugs, I'd have to ask the question --- is it *worth* it? We really need to apply a certain amount of cost/benefit analysis around this. If it were really important, the thing we could do is to apply a single treewide patch at some point after the merge window. I'd suggest after -rc2, myself, but reasonable people can differ. And then, if it were *really* important we could run the same script on the stable kernels. But for changing "/* fallthrough */" to "fallthrough;" Does this ***really*** matter? Why are we tying ourselves up in knots trying to do this all at once? - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F1EC1975A for ; Thu, 12 Mar 2020 13:47:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8573D2067C for ; Thu, 12 Mar 2020 13:47:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lf4ufNRX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8573D2067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mNsV95OSHoczD59fCs/+JA8nee8wjy1CbdO8V7RhwXk=; b=lf4ufNRX8/5Iq0 o18fBpxCsFeyfKM8Eu5DANy1C5RNwfNntEqoaXTnu0ubusew0C1v3TBtABNhoPlcPm7g0GhRvu4FU A6yolbyePOv+2Y9rIPgBf7SgqbW8soXxOn6cNoMIyECLG/yVhnx9lKmcQQxmLNZn/PBlZrZ+mnxr2 jgMLWmqA+JgnNnkDb8U2DJZeeuSjgjNBjMSFZhWIc4id6mWDIDt5RE4Q75t+4IP6N1CUpuAHctYvi 7/vq8CPzH06yHm1vbioUKyLW5Af+ca7nBYsWSb94xeSelJKmccHDh4Cm7B5L9Jzd9HKSl7Jv8pk9I d9ZCiKNZ1PRwMwVu+loQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCOBG-0004oE-Hp; Thu, 12 Mar 2020 13:47:22 +0000 Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCOBE-0004nd-19 for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2020 13:47:21 +0000 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02CDlCBO022469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2020 09:47:14 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id BD68C420E5E; Thu, 12 Mar 2020 09:47:12 -0400 (EDT) Date: Thu, 12 Mar 2020 09:47:12 -0400 From: "Theodore Y. Ts'o" To: Joe Perches Subject: Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough; Message-ID: <20200312134712.GE7159@mit.edu> References: <891a42ad8d8fd7beca911845108e1ded022ef3f7.camel@perches.com> <20200312085606.GA154268@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_064720_265821_9AAFE2B7 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Masahiro Yamada , Linux Kernel Mailing List , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 12, 2020 at 02:37:31AM -0700, Joe Perches wrote: > As I have suggested a few times, better still > would be to have a mechanism for scripted patches > applied possibly as single treewide patch. > > Likely applied only at an -rc1. > > The stated negatives to a treewide mechanism > have been difficulty to backport to -stable. Any time we do a massive, disruptive change to the code base, it's going to cause problems to -stable. It means that bug fix patches won't necessarily auto-apply, and some will require manual fixups afterwards Given that this change doesn't really fix any bugs, I'd have to ask the question --- is it *worth* it? We really need to apply a certain amount of cost/benefit analysis around this. If it were really important, the thing we could do is to apply a single treewide patch at some point after the merge window. I'd suggest after -rc2, myself, but reasonable people can differ. And then, if it were *really* important we could run the same script on the stable kernels. But for changing "/* fallthrough */" to "fallthrough;" Does this ***really*** matter? Why are we tying ourselves up in knots trying to do this all at once? - Ted _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel