All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: stolee@gmail.com, git@vger.kernel.org, me@ttaylorr.com,
	christian.couder@gmail.com
Subject: Re: [Question] Is extensions.partialClone defunct?
Date: Thu, 12 Mar 2020 10:51:51 -0700	[thread overview]
Message-ID: <20200312175151.GB120942@google.com> (raw)
In-Reply-To: <20200312170714.180996-1-jonathantanmy@google.com>

Jonathan Tan wrote:
> Derrick Stolee wrote:

>> but it appears that we rely on the "remote.<name>.promisor = true"
>> setting instead of this extension.
>
> Hmm...besides giving the name of the promisor remote, the
> extensions.partialClone setting is there to prevent old versions of Git
> (that do not know this extension) from manipulating the repo.

Yes, so the lack of setting is a bug.

Christian, what would your prefered way be to fix this?  Should
extensions.partialclone specify a particular "default" promisor
remote, or should we use a new repository extension for multiple
promisors?

[...]
> I cloned and indeed it is as Stolee describes. Git still works as
> expected if I remove "promisor = true" and add
> "[extensions]\npartialclone=origin", so at least extensions.partialClone
> is still supported, even if not written by default.

Thanks for investigating.

Sincerely,
Jonathan

  reply	other threads:[~2020-03-12 17:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 12:23 [Question] Is extensions.partialClone defunct? Derrick Stolee
2020-03-12 17:07 ` Jonathan Tan
2020-03-12 17:51   ` Jonathan Nieder [this message]
2020-03-12 18:10     ` Junio C Hamano
2020-03-12 21:09     ` Taylor Blau
2020-03-12 21:17       ` Junio C Hamano
2020-03-12 21:30         ` Jeff King
2020-03-12 21:54     ` Christian Couder
2020-03-12 21:59       ` Christian Couder
2020-03-12 23:09       ` Jonathan Nieder
2020-03-14  6:43         ` Christian Couder
2021-06-05 13:01           ` Tao Klerks
2020-03-13  0:10       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312175151.GB120942@google.com \
    --to=jrnieder@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=me@ttaylorr.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.