All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sergey.Semin@baikalelectronics.ru
Cc: Lee Jones <lee.jones@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Paul Burton <paulburton@kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: syscon: Add syscon endian properties support
Date: Thu, 12 Mar 2020 16:11:02 -0500	[thread overview]
Message-ID: <20200312211102.GA21647@bogus> (raw)
In-Reply-To: <20200306130356.D9FCD8030794@mail.baikalelectronics.ru>

On Fri, Mar 06, 2020 at 04:03:38PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> 
> In accordance with the syscon-driver (drivers/mfd/syscon.c) the syscon
> dts-nodes may accept endian properties of the boolean type: little-endian,
> big-endian, native-endian. Lets make sure that syscon bindings json-schema
> also supports them.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 39375e4313d2..9ee404991533 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -61,6 +61,11 @@ properties:
>      description:
>        Reference to a phandle of a hardware spinlock provider node.
>  
> +patternProperties:
> +  "^(big|little|native)-endian$":
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: Bytes order of the system controller memory space.

Common properties should have a type definition in a common schema. For 
this one, I'd like it in the core schema in dtschema. 

I'd expect for any specific 'syscon', either none or only a subset of 
these are valid, so I don't think this should be added here.

Rob

  reply	other threads:[~2020-03-12 21:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200306130341.9585-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 13:03 ` [PATCH 1/4] dt-bindings: syscon: Add syscon endian properties support Sergey.Semin
2020-03-12 21:11   ` Rob Herring [this message]
2020-03-13 12:26     ` Sergey Semin
2020-03-06 13:03 ` [PATCH 2/4] dt-bindings: power: reset: Replace SYSCON reboot-mode legacy bindings with YAML-based one Sergey.Semin
2020-03-06 19:56   ` Sebastian Reichel
     [not found]   ` <20200306200551.49C47803087C@mail.baikalelectronics.ru>
2020-03-11 20:47     ` Sergey Semin
2020-03-12 21:12   ` Rob Herring
2020-03-06 13:03 ` [PATCH 3/4] dt-bindings: power: reset: Add regmap support to the SYSCON reboot-mode bindings Sergey.Semin
2020-03-06 19:57   ` Sebastian Reichel
2020-03-12 21:14   ` Rob Herring
2020-03-13 13:02     ` Sergey Semin
2020-03-14 18:04       ` Sebastian Reichel
2020-03-18 23:14       ` Rob Herring
2020-03-31 19:50         ` Sergey Semin
2020-04-16 19:56           ` Sergey Semin
2020-04-16 21:28             ` Rob Herring
2020-04-17  7:45               ` Sergey Semin
2020-03-06 13:03 ` [PATCH 4/4] power: reset: syscon-reboot-mode: Add regmap dts-property support Sergey.Semin
2020-03-06 19:57   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312211102.GA21647@bogus \
    --to=robh@kernel.org \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=paulburton@kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.