From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jDTpK-0001Hd-QT for mharc-grub-devel@gnu.org; Sun, 15 Mar 2020 10:01:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46986) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDTpH-0001HV-NL for grub-devel@gnu.org; Sun, 15 Mar 2020 10:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDTpG-0007Bj-JP for grub-devel@gnu.org; Sun, 15 Mar 2020 10:01:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42979) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDTpG-000755-6h for grub-devel@gnu.org; Sun, 15 Mar 2020 10:01:10 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 477A222195; Sun, 15 Mar 2020 10:01:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 15 Mar 2020 10:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=6sP1tSL3VftG+kI6F/qpZnxrYyg sc8SVbRFLt9MDy/k=; b=q3oQaR3liYhuwGcfafBeFnJ7QvdsXFQh03UTPRSN8Am 42RSy211Uv2uIY+CpefTLGa+M/KaddklqelUYsDqmOHyQiwnzR4JC4QSzmtcK/Wo FkZV9TuHbUDgFBe3BvPryiBsUhZHp0K/ZmLQJXPV0CCNb3nwoGRhNGO4SfoGwfQ/ ijNJEfp0Ha8NgzALFiuijjiZMtQi91l+wXecpLilRAnmcoOOsYbiAnOt+N8y5Ec4 RC56Kp3EsHj+02kzYkcvXcuiz0Lp19wSrik8dkqJNiku858AiT0QBdRzFn/CYzPL ULC0opet+weQMD7MgJbVySkDHDdqjMBDfIadgH1TGLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=6sP1tS L3VftG+kI6F/qpZnxrYygsc8SVbRFLt9MDy/k=; b=m0bbJ1pFUDVb32WBKsjwX/ QHvbHsRD3otJrSzTM/PcSXo/eTpdB4f1QRo0Uw5PtCdVe409y9hp0aTRyLCvDb7B NxeRiOT3rX0r+9R8e8ESqeZHONKi9Rnj4Oz1azv/gzz0nMk/pEtkhzCcpdeyQ9vb lsyZWmcklgR/d3vkTd3POikyi4vmYYN9S67L3iiWXylqeX7kKMqncPpsrmGFKmq6 eoyc1ZiU0k2Rc/x5kHIy3gFFVBUC/4LvKmd2gaotszgS2JJVA6OekHZ8sryZh3KW jayyU0kNnJpXGh0LX3U3gxssUPK+JH2dQ/mEO+zHTywDWrXfSOFR062KgMV6XvkA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeftddgudejiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecukfhppeejkedrhe egrddukeehrdduieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail (x4e36b910.dyn.telefonica.de [78.54.185.16]) by mail.messagingengine.com (Postfix) with ESMTPA id 3118E328005D; Sun, 15 Mar 2020 10:01:07 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail (OpenSMTPD) with ESMTPSA id c37af1af (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 15 Mar 2020 14:01:02 +0000 (UTC) Date: Sun, 15 Mar 2020 15:01:05 +0100 From: Patrick Steinhardt To: Daniel Kiper Cc: Leif Lindholm , grub-devel@gnu.org, agraf@csgraf.de, pjones@redhat.com, mjg59@google.com, phcoder@gmail.com, Milan Broz Subject: Re: [PATCH v3 1/5] efi: Always try to allocate heap size of 1.6GB Message-ID: <20200315140105.GA4662@ncase> References: <20200313125508.GO23627@bivouac.eciton.net> <20200313135946.cwfyzbmjkw2yy5q4@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline In-Reply-To: <20200313135946.cwfyzbmjkw2yy5q4@tomti.i.net-space.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Mar 2020 14:01:13 -0000 --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 13, 2020 at 02:59:46PM +0100, Daniel Kiper wrote: > Patrick, please make Argon2 functionality enabled/disabled by the > ./configure. By default it have to be disabled. Additionally, please add > to the grub-dev.texi an explanation what is the impact of enabling Argon2. Is there any obvious way to conditionally build modules and libs into the kernel based on a feature flag? The only way I see it to be doable is by re-using groups as known by gentpl.py, so that I may do the following: # Makefile.util.def library = { name = libgrubkern.a; cflags = '$(CFLAGS_GNULIB)'; cppflags = '$(CPPFLAGS_GNULIB) -I$(srcdir)/grub-core/lib/json'; argon2_cppflags = '$(CPPFLAGS_GNULIB) -I$(srcdir)/grub-core/lib/json -I$(srcdir)/grub-core/lib/argon2'; common = util/misc.c; common = grub-core/kern/command.c; common = grub-core/kern/device.c; ... argon2 = grub-core/lib/argon2/argon2.c; argon2 = grub-core/lib/argon2/core.c; argon2 = grub-core/lib/argon2/ref.c; argon2 = grub-core/lib/argon2/blake2/blake2b.c; }; # grub-core/Makefile.core.def module = { name = argon2; common = lib/argon2/argon2.c; common = lib/argon2/core.c; common = lib/argon2/ref.c; common = lib/argon2/blake2/blake2b.c; enable = argon2; }; module = { name = luks2; common = disk/luks2.c; common = lib/gnulib/base64.c; cflags = '$(CFLAGS_POSIX) $(CFLAGS_GNULIB)'; cppflags = '$(CPPFLAGS_POSIX) $(CPPFLAGS_GNULIB) -I$(srcdir)/lib/json'; argon2_cppflags = '$(CPPFLAGS_POSIX) $(CPPFLAGS_GNULIB) -I$(srcdir)/lib/json -I$(srcdir)/lib/argon2'; }; I don't think that gentpl.py is currently able to act based on configure options, but only decides by build platforms. Please let me know I'm missing the bigger picture here, and if there's any module that already does that kind of stuff that'd be a great help. Patrick --0F1p//8PRICkK4MW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl5uNR8ACgkQVbJhu7ck PpRWjQ/+PSsKV0hBQovKrM/iOnf4z2ug2UVXee9qbDLAxaHYK1DK11W4cLeTHGdq qTSMoFVM1Ij5Qi4xeSSp1tAPwOq8ivqB6XU4GmHRw3gzCrOL/8t6aa59EJDa5DEA 5XtBYYjF80tZJufhcNxhG6WfzYwfB2T4Y11App5onfMHlNqr2w6oOUW6Kitb5sf+ tTfp5D2e5eEYkVNxIbd3i7k3Rh4ugDf6ZQ1pTMast4PXldKdJblGlvm69/iYyui+ fGY8iji+DCRr6lk3BrZ4LHfDhEWt0IxfepMgVoklgNQPVuULB4N28LPVYdnoaHJA sivsRMLJN6C386F3L/xao0QOgePibmEyPn9rcFIy8lG4v7ZFF+mdORTk9/iUUtCW 4xcVzOZrFApNHWe8v++E8G4dun+LUMS5hPxDhxnTLsxobxt0bE1Y4VnoE5xK3B/k kDGshYWY0W+wDlrqEsxHODwpmAYoOVLXJeliGeBmgY1ym5sVNg9rJ5Ve1VdaWa86 7Y3WHe5HaWyOr/QDZprTNzaKIhG1Eo+Z2G9xhSOZws4oj+cHuy8tEhVbO28mtItg mbmQFgLbA4KRuCX9Cwlw+u2MznlJ90o53WL27CuEPHpzLLPHY3ngTIPByfpfs3CT 3UEZvSaCbZvARr+V8la6wquW6hi6nxTuE3jmBIxtMpHEjCblgyM= =pGK0 -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW--