From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A5CC2BB1D for ; Mon, 16 Mar 2020 15:39:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09A0620663 for ; Mon, 16 Mar 2020 15:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731770AbgCPPjX (ORCPT ); Mon, 16 Mar 2020 11:39:23 -0400 Received: from elvis.franken.de ([193.175.24.41]:44987 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731703AbgCPPjW (ORCPT ); Mon, 16 Mar 2020 11:39:22 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jDrpX-0008Kq-01; Mon, 16 Mar 2020 16:39:03 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 79690C107B; Mon, 16 Mar 2020 16:32:02 +0100 (CET) Date: Mon, 16 Mar 2020 16:32:02 +0100 From: Thomas Bogendoerfer To: afzal mohammed Cc: Nathan Chancellor , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , Paul Burton , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "Maciej W. Rozycki" , Jiaxun Yang , Keguang Zhang , Huacai Chen , John Crispin Subject: Re: [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq() Message-ID: <20200316153202.GB13674@alpha.franken.de> References: <20200304203144.GA4323@alpha.franken.de> <20200305115759.3186-1-afzal.mohd.ma@gmail.com> <20200311053126.GA48442@ubuntu-m2-xlarge-x86> <20200311090308.GA5060@afzalpc> <20200311104217.GA10615@alpha.franken.de> <20200311131210.GA5115@afzalpc> <20200311160307.GA15464@alpha.franken.de> <20200311163249.GA4984@afzalpc> <20200313121138.GA5985@afzalpc> <20200314081312.GA4948@afzalpc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200314081312.GA4948@afzalpc> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 14, 2020 at 01:43:12PM +0530, afzal mohammed wrote: > Recently all usages of setup_irq() was replaced by request_irq(). > request_irq() does a few sanity checks that were not done in > setup_irq(), if they fail irq registration will fail. One of the check > is to ensure that non-NULL dev_id is passed in the case of shared irq. > This caused malta on qemu to hang. > > Fix it by passing handler as dev_id to all request_irq()'s that are > shared. For sni, instead of passing non-NULL dev_id, remove shared irq > flags. > > Fixes: ac8fd122e070 ("MIPS: Replace setup_irq() by request_irq()") > Reported-by: Nathan Chancellor > Suggested-by: Thomas Bogendoerfer > Signed-off-by: afzal mohammed thank you, applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AEB7C18E5B for ; Mon, 16 Mar 2020 15:39:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FEC720738 for ; Mon, 16 Mar 2020 15:39:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hZydMKU3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FEC720738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1euTDuoBZomkyQL+H3YGvA6EYI/uHKfjcSIkjXDUGaQ=; b=hZydMKU3nHS03T S8gRO3X2Nj6n3pZ2lJLlZWKgw7DT1CZYw28J3DWDLsQtlNTNlEICLfkV834x6YeZRzNa6zui2bm7N ml2jacbyM+3/RlPXP2v6rpXG7WMgaCWdNmUVcAVfPVsh6aarsTIQGETRVdhnV9P7a3q3zhJgkxxVH qR6Kq+3yzo2xkfC8fWWzlGNofotpcytFzZhKzN37q99g/S5+FRqLU8eGpT/z9/cJkD4c8wOzTIV3E EvREg1RirUeZ9Hs5CReilUkIbf9WLKWukG/zpz40WzSIscSt1QfaFJebBM6FJV8W0i8X5yKErciUV Y+sVhfyc8mwryzgnZjaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDrpx-0006CJ-FE; Mon, 16 Mar 2020 15:39:29 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDrpu-0006B2-Ft for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 15:39:28 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jDrpX-0008Kq-01; Mon, 16 Mar 2020 16:39:03 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 79690C107B; Mon, 16 Mar 2020 16:32:02 +0100 (CET) Date: Mon, 16 Mar 2020 16:32:02 +0100 From: Thomas Bogendoerfer To: afzal mohammed Subject: Re: [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq() Message-ID: <20200316153202.GB13674@alpha.franken.de> References: <20200304203144.GA4323@alpha.franken.de> <20200305115759.3186-1-afzal.mohd.ma@gmail.com> <20200311053126.GA48442@ubuntu-m2-xlarge-x86> <20200311090308.GA5060@afzalpc> <20200311104217.GA10615@alpha.franken.de> <20200311131210.GA5115@afzalpc> <20200311160307.GA15464@alpha.franken.de> <20200311163249.GA4984@afzalpc> <20200313121138.GA5985@afzalpc> <20200314081312.GA4948@afzalpc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200314081312.GA4948@afzalpc> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200316_083926_682015_3C7FD785 X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Paul Burton , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Jiaxun Yang , "Maciej W. Rozycki" , John Crispin , Huacai Chen , Nathan Chancellor , Keguang Zhang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 14, 2020 at 01:43:12PM +0530, afzal mohammed wrote: > Recently all usages of setup_irq() was replaced by request_irq(). > request_irq() does a few sanity checks that were not done in > setup_irq(), if they fail irq registration will fail. One of the check > is to ensure that non-NULL dev_id is passed in the case of shared irq. > This caused malta on qemu to hang. > > Fix it by passing handler as dev_id to all request_irq()'s that are > shared. For sni, instead of passing non-NULL dev_id, remove shared irq > flags. > > Fixes: ac8fd122e070 ("MIPS: Replace setup_irq() by request_irq()") > Reported-by: Nathan Chancellor > Suggested-by: Thomas Bogendoerfer > Signed-off-by: afzal mohammed thank you, applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel