From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE10BC0044D for ; Mon, 16 Mar 2020 10:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EB9B20663 for ; Mon, 16 Mar 2020 10:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730661AbgCPKnd (ORCPT ); Mon, 16 Mar 2020 06:43:33 -0400 Received: from mx.socionext.com ([202.248.49.38]:42881 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730582AbgCPKnc (ORCPT ); Mon, 16 Mar 2020 06:43:32 -0400 Received: from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 16 Mar 2020 19:43:31 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan-ex.css.socionext.com (Postfix) with ESMTP id 5E0A76002C; Mon, 16 Mar 2020 19:43:31 +0900 (JST) Received: from 172.31.9.53 (172.31.9.53) by m-FILTER with ESMTP; Mon, 16 Mar 2020 19:43:31 +0900 Received: from yuzu.css.socionext.com (yuzu [172.31.8.45]) by iyokan.css.socionext.com (Postfix) with ESMTP id C95E540350; Mon, 16 Mar 2020 19:43:30 +0900 (JST) Received: from [10.213.132.48] (unknown [10.213.132.48]) by yuzu.css.socionext.com (Postfix) with ESMTP id A467A12013D; Mon, 16 Mar 2020 19:43:30 +0900 (JST) Date: Mon, 16 Mar 2020 19:43:30 +0900 From: Kunihiko Hayashi To: Masahiro Yamada Subject: Re: [PATCH 01/10] ARM: dts: uniphier: Add XDMAC node Cc: Rob Herring , DTML , linux-arm-kernel , Masami Hiramatsu , Jassi Brar In-Reply-To: References: <1584061096-23686-2-git-send-email-hayashi.kunihiko@socionext.com> Message-Id: <20200316194330.B482.4A936039@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.70 [ja] Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 14 Mar 2020 11:14:09 +0900 wrote: > On Fri, Mar 13, 2020 at 9:58 AM Kunihiko Hayashi > wrote: > > > > Add external DMA controller support implemented in UniPhier SoCs. > > This supports for Pro4, Pro5 and PXs2. > > > > Signed-off-by: Kunihiko Hayashi > > --- > > arch/arm/boot/dts/uniphier-pro4.dtsi | 8 ++++++++ > > arch/arm/boot/dts/uniphier-pro5.dtsi | 8 ++++++++ > > arch/arm/boot/dts/uniphier-pxs2.dtsi | 8 ++++++++ > > 3 files changed, 24 insertions(+) > > > > diff --git a/arch/arm/boot/dts/uniphier-pro4.dtsi b/arch/arm/boot/dts/uniphier-pro4.dtsi > > index 2ec04d7..a1bfe0f 100644 > > --- a/arch/arm/boot/dts/uniphier-pro4.dtsi > > +++ b/arch/arm/boot/dts/uniphier-pro4.dtsi > > @@ -426,6 +426,14 @@ > > }; > > }; > > > > + xdmac: dma-controller@5fc10000 { > > + compatible = "socionext,uniphier-xdmac"; > > + reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>; > > > > This is odd. > <0x5fc20000 0x800> causes reg overwrap with > aidet@5fc20000 below. Thank you for pointing out. Indeed, the address is wrong. I'll fix it. And I'll also fix the example of dt-bindings. Thank you, --- Best Regards, Kunihiko Hayashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6092C18E5B for ; Mon, 16 Mar 2020 10:43:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84B9220658 for ; Mon, 16 Mar 2020 10:43:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lz+Pchje" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84B9220658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:References: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IRLhWO3RMI7lmuK7GT0+6iBm7NBzzyFDceD8PH6Jxek=; b=Lz+Pchje/BnYiM +6UcFjQWH/eXJAfMTL/iQhq7fN0pICG1JQcMU3WdfOMPP0eToT96GCeRabvMfhglMCCOHZGWEhEad +VJsJiX2FhdHu8Ge2dLz3iGIEo88TH9rEqZiK3hFhEBFncxOjLnxDw9jHZlNZItGo1z6E+i1JXghL Y8qImWArB7vZCjEgswlvZcDBGf1xrgq35nWhwcdah8P8FP6VSNUg279hVedZb2wvu7fj6hYEa1zPN P0UYcNkx1fBUilnvkKtEGgDAp6aPzhkW9wVlPECy7oZAQidb2VVFXo+Qxu5V8atdlXYnbkBHfMcoa 7Y9FWvxr4E/qKYaNEGNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDnDi-0005Rh-Pi; Mon, 16 Mar 2020 10:43:42 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDnDZ-0005Kb-R3 for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2020 10:43:35 +0000 Received: from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 16 Mar 2020 19:43:31 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan-ex.css.socionext.com (Postfix) with ESMTP id 5E0A76002C; Mon, 16 Mar 2020 19:43:31 +0900 (JST) Received: from 172.31.9.53 (172.31.9.53) by m-FILTER with ESMTP; Mon, 16 Mar 2020 19:43:31 +0900 Received: from yuzu.css.socionext.com (yuzu [172.31.8.45]) by iyokan.css.socionext.com (Postfix) with ESMTP id C95E540350; Mon, 16 Mar 2020 19:43:30 +0900 (JST) Received: from [10.213.132.48] (unknown [10.213.132.48]) by yuzu.css.socionext.com (Postfix) with ESMTP id A467A12013D; Mon, 16 Mar 2020 19:43:30 +0900 (JST) Date: Mon, 16 Mar 2020 19:43:30 +0900 From: Kunihiko Hayashi To: Masahiro Yamada Subject: Re: [PATCH 01/10] ARM: dts: uniphier: Add XDMAC node In-Reply-To: References: <1584061096-23686-2-git-send-email-hayashi.kunihiko@socionext.com> Message-Id: <20200316194330.B482.4A936039@socionext.com> MIME-Version: 1.0 X-Mailer: Becky! ver. 2.70 [ja] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200316_034334_020770_A72B0755 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Rob Herring , Masami Hiramatsu , linux-arm-kernel , Jassi Brar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 14 Mar 2020 11:14:09 +0900 wrote: > On Fri, Mar 13, 2020 at 9:58 AM Kunihiko Hayashi > wrote: > > > > Add external DMA controller support implemented in UniPhier SoCs. > > This supports for Pro4, Pro5 and PXs2. > > > > Signed-off-by: Kunihiko Hayashi > > --- > > arch/arm/boot/dts/uniphier-pro4.dtsi | 8 ++++++++ > > arch/arm/boot/dts/uniphier-pro5.dtsi | 8 ++++++++ > > arch/arm/boot/dts/uniphier-pxs2.dtsi | 8 ++++++++ > > 3 files changed, 24 insertions(+) > > > > diff --git a/arch/arm/boot/dts/uniphier-pro4.dtsi b/arch/arm/boot/dts/uniphier-pro4.dtsi > > index 2ec04d7..a1bfe0f 100644 > > --- a/arch/arm/boot/dts/uniphier-pro4.dtsi > > +++ b/arch/arm/boot/dts/uniphier-pro4.dtsi > > @@ -426,6 +426,14 @@ > > }; > > }; > > > > + xdmac: dma-controller@5fc10000 { > > + compatible = "socionext,uniphier-xdmac"; > > + reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>; > > > > This is odd. > <0x5fc20000 0x800> causes reg overwrap with > aidet@5fc20000 below. Thank you for pointing out. Indeed, the address is wrong. I'll fix it. And I'll also fix the example of dt-bindings. Thank you, --- Best Regards, Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel