From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jDvra-00015A-Is for mharc-grub-devel@gnu.org; Mon, 16 Mar 2020 15:57:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41660) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDvrX-00011R-17 for grub-devel@gnu.org; Mon, 16 Mar 2020 15:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDvrV-0003n6-82 for grub-devel@gnu.org; Mon, 16 Mar 2020 15:57:22 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:37954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDvrU-0003Lf-UO for grub-devel@gnu.org; Mon, 16 Mar 2020 15:57:21 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02GJd4w2163249; Mon, 16 Mar 2020 19:57:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=GZjztwtAcbsXCaSJSMmKla6qpNboKRHuatFpIG3qLRs=; b=ypfnHkZWb6NduZak+nj7AES2pSyVOOB3xUbHC7bzN9y3yLtduu/uRq3H+coWf1e/Kjqm SDRvlOkbSnK5jP2nZGw14d899REl/ZfbhTQzV7msfcddJV40IAeeEWMoXyHs6XljEDbC GkQw13PIMEMz2ONq19B7gUHtOPyQv4FnCNiektUcS0t7ciFz9iQdccA5IAiwcV3i67Im 5rN2mhhG5uVFaTYdRsv+4JlKNMrCdVjSXDbD3TYmUfZ8w21bGpPt0uSXfrwFvjSUP98L otaCncGsObvSKRQlbMu0edl5VfUOQW/JWi6CCF+6al0znD0hiRMO1FVfJdz1njX4GYAC 5w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2yrq7kryyq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2020 19:57:11 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02GJncQe145155; Mon, 16 Mar 2020 19:57:11 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2ys92ajr64-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2020 19:57:11 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02GJv2Ae015499; Mon, 16 Mar 2020 19:57:02 GMT Received: from char.us.oracle.com (/10.152.32.25) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 16 Mar 2020 12:57:01 -0700 Received: by char.us.oracle.com (Postfix, from userid 1000) id 5017E6A010D; Mon, 16 Mar 2020 15:57:02 -0400 (EDT) Date: Mon, 16 Mar 2020 15:57:02 -0400 From: Konrad Rzeszutek Wilk To: The development of GNU GRUB Cc: Patrick Steinhardt , Leif Lindholm , agraf@csgraf.de, pjones@redhat.com, mjg59@google.com, phcoder@gmail.com, Milan Broz Subject: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup Message-ID: <20200316195702.GB22934@char.us.oracle.com> References: <20200313131349.txdyacrwo4bexe4o@tomti.i.net-space.pl> <20200316172106.qyfnfknrm4uiegtv@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316172106.qyfnfknrm4uiegtv@tomti.i.net-space.pl> User-Agent: Mutt/1.9.1 (2017-09-22) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9562 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 mlxscore=0 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003160083 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9562 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1011 malwarescore=0 mlxscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003160083 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2020 19:57:24 -0000 On Mon, Mar 16, 2020 at 06:21:06PM +0100, Daniel Kiper wrote: > On Fri, Mar 13, 2020 at 02:13:49PM +0100, Daniel Kiper wrote: > > On Tue, Mar 10, 2020 at 07:58:30PM +0100, Patrick Steinhardt wrote: > > > In order to support the Argon2 key derival function for LUKS2, we > > > obviously need to implement Argon2. It doesn't make a lot of sense to > > > hand-code any crypto, which is why this commit instead imports Argon2 > > > from the cryptsetup project. This commit thus imports the code from the > > > official reference implementation located at [1]. The code is licensed > > > under CC0 1.0 Universal/Apache 2.0. Given that both LGPLv2.1+ and Apache > > > 2.0 are compatible with GPLv3, it should be fine to import that code. > > > > > > The code is imported from commit 62358ba (Merge pull request #270 from > > > bitmark-property-system/master, 2019-05-20). To make it work for GRUB, > > > several adjustments were required that have beed documented in > > > "grub-dev.texi". > > > > > > [1]: https://github.com/P-H-C/phc-winner-argon2 > > > > > > Signed-off-by: Patrick Steinhardt > > > > [...] > > > > > diff --git a/grub-core/lib/argon2/argon2.c b/grub-core/lib/argon2/argon2.c > > > new file mode 100644 > > > index 000000000..c77f7f6ff > > > --- /dev/null > > > +++ b/grub-core/lib/argon2/argon2.c > > > @@ -0,0 +1,232 @@ > > > +/* > > > + * Argon2 reference source code package - reference C implementations > > > + * > > > + * Copyright 2015 > > > + * Daniel Dinu, Dmitry Khovratovich, Jean-Philippe Aumasson, and Samuel Neves > > > + * > > > + * You may use this work under the terms of a Creative Commons CC0 1.0 > > > + * License/Waiver or the Apache Public License 2.0, at your option. The terms of > > > + * these licenses can be found at: > > > + * > > > + * - CC0 1.0 Universal : http://creativecommons.org/publicdomain/zero/1.0 > > > + * - Apache 2.0 : http://www.apache.org/licenses/LICENSE-2.0 > > > + * > > > + * You should have received a copy of both of these licenses along with this > > > + * software. If not, they may be obtained at the above URLs. > > > + */ > > > + > > > +#include > > > + > > > +#include "argon2.h" > > > +#include "core.h" > > > + > > > +GRUB_MOD_LICENSE ("GPLv3"); > > > > I think we should change that if the license above is different. > > Anyway, I am trying to get in touch with FSF license team. I have not > > got a reply yet... I will see what is possible in my company... > > Got an unofficial reply that we cannot remove current license from the > Argon2 reference source code package. However, we can add GPLv3 header > after current license header. Hence, I would suggest heading in that > direction. Still waiting for final confirmation. Sadly usual turn around > is about two weeks... Sorry for asking this so late- but has anybody tried contacting the authors (Daniel Dinu, Dmitry Khovratovich, Jean-Philippe Aumasson, and Samuel Neves) and asking if they would be willing to post their code under GPL-v3?