All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	ehabkost@redhat.com, qemu-block@nongnu.org, philmd@redhat.com,
	armbru@redhat.com, Max Reitz <mreitz@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [PATCH v8 02/11] iotests: don't use 'format' for drive_add
Date: Mon, 16 Mar 2020 20:40:56 -0400	[thread overview]
Message-ID: <20200317004105.27059-3-jsnow@redhat.com> (raw)
In-Reply-To: <20200317004105.27059-1-jsnow@redhat.com>

It shadows (with a different type) the built-in format.
Use something else.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/055        | 3 ++-
 tests/qemu-iotests/iotests.py | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055
index 82b9f5f47d..4175fff5e4 100755
--- a/tests/qemu-iotests/055
+++ b/tests/qemu-iotests/055
@@ -469,7 +469,8 @@ class TestDriveCompression(iotests.QMPTestCase):
         qemu_img('create', '-f', fmt, blockdev_target_img,
                  str(TestDriveCompression.image_len), *args)
         if attach_target:
-            self.vm.add_drive(blockdev_target_img, format=fmt, interface="none")
+            self.vm.add_drive(blockdev_target_img,
+                              img_format=fmt, interface="none")
 
         self.vm.launch()
 
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index c6d9ae130d..a6b2889932 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -482,21 +482,21 @@ def add_drive_raw(self, opts):
         self._args.append(opts)
         return self
 
-    def add_drive(self, path, opts='', interface='virtio', format=imgfmt):
+    def add_drive(self, path, opts='', interface='virtio', img_format=imgfmt):
         '''Add a virtio-blk drive to the VM'''
         options = ['if=%s' % interface,
                    'id=drive%d' % self._num_drives]
 
         if path is not None:
             options.append('file=%s' % path)
-            options.append('format=%s' % format)
+            options.append('format=%s' % img_format)
             options.append('cache=%s' % cachemode)
             options.append('aio=%s' % aiomode)
 
         if opts:
             options.append(opts)
 
-        if format == 'luks' and 'key-secret' not in opts:
+        if img_format == 'luks' and 'key-secret' not in opts:
             # default luks support
             if luks_default_secret_object not in self._args:
                 self.add_object(luks_default_secret_object)
-- 
2.21.1



  parent reply	other threads:[~2020-03-17  0:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17  0:40 [PATCH v8 00/11] iotests: use python logging John Snow
2020-03-17  0:40 ` [PATCH v8 01/11] iotests: do a light delinting John Snow
2020-03-24 13:56   ` Max Reitz
2020-03-17  0:40 ` John Snow [this message]
2020-03-17  0:40 ` [PATCH v8 03/11] iotests: ignore import warnings from pylint John Snow
2020-03-17 10:38   ` Philippe Mathieu-Daudé
2020-03-24 14:02   ` Max Reitz
2020-03-17  0:40 ` [PATCH v8 04/11] iotests: replace mutable list default args John Snow
2020-03-24 14:35   ` Max Reitz
2020-03-17  0:40 ` [PATCH v8 05/11] iotests: add pylintrc file John Snow
2020-03-24 14:47   ` Max Reitz
2020-03-17  0:41 ` [PATCH v8 06/11] iotests: drop Python 3.4 compatibility code John Snow
2020-03-24 14:54   ` Max Reitz
2020-03-24 16:57     ` John Snow
2020-03-17  0:41 ` [PATCH v8 07/11] iotests: limit line length to 79 chars John Snow
2020-03-17 10:36   ` Philippe Mathieu-Daudé
2020-03-17 13:48     ` John Snow
2020-03-24 15:02   ` Max Reitz
2020-03-24 15:12     ` Max Reitz
2020-03-24 17:09       ` John Snow
2020-03-24 17:38         ` Max Reitz
2020-03-17  0:41 ` [PATCH v8 08/11] iotests: add script_initialize John Snow
2020-03-17  0:41 ` [PATCH v8 09/11] iotest 258: use script_main John Snow
2020-03-17  0:41 ` [PATCH v8 10/11] iotests: Mark verify functions as private John Snow
2020-03-17  0:41 ` [PATCH v8 11/11] iotests: use python logging for iotests.log() John Snow
2020-03-24 16:14   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317004105.27059-3-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.