From: Kalle Valo <kvalo@codeaurora.org>
To: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Yingying Tang <yintang@codeaurora.org>,
Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
Subject: Re: ath10k: Fill GCMP MIC length for PMF
Date: Tue, 17 Mar 2020 08:21:36 +0000 (UTC) [thread overview]
Message-ID: <20200317082136.BC8F6C433BA@smtp.codeaurora.org> (raw)
In-Reply-To: <1584426499-27819-1-git-send-email-ssreeela@codeaurora.org>
Sowmiya Sree Elavalagan <ssreeela@codeaurora.org> wrote:
> From: Yingying Tang <yintang@codeaurora.org>
>
> GCMP MIC length is not filled for GCMP/GCMP-256 cipher suites in
> PMF enabled case. Due to mismatch in MIC length, deauth/disassoc frames
> are unencrypted.
> This patch fills proper MIC length for GCMP/GCMP-256 cipher suites.
>
> Tested HW: QCA9984, QCA9888
> Tested FW: 10.4-3.6-00104
>
> Signed-off-by: Yingying Tang <yintang@codeaurora.org>
> Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
Failed to build:
drivers/net/wireless/ath/ath10k/mac.c: In function 'ath10k_mac_tx_h_fill_cb':
drivers/net/wireless/ath/ath10k/mac.c:3611:6: error: 'sta' undeclared (first use in this function); did you mean 'stat'?
if (sta) {
^~~
stat
drivers/net/wireless/ath/ath10k/mac.c:3611:6: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/ath/ath10k/mac.c:3612:3: error: 'arsta' undeclared (first use in this function)
arsta = (struct ath10k_sta *)sta->drv_priv;
^~~~~
make[5]: *** [drivers/net/wireless/ath/ath10k/mac.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [drivers/net/wireless/ath/ath10k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11441863/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-03-17 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 6:28 ath10k: Fill GCMP MIC length for PMF Sowmiya Sree Elavalagan
2020-03-17 6:28 ` Sowmiya Sree Elavalagan
2020-03-17 8:21 ` Kalle Valo
2020-03-17 8:21 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317082136.BC8F6C433BA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ssreeela@codeaurora.org \
--cc=yintang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.