From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8CDC5ACD8 for ; Wed, 18 Mar 2020 10:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 030F72076F for ; Wed, 18 Mar 2020 10:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727540AbgCRKSz (ORCPT ); Wed, 18 Mar 2020 06:18:55 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:52375 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgCRKSy (ORCPT ); Wed, 18 Mar 2020 06:18:54 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEVme-0005Tb-LH; Wed, 18 Mar 2020 11:18:44 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jEVme-0000ds-3Q; Wed, 18 Mar 2020 11:18:44 +0100 Date: Wed, 18 Mar 2020 11:18:44 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Tang Bin Cc: linux@rempel-privat.de, s.hauer@pengutronix.de, shawnguo@kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq() Message-ID: <20200318101844.55c273zh242ymxcf@pengutronix.de> References: <20200318100748.17540-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200318100748.17540-1-tangbin@cmss.chinamobile.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2020 at 06:07:48PM +0800, Tang Bin wrote: > We don't need dev_err() message because when something goes wrong, > platform_get_irq() has print an error message itself, so we should > remove duplicate dev_err(). > > Signed-off-by: Tang Bin > --- > drivers/i2c/busses/i2c-imx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index a3b61336f..01fd46682 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1066,10 +1066,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > dev_dbg(&pdev->dev, "<%s>\n", __func__); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "can't get irq number\n"); > + if (irq < 0) > return irq; > - } Maybe add a comment for the next person who wonders about an error path without error message? Something like: irq = platform_get_irq(pdev, 0); if (irq < 0) /* * platform_get_irq() already issued an error message, so * fail silently here. */ return irq; And to get some extra kudos mention the commit that modified platform_get_irq() to emit a message in the commit log. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8EBBC10DCE for ; Wed, 18 Mar 2020 10:18:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B1FE2076D for ; Wed, 18 Mar 2020 10:18:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ikio4LEJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B1FE2076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E77JYWPsCaDxmpdlmoIMF2v3x/GN1qBraAJatH+oW+c=; b=Ikio4LEJm98ef4 C0cAy5DFeposempDVf3tUk+QhFE1hLioBBxpY40h2ArPnICy3cqh2DcljbWNaTegVsp3Z51cj5lux t6OLZEm+hPKEHBUVGowQD1m1m6e9iRBpufz87nkgISGccwRDqCT8A0Qqpa/BHP2lCMQJmLCMQQAx1 DGhaEHXyzwWyExmxBpp0cs6iQ2aWSfIfhYA5jcGX9DP6ZzMLkxyDy9pY2chMudJHoZ+nJ8/Hrjh4O ubLFh0tKN+fR1SwC0xzYsCwE16u+pJhmEULfRC9NzrcuQIakGtt+3Cu0qctXbqnSC5EkEy/bnNUIT t1v1aZM7rE0/x9u57teg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEVmn-0006Ea-TX; Wed, 18 Mar 2020 10:18:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEVmk-0006DS-Ot for linux-arm-kernel@lists.infradead.org; Wed, 18 Mar 2020 10:18:52 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEVme-0005Tb-LH; Wed, 18 Mar 2020 11:18:44 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jEVme-0000ds-3Q; Wed, 18 Mar 2020 11:18:44 +0100 Date: Wed, 18 Mar 2020 11:18:44 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Tang Bin Subject: Re: [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq() Message-ID: <20200318101844.55c273zh242ymxcf@pengutronix.de> References: <20200318100748.17540-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200318100748.17540-1-tangbin@cmss.chinamobile.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200318_031850_813982_88DE36E2 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux@rempel-privat.de, linux-i2c@vger.kernel.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 18, 2020 at 06:07:48PM +0800, Tang Bin wrote: > We don't need dev_err() message because when something goes wrong, > platform_get_irq() has print an error message itself, so we should > remove duplicate dev_err(). > = > Signed-off-by: Tang Bin > --- > drivers/i2c/busses/i2c-imx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > = > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index a3b61336f..01fd46682 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1066,10 +1066,8 @@ static int i2c_imx_probe(struct platform_device *p= dev) > dev_dbg(&pdev->dev, "<%s>\n", __func__); > = > irq =3D platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "can't get irq number\n"); > + if (irq < 0) > return irq; > - } Maybe add a comment for the next person who wonders about an error path without error message? Something like: irq =3D platform_get_irq(pdev, 0); if (irq < 0) /* * platform_get_irq() already issued an error message, so * fail silently here. */ return irq; And to get some extra kudos mention the commit that modified platform_get_irq() to emit a message in the commit log. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel