All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
	qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [PATCH v9 15/15] s390x: Add unpack facility feature to GA1
Date: Wed, 18 Mar 2020 10:27:12 +0100	[thread overview]
Message-ID: <20200318102712.4bd4f254.cohuck@redhat.com> (raw)
In-Reply-To: <64ebd363-da9d-a98a-a50d-aa3994044015@linux.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]

On Wed, 18 Mar 2020 09:44:08 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 3/17/20 7:06 PM, Cornelia Huck wrote:
> > On Wed, 11 Mar 2020 09:21:51 -0400
> > Janosch Frank <frankja@linux.ibm.com> wrote:

> >> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> >> index ff6027036ec2f14a..e11e895a3d9038bb 100644
> >> --- a/target/s390x/kvm.c
> >> +++ b/target/s390x/kvm.c
> >> @@ -2403,6 +2403,11 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *model, Error **errp)
> >>          clear_bit(S390_FEAT_BPB, model->features);
> >>      }
> >>  
> >> +    /* we do have the IPL enhancements */  
> > 
> > I'm more confused by that comment than educated :) Not sure what 'IPL
> > enhancements' means in this context.  
> 
> /* We do have the protected virtualization ipl unpack facility */
> ?

Ah :)

What about

/*
 * If we have support for protected virtualization, indicate
 * the protected virtualization IPL unpack facility.
 */

?

> 
> >   
> >> +    if (cap_protected) {
> >> +        set_bit(S390_FEAT_UNPACK, model->features);
> >> +    }
> >> +
> >>      /* We emulate a zPCI bus and AEN, therefore we don't need HW support */
> >>      set_bit(S390_FEAT_ZPCI, model->features);
> >>      set_bit(S390_FEAT_ADAPTER_EVENT_NOTIFICATION, model->features);  
> >   
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-18  9:28 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 13:21 [PATCH v9 00/15] s390x: Protected Virtualization support Janosch Frank
2020-03-11 13:21 ` [PATCH v9 01/15] Sync pv Janosch Frank
2020-03-11 13:21 ` [PATCH v9 02/15] s390x: protvirt: Support unpack facility Janosch Frank
2020-03-12  8:33   ` Christian Borntraeger
2020-03-13  9:35     ` Janosch Frank
2020-03-13  9:52     ` [PATCH v9] fixup! Fix subcode/pbt Janosch Frank
2020-03-13 14:30       ` Christian Borntraeger
2020-03-13 14:44         ` Janosch Frank
2020-03-16 14:27       ` Cornelia Huck
2020-03-16 14:47         ` Janosch Frank
2020-03-16 14:54           ` Cornelia Huck
2020-03-16 15:04             ` Christian Borntraeger
2020-03-16 17:57               ` Cornelia Huck
2020-03-16 19:42                 ` Christian Borntraeger
2020-03-17  9:53                   ` Cornelia Huck
2020-03-16 15:05             ` Janosch Frank
2020-03-16 17:58               ` Cornelia Huck
     [not found]   ` <a0edb6d5-284f-5f10-02e5-d2f252043d71@redhat.com>
2020-03-12  8:54     ` [PATCH v9 02/15] s390x: protvirt: Support unpack facility Janosch Frank
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 03/15] s390x: protvirt: Add migration blocker Janosch Frank
2020-03-12  8:42   ` Christian Borntraeger
2020-03-12  9:34     ` Janosch Frank
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-16 14:49   ` Cornelia Huck
2020-03-11 13:21 ` [PATCH v9 04/15] s390x: protvirt: Inhibit balloon when switching to protected mode Janosch Frank
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-18 11:42   ` Cornelia Huck
2020-03-18 12:30     ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 05/15] s390x: protvirt: KVM intercept changes Janosch Frank
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-17  9:56   ` Cornelia Huck
2020-03-11 13:21 ` [PATCH v9 06/15] s390x: Add SIDA memory ops Janosch Frank
2020-03-12  8:50   ` Christian Borntraeger
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-17 10:24   ` Cornelia Huck
2020-03-17 11:56     ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD Janosch Frank
2020-03-12 10:42   ` Christian Borntraeger
2020-03-12 11:20     ` Janosch Frank
2020-03-17 10:28       ` Cornelia Huck
2020-03-17 10:32         ` Janosch Frank
2020-03-17 10:41           ` Cornelia Huck
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 08/15] s390x: protvirt: SCLP interpretation Janosch Frank
2020-03-11 13:24   ` David Hildenbrand
2020-03-11 13:31     ` Janosch Frank
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-13 13:14   ` Christian Borntraeger
2020-03-17 11:05     ` Cornelia Huck
2020-03-17 11:54       ` Janosch Frank
2020-03-17 12:01         ` Cornelia Huck
2020-03-11 13:21 ` [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW Janosch Frank
2020-03-12 15:08   ` Christian Borntraeger
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-13 14:21     ` Janosch Frank
2020-03-13 14:22       ` Christian Borntraeger
2020-03-13 14:29       ` Claudio Imbrenda
2020-03-13 14:32       ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 10/15] s390x: protvirt: Move diag 308 data over SIDA Janosch Frank
2020-03-12 15:17   ` Christian Borntraeger
2020-03-12 16:05     ` Janosch Frank
2020-03-12 16:09       ` Christian Borntraeger
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 11/15] s390x: protvirt: Disable address checks for PV guest IO emulation Janosch Frank
2020-03-12 15:41   ` Christian Borntraeger
2020-03-12 16:07     ` Janosch Frank
2020-03-12 16:10       ` Christian Borntraeger
2020-03-12 16:17         ` Janosch Frank
2020-03-13  7:38           ` Christian Borntraeger
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-17 11:36   ` Cornelia Huck
2020-03-17 12:00     ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 12/15] s390x: protvirt: Move IO control structures over SIDA Janosch Frank
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-13 13:15     ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 13/15] s390x: protvirt: Handle SIGP store status correctly Janosch Frank
2020-03-12 15:51   ` Christian Borntraeger
2020-03-12 16:13     ` Janosch Frank
2020-03-13  7:39       ` Christian Borntraeger
2020-03-13  7:39       ` Christian Borntraeger
2020-03-17 16:48       ` Cornelia Huck
2020-03-13 12:57   ` Claudio Imbrenda
2020-03-11 13:21 ` [PATCH v9 14/15] docs: Add protvirt docs Janosch Frank
     [not found]   ` <569575c9-5819-f890-e218-99f3a23bee99@redhat.com>
2020-03-12 12:10     ` Janosch Frank
2020-03-13 13:00   ` Claudio Imbrenda
2020-03-13 13:18     ` Janosch Frank
2020-03-13 13:28   ` Peter Maydell
2020-03-17 18:23     ` Cornelia Huck
2020-03-18  8:41       ` Janosch Frank
2020-03-18 11:25   ` Cornelia Huck
2020-03-18 12:34     ` Janosch Frank
2020-03-11 13:21 ` [PATCH v9 15/15] s390x: Add unpack facility feature to GA1 Janosch Frank
2020-03-13 13:01   ` Claudio Imbrenda
2020-03-17 18:06   ` Cornelia Huck
2020-03-18  8:44     ` Janosch Frank
2020-03-18  9:27       ` Cornelia Huck [this message]
2020-03-18  9:42         ` Janosch Frank
2020-03-11 14:15 ` [PATCH v9 00/15] s390x: Protected Virtualization support no-reply
2020-03-11 14:36 ` no-reply
2020-03-12 16:25 ` [PATCH v9] s390x: protvirt: Fence huge pages Janosch Frank
2020-03-13  8:21   ` Christian Borntraeger
2020-03-16 10:06     ` Janosch Frank
2020-03-16 16:33       ` Christian Borntraeger
2020-03-17 16:57   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318102712.4bd4f254.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.