From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jEXFw-000820-La for mharc-grub-devel@gnu.org; Wed, 18 Mar 2020 07:53:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEXFt-0007zb-Uz for grub-devel@gnu.org; Wed, 18 Mar 2020 07:53:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEXFs-0003kp-FW for grub-devel@gnu.org; Wed, 18 Mar 2020 07:53:01 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:59715) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEXFr-0003V3-Vs for grub-devel@gnu.org; Wed, 18 Mar 2020 07:53:00 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 9E5C1481; Wed, 18 Mar 2020 07:52:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 18 Mar 2020 07:52:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=oOUS7x+LcbjiR8Ulb0qZTJgT+rR /ybJqsQe0NlBvmi0=; b=A1NrxAtxAz2zifLqyuPQCPo6W2u6YVy9MBcUVhZMJG1 SEgpofJRf8imnAtwsc3o+vF/jGlv7U72nYR0sVfTbbzJ5fOEKJZvMXJZ7rVqpwqh rSlILfMgjMZq4aNb4kA60gglkRS5R47YyqMVwt5GhEgKzhlVd7U7nU0GxgixFStb 8MbF/sOA3+VpeI+GdCs0bBDxZDlGpYpAllz4rPL+2wKVofZDF6tSdaW2hiFJQSJn lYxN1w+sKNqLLJzCliW3ItEPwJTjkR787IO4ktzpYhMe4wB+QdzVUYQZ1bCJY2rE 2PbU17RtgRBsXK9UtLo5bEWn/GOuo8ZgfKBUcDGHNxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oOUS7x +LcbjiR8Ulb0qZTJgT+rR/ybJqsQe0NlBvmi0=; b=uC4VGd8FHmf8MfzU75+w2T AF9O1nL7z2+FEJwIEObUrI0404R+yJWUOv+z4teSFcUthOMcCEPySsvox3ivQhcC 7nXA//meQZR3f4ZBcKaXgvbIC4lemJaie+0cTr24ttFEftljeF1CoNJTWi4TAFAC wKv0GCPa+vfxUL+r6ZGg9MfdjthkVRw8jpQrF4jj32aAGqejOIu8xeE4Xd5vPKVV mjSL7utXQSVSF3A40SPktg0ee6CCMcOu1SQ3g1AJniZsuqe+9EB4JmT+OLmW911t oKSfMqAvfqNFWMsPWnam4laCmJFAIX84jYbe4HuU1QtbCK8rcIYFZZbUrcdR1IJQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefjedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucffohhmrghinhepgh hithhhuhgsrdgtohhmpdgtrhgvrghtihhvvggtohhmmhhonhhsrdhorhhgpdgrphgrtghh vgdrohhrghenucfkphepjeekrdehhedrudeikedrfeelnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail (x4e37a827.dyn.telefonica.de [78.55.168.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 91100328005E; Wed, 18 Mar 2020 07:52:54 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail (OpenSMTPD) with ESMTPSA id beb3ec5e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 18 Mar 2020 11:52:49 +0000 (UTC) Date: Wed, 18 Mar 2020 12:52:56 +0100 From: Patrick Steinhardt To: Konrad Rzeszutek Wilk Cc: The development of GNU GRUB , Leif Lindholm , agraf@csgraf.de, pjones@redhat.com, mjg59@google.com, phcoder@gmail.com, Milan Broz Subject: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup Message-ID: <20200318115256.GA5054@ncase> References: <20200313131349.txdyacrwo4bexe4o@tomti.i.net-space.pl> <20200316172106.qyfnfknrm4uiegtv@tomti.i.net-space.pl> <20200316195702.GB22934@char.us.oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: <20200316195702.GB22934@char.us.oracle.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.21 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 11:53:03 -0000 --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 16, 2020 at 03:57:02PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 16, 2020 at 06:21:06PM +0100, Daniel Kiper wrote: > > On Fri, Mar 13, 2020 at 02:13:49PM +0100, Daniel Kiper wrote: > > > On Tue, Mar 10, 2020 at 07:58:30PM +0100, Patrick Steinhardt wrote: > > > > In order to support the Argon2 key derival function for LUKS2, we > > > > obviously need to implement Argon2. It doesn't make a lot of sense = to > > > > hand-code any crypto, which is why this commit instead imports Argo= n2 > > > > from the cryptsetup project. This commit thus imports the code from= the > > > > official reference implementation located at [1]. The code is licen= sed > > > > under CC0 1.0 Universal/Apache 2.0. Given that both LGPLv2.1+ and A= pache > > > > 2.0 are compatible with GPLv3, it should be fine to import that cod= e. > > > > > > > > The code is imported from commit 62358ba (Merge pull request #270 f= rom > > > > bitmark-property-system/master, 2019-05-20). To make it work for GR= UB, > > > > several adjustments were required that have beed documented in > > > > "grub-dev.texi". > > > > > > > > [1]: https://github.com/P-H-C/phc-winner-argon2 > > > > > > > > Signed-off-by: Patrick Steinhardt > > > > > > [...] > > > > > > > diff --git a/grub-core/lib/argon2/argon2.c b/grub-core/lib/argon2/a= rgon2.c > > > > new file mode 100644 > > > > index 000000000..c77f7f6ff > > > > --- /dev/null > > > > +++ b/grub-core/lib/argon2/argon2.c > > > > @@ -0,0 +1,232 @@ > > > > +/* > > > > + * Argon2 reference source code package - reference C implementati= ons > > > > + * > > > > + * Copyright 2015 > > > > + * Daniel Dinu, Dmitry Khovratovich, Jean-Philippe Aumasson, and S= amuel Neves > > > > + * > > > > + * You may use this work under the terms of a Creative Commons CC0= 1.0 > > > > + * License/Waiver or the Apache Public License 2.0, at your option= =2E The terms of > > > > + * these licenses can be found at: > > > > + * > > > > + * - CC0 1.0 Universal : http://creativecommons.org/publicdomain/z= ero/1.0 > > > > + * - Apache 2.0 : http://www.apache.org/licenses/LICENSE-2.0 > > > > + * > > > > + * You should have received a copy of both of these licenses along= with this > > > > + * software. If not, they may be obtained at the above URLs. > > > > + */ > > > > + > > > > +#include > > > > + > > > > +#include "argon2.h" > > > > +#include "core.h" > > > > + > > > > +GRUB_MOD_LICENSE ("GPLv3"); > > > > > > I think we should change that if the license above is different. > > > Anyway, I am trying to get in touch with FSF license team. I have not > > > got a reply yet... I will see what is possible in my company... > >=20 > > Got an unofficial reply that we cannot remove current license from the > > Argon2 reference source code package. However, we can add GPLv3 header > > after current license header. Hence, I would suggest heading in that > > direction. Still waiting for final confirmation. Sadly usual turn around > > is about two weeks... >=20 > Sorry for asking this so late- but has anybody tried contacting the autho= rs > (Daniel Dinu, Dmitry Khovratovich, Jean-Philippe Aumasson, and Samuel Nev= es) and > asking if they would be willing to post their code under GPL-v3? Honestly I didn't even consider this, but you've certainly got a point. I will try and reach out to them later this week. Patrick --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl5yC5UACgkQVbJhu7ck PpSmuA//Y+Zdqv6fyl6ifvGroHdhVnMxoHdX2wIbJswEC0ru5UT/V6tGRUP0AuQ3 BUk+6Db6dELAVVatxOovcOOC6zeaQHkDcpCzumsGwYMu8fcnnzJ5D2DzvzROYA4Q ATgIHPdV2KrtrO0adNoKl0UH8lmcvRylaQ5xtYAKwYOC3ALlkzaTIfXW2toLz9EH /jm1swkZf4P6v4D8eGO+KTJRahMR2ijIqiVlw56v46JfAF4W31rPZmDSQtBQOgBO 6KVrqRcGMu28bCfoaf6BT38YZeA2LvBbMSlCYkTTvKQ5GnjYXZkn+JJ4wXZGGMbf xnjjY+Lnhd5FgrprJdNd+XYZBSmn22TN3hn3SqNAUry8ZFtSzBNxNJfvuSGku5tC eIWdz76M7/H4A+VHUcPrbgAAJBo8i0mseo/1LtdNkJCeVfgeJ/mWsm5QMroU9GeG DpIlQMS/kUlvoI/Hp4MbiYWIHtUvEf7EjF7fbOUMNtNH/WDJOTVKHuUXulDzncYx agjVFgMhzRc2mWQgL8UedCVKks7LJvxr2cXaE+mt2i3sywKZN3Jg9ueqIGzatCmf nrW34BhTFSxZlUTL/6yYaxvG20sCidykLUWEEtHq1KUgslbJQKdU6xIqMNYQBCUt RFeev6DR3u3JxBfyvvFenLoFZGaIt/bW4e+aZv7yGKXRbatq3Wo= =pqJj -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--