All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>, Will Deacon <will@kernel.org>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Logan Gunthorpe <logang@deltatee.com>,
	Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	Oleg Nesterov <oleg@redhat.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Arnd Bergmann <arnd@arndb.de>,
	linuxppc-dev@lists.ozlabs.org
Subject: [patch V2 15/15] lockdep: Add posixtimer context tracing bits
Date: Wed, 18 Mar 2020 21:43:17 +0100	[thread overview]
Message-ID: <20200318204408.946175347@linutronix.de> (raw)
In-Reply-To: 20200318204302.693307984@linutronix.de

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Splitting run_posix_cpu_timers() into two parts is work in progress which
is stuck on other entry code related problems. The heavy lifting which
involves locking of sighand lock will be moved into task context so the
necessary execution time is burdened on the task and not on interrupt
context.

Until this work completes lockdep with the spinlock nesting rules enabled
would emit warnings for this known context.

Prevent it by setting "->irq_config = 1" for the invocation of
run_posix_cpu_timers() so lockdep does not complain when sighand lock is
acquried. This will be removed once the split is completed.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 include/linux/irqflags.h       | 12 ++++++++++++
 kernel/time/posix-cpu-timers.c |  6 +++++-
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
index f23f540e0ebba..a16adbb58f66a 100644
--- a/include/linux/irqflags.h
+++ b/include/linux/irqflags.h
@@ -69,6 +69,16 @@ do {						\
 			current->irq_config = 0;	\
 	  } while (0)
 
+# define lockdep_posixtimer_enter()				\
+	  do {							\
+		  current->irq_config = 1;			\
+	  } while (0)
+
+# define lockdep_posixtimer_exit()				\
+	  do {							\
+		  current->irq_config = 0;			\
+	  } while (0)
+
 # define lockdep_irq_work_enter(__work)					\
 	  do {								\
 		  if (!(atomic_read(&__work->flags) & IRQ_WORK_HARD_IRQ))\
@@ -94,6 +104,8 @@ do {						\
 # define lockdep_softirq_exit()		do { } while (0)
 # define lockdep_hrtimer_enter(__hrtimer)		do { } while (0)
 # define lockdep_hrtimer_exit(__hrtimer)		do { } while (0)
+# define lockdep_posixtimer_enter()		do { } while (0)
+# define lockdep_posixtimer_exit()		do { } while (0)
 # define lockdep_irq_work_enter(__work)		do { } while (0)
 # define lockdep_irq_work_exit(__work)		do { } while (0)
 #endif
diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
index 8ff6da77a01fd..2c48a7233b196 100644
--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -1126,8 +1126,11 @@ void run_posix_cpu_timers(void)
 	if (!fastpath_timer_check(tsk))
 		return;
 
-	if (!lock_task_sighand(tsk, &flags))
+	lockdep_posixtimer_enter();
+	if (!lock_task_sighand(tsk, &flags)) {
+		lockdep_posixtimer_exit();
 		return;
+	}
 	/*
 	 * Here we take off tsk->signal->cpu_timers[N] and
 	 * tsk->cpu_timers[N] all the timers that are firing, and
@@ -1169,6 +1172,7 @@ void run_posix_cpu_timers(void)
 			cpu_timer_fire(timer);
 		spin_unlock(&timer->it_lock);
 	}
+	lockdep_posixtimer_exit();
 }
 
 /*
-- 
2.25.1



  parent reply	other threads:[~2020-03-18 20:58 UTC|newest]

Thread overview: 148+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 20:43 [patch V2 00/15] Lock ordering documentation and annotation for lockdep Thomas Gleixner
2020-03-18 20:43 ` Thomas Gleixner
2020-03-18 20:43 ` [patch V2 01/15] PCI/switchtec: Fix init_completion race condition with poll_wait() Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-18 21:25   ` Bjorn Helgaas
2020-03-18 21:25     ` Bjorn Helgaas
2020-03-18 20:43 ` [patch V2 02/15] pci/switchtec: Replace completion wait queue usage for poll Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-18 21:26   ` Bjorn Helgaas
2020-03-18 21:26     ` Bjorn Helgaas
2020-03-18 22:11   ` Logan Gunthorpe
2020-03-18 22:11     ` Logan Gunthorpe
2020-03-18 20:43 ` [patch V2 03/15] usb: gadget: Use completion interface instead of open coding it Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-19  8:41   ` Greg Kroah-Hartman
2020-03-19  8:41     ` Greg Kroah-Hartman
2020-03-18 20:43 ` [patch V2 04/15] orinoco_usb: Use the regular completion interfaces Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-19  8:40   ` Greg Kroah-Hartman
2020-03-19  8:40     ` Greg Kroah-Hartman
2020-03-18 20:43 ` [patch V2 05/15] acpi: Remove header dependency Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-18 20:43 ` [patch V2 06/15] rcuwait: Add @state argument to rcuwait_wait_event() Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-20  5:36   ` Davidlohr Bueso
2020-03-20  5:36     ` Davidlohr Bueso
2020-03-20  8:45     ` Sebastian Andrzej Siewior
2020-03-20  8:45       ` Sebastian Andrzej Siewior
2020-03-20  8:58       ` Davidlohr Bueso
2020-03-20  8:58         ` Davidlohr Bueso
2020-03-20  9:48   ` [PATCH 0/5] Remove mm.h from arch/*/include/asm/uaccess.h Sebastian Andrzej Siewior
2020-03-20  9:48     ` Sebastian Andrzej Siewior
2020-03-20  9:48     ` [PATCH 1/5] nds32: Remove mm.h from asm/uaccess.h Sebastian Andrzej Siewior
2020-03-20  9:48       ` Sebastian Andrzej Siewior
2020-03-20  9:48     ` [PATCH 2/5] csky: " Sebastian Andrzej Siewior
2020-03-20  9:48       ` Sebastian Andrzej Siewior
2020-03-21 11:24       ` Guo Ren
2020-03-21 11:24         ` Guo Ren
2020-03-21 12:08         ` Thomas Gleixner
2020-03-21 12:08           ` Thomas Gleixner
2020-03-21 14:11           ` Guo Ren
2020-03-21 14:11             ` Guo Ren
2020-03-20  9:48     ` [PATCH 3/5] hexagon: " Sebastian Andrzej Siewior
2020-03-20  9:48       ` Sebastian Andrzej Siewior
2020-03-20  9:48     ` [PATCH 4/5] ia64: " Sebastian Andrzej Siewior
2020-03-20  9:48       ` Sebastian Andrzej Siewior
2020-03-20  9:48       ` Sebastian Andrzej Siewior
2020-03-20  9:48     ` [PATCH 5/5] microblaze: " Sebastian Andrzej Siewior
2020-03-20  9:48       ` Sebastian Andrzej Siewior
2020-03-18 20:43 ` [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-19  9:00   ` Sebastian Andrzej Siewior
2020-03-19  9:00     ` Sebastian Andrzej Siewior
2020-03-19  9:18     ` Peter Zijlstra
2020-03-19  9:18       ` Peter Zijlstra
2020-03-19  9:21   ` Davidlohr Bueso
2020-03-19  9:21     ` Davidlohr Bueso
2020-03-19 10:04   ` Christoph Hellwig
2020-03-19 10:04     ` Christoph Hellwig
2020-03-19 10:26     ` Sebastian Andrzej Siewior
2020-03-19 10:26       ` Sebastian Andrzej Siewior
2020-03-20  0:01       ` Geoff Levand
2020-03-20  0:01         ` Geoff Levand
2020-03-20  0:45       ` Michael Ellerman
2020-03-20  0:45         ` Michael Ellerman
2020-03-21 10:41     ` Thomas Gleixner
2020-03-21 10:41       ` Thomas Gleixner
2020-03-18 20:43 ` [patch V2 08/15] Documentation: Add lock ordering and nesting documentation Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-18 22:31   ` Paul E. McKenney
2020-03-18 22:31     ` Paul E. McKenney
2020-03-19 18:02     ` Thomas Gleixner
2020-03-19 18:02       ` Thomas Gleixner
2020-03-20 16:01       ` Paul E. McKenney
2020-03-20 16:01         ` Paul E. McKenney
2020-03-20 19:51         ` Thomas Gleixner
2020-03-20 19:51           ` Thomas Gleixner
2020-03-20 21:02           ` Paul E. McKenney
2020-03-20 21:02             ` Paul E. McKenney
2020-03-20 22:36             ` Thomas Gleixner
2020-03-20 22:36               ` Thomas Gleixner
2020-03-21  2:29               ` Paul E. McKenney
2020-03-21  2:29                 ` Paul E. McKenney
2020-03-21 10:26                 ` Thomas Gleixner
2020-03-21 10:26                   ` Thomas Gleixner
2020-03-21 17:23                   ` Paul E. McKenney
2020-03-21 17:23                     ` Paul E. McKenney
2020-03-19  8:51   ` Davidlohr Bueso
2020-03-19  8:51     ` Davidlohr Bueso
2020-03-19 15:04   ` Jonathan Corbet
2020-03-19 15:04     ` Jonathan Corbet
2020-03-19 18:04     ` Thomas Gleixner
2020-03-19 18:04       ` Thomas Gleixner
2020-03-21 21:21   ` Joel Fernandes
2020-03-21 21:21     ` Joel Fernandes
2020-03-21 21:49     ` Thomas Gleixner
2020-03-21 21:49       ` Thomas Gleixner
2020-03-22  1:36       ` Joel Fernandes
2020-03-22  1:36         ` Joel Fernandes
2020-03-18 20:43 ` [patch V2 09/15] timekeeping: Split jiffies seqlock Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-18 20:43 ` [patch V2 10/15] sched/swait: Prepare usage in completions Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-18 20:43 ` [patch V2 11/15] completion: Use simple wait queues Thomas Gleixner
2020-03-18 20:43   ` Thomas Gleixner
2020-03-18 22:28   ` Logan Gunthorpe
2020-03-18 22:28     ` Logan Gunthorpe
2020-03-19  0:33   ` Joel Fernandes
2020-03-19  0:33     ` Joel Fernandes
2020-03-19  0:44     ` Thomas Gleixner
2020-03-19  0:44       ` Thomas Gleixner
2020-03-19  8:42   ` Greg Kroah-Hartman
2020-03-19  8:42     ` Greg Kroah-Hartman
2020-03-19 17:12   ` Linus Torvalds
2020-03-19 17:12     ` Linus Torvalds
2020-03-19 23:25   ` Julian Calaby
2020-03-19 23:25     ` Julian Calaby
2020-03-20  6:59     ` Christoph Hellwig
2020-03-20  6:59       ` Christoph Hellwig
2020-03-20  9:01   ` Davidlohr Bueso
2020-03-20  9:01     ` Davidlohr Bueso
2020-03-18 20:43 ` [patch V2 13/15] lockdep: Add hrtimer context tracing bits Thomas Gleixner
2020-03-18 20:43 ` [patch V2 14/15] lockdep: Annotate irq_work Thomas Gleixner
2020-03-18 20:43 ` Thomas Gleixner [this message]
2020-03-20  8:50 ` [patch V2 00/15] Lock ordering documentation and annotation for lockdep Davidlohr Bueso
2020-03-20  8:50   ` Davidlohr Bueso
2020-03-20  8:55 ` [PATCH 16/15] rcuwait: Get rid of stale name comment Davidlohr Bueso
2020-03-20  8:55   ` Davidlohr Bueso
2020-03-20  8:55   ` [PATCH 17/15] rcuwait: Inform rcuwait_wake_up() users if a wakeup was attempted Davidlohr Bueso
2020-03-20  8:55     ` Davidlohr Bueso
2020-03-20  9:13     ` Sebastian Andrzej Siewior
2020-03-20  9:13       ` Sebastian Andrzej Siewior
2020-03-20 10:44     ` Peter Zijlstra
2020-03-20 10:44       ` Peter Zijlstra
2020-03-20  8:55   ` [PATCH 18/15] kvm: Replace vcpu->swait with rcuwait Davidlohr Bueso
2020-03-20  8:55     ` Davidlohr Bueso
2020-03-20 11:20     ` Paolo Bonzini
2020-03-20 11:20       ` Paolo Bonzini
2020-03-20 12:54     ` Peter Zijlstra
2020-03-20 12:54       ` Peter Zijlstra
2020-03-22 16:33       ` Davidlohr Bueso
2020-03-22 16:33         ` Davidlohr Bueso
2020-03-22 22:32         ` Peter Zijlstra
2020-03-22 22:32           ` Peter Zijlstra
2020-03-20  8:55   ` [PATCH 19/15] sched/swait: Reword some of the main description Davidlohr Bueso
2020-03-20  8:55     ` Davidlohr Bueso
2020-03-20  9:19     ` Sebastian Andrzej Siewior
2020-03-20  9:19       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318204408.946175347@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bigeasy@linutronix.de \
    --cc=dave@stgolabs.net \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=kurt.schwemmer@microsemi.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=logang@deltatee.com \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.