From: Andre Guedes <andre.guedes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 00/12] igc: Refactor MAC address filtering code
Date: Wed, 18 Mar 2020 16:00:50 -0700 [thread overview]
Message-ID: <20200318230102.36952-1-andre.guedes@intel.com> (raw)
Hi all,
The MAC address filtering support from IGC driver has some duplicate code and
convoluted logic, making it harder to read, debug, and maintain.
As a follow-up to the bug fixes already applied to dev-queue, this patchset
refactors the MAC address filtering code to address those issues. It also takes
the opportunity to improve documentation from some key functions and clean up
comments that are not applicable to IGC, and fix minor issues along the way.
In summary, the new MAC address filtering code is organized as follows:
* Filters are added and deleted only via igc_add_mac_filter() and
igc_del_mac_filter() APIs. These APIs manage the adapter->mac_table.
They are defined in igc_main.c and used in both igc_main.c and
igc_ethtool.c.
* Filter configuration in hardware is handled by igc_set_mac_filter_
hw() and igc_clear_mac_filter_hw() local helpers in igc_main.c.
* IGC_MAC_STATE_QUEUE_STEERING flag as well as igc_*_mac_steering_
filter() are gone.
Best regards,
Andre
Andre Guedes (12):
igc: Remove duplicate code in MAC filtering logic
igc: Check unsupported flag in igc_add_mac_filter()
igc: Change igc_add_mac_filter() returning value
igc: Fix igc_uc_unsync()
igc: Refactor igc_rar_set_index()
igc: Improve address check in igc_del_mac_filter()
igc: Remove 'queue' check in igc_del_mac_filter()
igc: Remove IGC_MAC_STATE_QUEUE_STEERING
igc: Remove igc_*_mac_steering_filter() wrappers
igc: Refactor igc_mac_entry_can_be_used()
igc: Refactor igc_del_mac_filter()
igc: Add debug messages to MAC filter code
drivers/net/ethernet/intel/igc/igc.h | 11 +-
drivers/net/ethernet/intel/igc/igc_ethtool.c | 22 +-
drivers/net/ethernet/intel/igc/igc_main.c | 372 ++++++++-----------
3 files changed, 169 insertions(+), 236 deletions(-)
--
2.25.0
next reply other threads:[~2020-03-18 23:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 23:00 Andre Guedes [this message]
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 01/12] igc: Remove duplicate code in MAC filtering logic Andre Guedes
2020-03-31 19:58 ` Brown, Aaron F
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 02/12] igc: Check unsupported flag in igc_add_mac_filter() Andre Guedes
2020-03-31 19:58 ` Brown, Aaron F
2020-03-31 20:59 ` Brown, Aaron F
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 03/12] igc: Change igc_add_mac_filter() returning value Andre Guedes
2020-03-31 19:59 ` Brown, Aaron F
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 04/12] igc: Fix igc_uc_unsync() Andre Guedes
2020-03-31 19:59 ` Brown, Aaron F
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 05/12] igc: Refactor igc_rar_set_index() Andre Guedes
2020-03-31 11:22 ` Neftin, Sasha
2020-03-31 21:12 ` Andre Guedes
2020-04-01 21:51 ` Andre Guedes
2020-03-31 20:00 ` Brown, Aaron F
2020-04-01 21:36 ` [Intel-wired-lan] [PATCH v2 " Andre Guedes
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 06/12] igc: Improve address check in igc_del_mac_filter() Andre Guedes
2020-03-31 20:01 ` Brown, Aaron F
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 07/12] igc: Remove 'queue' " Andre Guedes
2020-03-31 15:53 ` Neftin, Sasha
2020-03-31 20:48 ` Brown, Aaron F
2020-03-31 20:50 ` Kirsher, Jeffrey T
2020-04-01 21:41 ` [Intel-wired-lan] [PATCH v2 " Andre Guedes
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 08/12] igc: Remove IGC_MAC_STATE_QUEUE_STEERING Andre Guedes
2020-03-31 20:55 ` Brown, Aaron F
2020-04-01 5:44 ` Neftin, Sasha
2020-04-01 21:43 ` [Intel-wired-lan] [PATCH v2 " Andre Guedes
2020-03-18 23:00 ` [Intel-wired-lan] [PATCH 09/12] igc: Remove igc_*_mac_steering_filter() wrappers Andre Guedes
2020-03-31 20:56 ` Brown, Aaron F
2020-03-18 23:01 ` [Intel-wired-lan] [PATCH 10/12] igc: Refactor igc_mac_entry_can_be_used() Andre Guedes
2020-03-31 20:56 ` Brown, Aaron F
2020-03-18 23:01 ` [Intel-wired-lan] [PATCH 11/12] igc: Refactor igc_del_mac_filter() Andre Guedes
2020-03-31 20:57 ` Brown, Aaron F
2020-03-18 23:01 ` [Intel-wired-lan] [PATCH 12/12] igc: Add debug messages to MAC filter code Andre Guedes
2020-03-31 20:57 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318230102.36952-1-andre.guedes@intel.com \
--to=andre.guedes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.