From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25156C4332E for ; Thu, 19 Mar 2020 03:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0778F20724 for ; Thu, 19 Mar 2020 03:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbgCSDai (ORCPT ); Wed, 18 Mar 2020 23:30:38 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:54022 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726596AbgCSDah (ORCPT ); Wed, 18 Mar 2020 23:30:37 -0400 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 02J3UNjL022389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Mar 2020 23:30:23 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 2DE8E420EBA; Wed, 18 Mar 2020 23:30:23 -0400 (EDT) Date: Wed, 18 Mar 2020 23:30:23 -0400 From: "Theodore Y. Ts'o" To: Stephen Rothwell Cc: Mark Rutland , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build warning after merge of the random tree Message-ID: <20200319033023.GB1067245@mit.edu> References: <20200302144452.6a7c4907@canb.auug.org.au> <20200306155348.7bdc9622@canb.auug.org.au> <20200310121747.GA49602@lakrids.cambridge.arm.com> <20200310144618.GC58231@mit.edu> <20200316165923.043f4454@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316165923.043f4454@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 04:59:23PM +1100, Stephen Rothwell wrote: > > Yes, that looks fine. Reordering the functions to move them under the > > #ifdefs will make the code less readable, and adding extra > > #ifdef/#endif would also make things less readable. > > > > Thanks for the patch, will apply. > > How are we going with this? I've applied and pushed out Mark's patch. - Ted