From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5535CC4332B for ; Thu, 19 Mar 2020 10:05:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D4722071C for ; Thu, 19 Mar 2020 10:05:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cA/7RqtL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727128AbgCSKFF (ORCPT ); Thu, 19 Mar 2020 06:05:05 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49344 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgCSKFE (ORCPT ); Thu, 19 Mar 2020 06:05:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RLVEuHmxmZu2Kjv19dCQm8XyJEDFSZ0VVAjIyaTJTz4=; b=cA/7RqtLr/Y+EQOGncl86ATPPw cweMgFaBjTszA8DTL4VjR0rgeOfXlGi0qJnS7dLZxnnFOHXFmGApyQedYDJCpFL05dhOuRf9c2VLk DTHRzu55zE7JmJ1wGp00p9ECLFsYQewcR9e101lLVz2OgDrrusFhGzhi02k7CifCPaHHkXQIsFF88 gFnLBNJ4QSavWSf8Vas3WjQ9VgCyht70rLCAWxZlBoll936eCyRowqIX87sCIe0amQ0xyAmAIlBdz WpwQWFFofp4O3pdqfSndw8O5aM9mJkvdU5aZIpAe87UH3oRDCICxapeQfvqC2A38rFMAM9feWpFM6 8fQpZhZQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEs2t-0005hq-Qq; Thu, 19 Mar 2020 10:04:59 +0000 Date: Thu, 19 Mar 2020 03:04:59 -0700 From: Christoph Hellwig To: Thomas Gleixner Cc: LKML , Randy Dunlap , Peter Zijlstra , linux-pci@vger.kernel.org, Sebastian Andrzej Siewior , netdev@vger.kernel.org, Joel Fernandes , Will Deacon , Ingo Molnar , Davidlohr Bueso , "Paul E . McKenney" , Logan Gunthorpe , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org, Steven Rostedt , Bjorn Helgaas , Kurt Schwemmer , Kalle Valo , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, Oleg Nesterov , Linus Torvalds , "David S. Miller" Subject: Re: [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait Message-ID: <20200319100459.GA18506@infradead.org> References: <20200318204302.693307984@linutronix.de> <20200318204408.102694393@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318204408.102694393@linutronix.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Mar 18, 2020 at 09:43:09PM +0100, Thomas Gleixner wrote: > The PS3 notification interrupt and kthread use a hacked up completion to > communicate. Since we're wanting to change the completion implementation and > this is abuse anyway, replace it with a simple rcuwait since there is only ever > the one waiter. > > AFAICT the kthread uses TASK_INTERRUPTIBLE to not increase loadavg, kthreads > cannot receive signals by default and this one doesn't look different. Use > TASK_IDLE instead. I think the right fix here is to jut convert the thing to a threaded interrupt handler and kill off the stupid kthread. But I wonder how alive the whole PS3 support is to start with.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1B6C4332B for ; Thu, 19 Mar 2020 10:07:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A730A20753 for ; Thu, 19 Mar 2020 10:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cA/7RqtL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A730A20753 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48jjHw0KCzzDrCQ for ; Thu, 19 Mar 2020 21:07:08 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=batv+061b0704d8249feb4593+6052+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=cA/7RqtL; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48jjFf3NqZzDr5d for ; Thu, 19 Mar 2020 21:05:09 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RLVEuHmxmZu2Kjv19dCQm8XyJEDFSZ0VVAjIyaTJTz4=; b=cA/7RqtLr/Y+EQOGncl86ATPPw cweMgFaBjTszA8DTL4VjR0rgeOfXlGi0qJnS7dLZxnnFOHXFmGApyQedYDJCpFL05dhOuRf9c2VLk DTHRzu55zE7JmJ1wGp00p9ECLFsYQewcR9e101lLVz2OgDrrusFhGzhi02k7CifCPaHHkXQIsFF88 gFnLBNJ4QSavWSf8Vas3WjQ9VgCyht70rLCAWxZlBoll936eCyRowqIX87sCIe0amQ0xyAmAIlBdz WpwQWFFofp4O3pdqfSndw8O5aM9mJkvdU5aZIpAe87UH3oRDCICxapeQfvqC2A38rFMAM9feWpFM6 8fQpZhZQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEs2t-0005hq-Qq; Thu, 19 Mar 2020 10:04:59 +0000 Date: Thu, 19 Mar 2020 03:04:59 -0700 From: Christoph Hellwig To: Thomas Gleixner Subject: Re: [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait Message-ID: <20200319100459.GA18506@infradead.org> References: <20200318204302.693307984@linutronix.de> <20200318204408.102694393@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318204408.102694393@linutronix.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, Peter Zijlstra , linux-pci@vger.kernel.org, Sebastian Andrzej Siewior , Oleg Nesterov , Joel Fernandes , Will Deacon , Ingo Molnar , Davidlohr Bueso , "Paul E . McKenney" , Logan Gunthorpe , Linus Torvalds , Arnd Bergmann , Steven Rostedt , Bjorn Helgaas , Kurt Schwemmer , Kalle Valo , Felipe Balbi , Greg Kroah-Hartman , Randy Dunlap , linux-wireless@vger.kernel.org, LKML , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Mar 18, 2020 at 09:43:09PM +0100, Thomas Gleixner wrote: > The PS3 notification interrupt and kthread use a hacked up completion to > communicate. Since we're wanting to change the completion implementation and > this is abuse anyway, replace it with a simple rcuwait since there is only ever > the one waiter. > > AFAICT the kthread uses TASK_INTERRUPTIBLE to not increase loadavg, kthreads > cannot receive signals by default and this one doesn't look different. Use > TASK_IDLE instead. I think the right fix here is to jut convert the thing to a threaded interrupt handler and kill off the stupid kthread. But I wonder how alive the whole PS3 support is to start with..