From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73C8C4332D for ; Thu, 19 Mar 2020 10:18:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ABD00206D7 for ; Thu, 19 Mar 2020 10:18:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XAn2MhKQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABD00206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 43FAD6B0003; Thu, 19 Mar 2020 06:18:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C7856B0005; Thu, 19 Mar 2020 06:18:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DF106B0006; Thu, 19 Mar 2020 06:18:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 12ED16B0003 for ; Thu, 19 Mar 2020 06:18:32 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C0856181AEF07 for ; Thu, 19 Mar 2020 10:18:31 +0000 (UTC) X-FDA: 76611712422.23.sheep65_1038dcd97f05d X-HE-Tag: sheep65_1038dcd97f05d X-Filterd-Recvd-Size: 2080 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 10:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Sg3yv98oENUJ165z6EoRYEZN4oz0K/gLHgn3/2KcvJM=; b=XAn2MhKQC7mY2Fdl6MyDo8ZS6g 2MW/+Maup8mVTDioiQDJNfpn0jxVpqeePtVtXbrAvx4CE+h9EevBFUDc5Qlf+8v5vgmby8mwY797s iqNUZJitxjhyTxlcfkdPPQA5hVNXDpJENwummgF284VR0XgL/YPW6OVwcmQU9Ys+xDoDb1tm8e7zC Li+H/jDZKoA8XalUjdunpLvSdQQnD8/1TY96WzxquChedP+TGmSqNn+fIfA7nO4v5ujkSfDD9keVH iZdyrEvpAbM/AKbbTzJY8ootna8eS+raE1bEAumevdng++l5FfrdPNd0LdtBW+YX9FIqsQesUvSPe 3OWyG/kw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEsFv-0002lp-6V; Thu, 19 Mar 2020 10:18:27 +0000 Date: Thu, 19 Mar 2020 03:18:27 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-mm@kvack.org Subject: Re: [PATCH v2 3/8] mm: Check PageTail in hpage_nr_pages even when !THP Message-ID: <20200319101827.GB3590@infradead.org> References: <20200318140253.6141-1-willy@infradead.org> <20200318140253.6141-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318140253.6141-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 18, 2020 at 07:02:48AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > It's even more important to check that we don't have a tail page when > calling hpage_nr_pages() when THP are disabled. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig