From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32100C4332B for ; Thu, 19 Mar 2020 10:18:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E7A80206D7 for ; Thu, 19 Mar 2020 10:18:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cer48Ydp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7A80206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8836D6B0005; Thu, 19 Mar 2020 06:18:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80DD66B0006; Thu, 19 Mar 2020 06:18:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 723256B0007; Thu, 19 Mar 2020 06:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 5BB986B0005 for ; Thu, 19 Mar 2020 06:18:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0CBAE181AEF07 for ; Thu, 19 Mar 2020 10:18:44 +0000 (UTC) X-FDA: 76611712968.12.sky74_12032facf4c60 X-HE-Tag: sky74_12032facf4c60 X-Filterd-Recvd-Size: 2255 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 10:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p5QEj+53iH21x/jLgenIAPHvIJpm3G7uyBXwiK5lg8M=; b=cer48YdpBSuGQtif6qn2ILMWhh hNwho5UgNxw1J7k1dHZvUwxQlAfKlSXD4BHAQdI8JGXmNVypeyJAVg/EKAvo9PPNhBc8ryVSm2B37 uZ58Na13umGIsXXqWhpLsoNNkV33S8HqzF71ZkVqNw9Zl+6DWfaXE7zNu+dmXXMZM8hstXbnSlDuR XE7Rx/N5SwGOS9SNZCdnFI+0tJguwqotsGkxfezKtVQVw9BwnR1DbnuJ1pk/e6F1aZCK5V8J33RWx cgy8y9XGyBGHfYFuON+dEIMkwSWSfcauXmqtggOmTGeyqIbq4Av/L9jWSQwyZTZU5EscdYgKtNzHu ZErxYwaw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEsGA-0002nO-HN; Thu, 19 Mar 2020 10:18:42 +0000 Date: Thu, 19 Mar 2020 03:18:42 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-mm@kvack.org, "Kirill A . Shutemov" Subject: Re: [PATCH v2 4/8] mm: Optimise find_subpage for !THP Message-ID: <20200319101842.GC3590@infradead.org> References: <20200318140253.6141-1-willy@infradead.org> <20200318140253.6141-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318140253.6141-5-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 18, 2020 at 07:02:49AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > If THP is disabled, find_subpage() can become a no-op by using > hpage_nr_pages() instead of compound_nr(). hpage_nr_pages() embeds > a check for PageTail, so we can drop the check here. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Kirill A. Shutemov Looks good, Reviewed-by: Christoph Hellwig