From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097FEC4332E for ; Thu, 19 Mar 2020 13:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C50E421556 for ; Thu, 19 Mar 2020 13:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623462; bh=gxYuJpUZFx2/9oU5LKTRrj9anqQPMUYlvB8LcoK1RPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jGJNiR9RpvC0t/r+sCikWY9r8DCoL4aN2aWuAcBPRLZLy0B8ipRfvMdlXNIdFV3wf gGgaetSnaLAcJ6H1JQubKUpV/wJ3PiWCL1yNLUKE9mGx3T2f7GOg4LKI/FWYunPNWy gYrtVRsL/QclVXHAVOuGReoOpKNMtGccs9zxV7V4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728633AbgCSNLB (ORCPT ); Thu, 19 Mar 2020 09:11:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:55990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728620AbgCSNK7 (ORCPT ); Thu, 19 Mar 2020 09:10:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21A56208D6; Thu, 19 Mar 2020 13:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623459; bh=gxYuJpUZFx2/9oU5LKTRrj9anqQPMUYlvB8LcoK1RPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JLOamyO4Gz88O4hkcwokBijd6d18eWJCEDf3AWoXDhpTKDlG8RpmCdxbo5y9geM+T CtApjOwtmViUCkZRudO0A5eCvfYhjU39yj5wZAdLVkhxGBvLYYBdXTj5VryuGskLo6 NURte9dCjlVUi3JFpSyIjQzG8Et16yqKHU0TDBYU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Alex Deucher , nobuhiro1.iwamatsu@toshiba.co.jp Subject: [PATCH 4.9 34/90] drm/amd/display: remove duplicated assignment to grph_obj_type Date: Thu, 19 Mar 2020 13:59:56 +0100 Message-Id: <20200319123939.150633512@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123928.635114118@linuxfoundation.org> References: <20200319123928.635114118@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King commit d785476c608c621b345dd9396e8b21e90375cb0e upstream. Variable grph_obj_type is being assigned twice, one of these is redundant so remove it. Addresses-Coverity: ("Evaluation order violation") Signed-off-by: Colin Ian King Signed-off-by: Alex Deucher Cc: Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c @@ -363,8 +363,7 @@ bool amdgpu_atombios_get_connector_info_ router.ddc_valid = false; router.cd_valid = false; for (j = 0; j < ((le16_to_cpu(path->usSize) - 8) / 2); j++) { - uint8_t grph_obj_type= - grph_obj_type = + uint8_t grph_obj_type = (le16_to_cpu(path->usGraphicObjIds[j]) & OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT;