From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE45C4332B for ; Thu, 19 Mar 2020 14:31:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9134820663 for ; Thu, 19 Mar 2020 14:31:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="TDbo3D73" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9134820663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D1C486B0003; Thu, 19 Mar 2020 10:31:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA5E86B0007; Thu, 19 Mar 2020 10:31:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6DB36B0008; Thu, 19 Mar 2020 10:31:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 9C2BA6B0003 for ; Thu, 19 Mar 2020 10:31:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 40DB5181AEF09 for ; Thu, 19 Mar 2020 14:31:49 +0000 (UTC) X-FDA: 76612350738.19.rings37_2cf573d72e933 X-HE-Tag: rings37_2cf573d72e933 X-Filterd-Recvd-Size: 3586 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 14:31:48 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id s13so2754465ljm.1 for ; Thu, 19 Mar 2020 07:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/3ellrrw3RRS6LMNje2jXGNCoKHfCE6YcHPx1ro9PMg=; b=TDbo3D73JKnHwvL7rfxoNKMniJHTHmpelGc1yjDDsUw1CzwcZrTFYlLyyApYPVNg3Z GO2eUVSqdagqu1fZ/legd26NwNZBnMVI7Rg2MyO7g1pPyYBwfgXG8rQkw7rGrbwYWSDW Fgnta71gqWfhXnVuE5cvcr7U6Psl5KOx1zYLZ59es9E8iTatE1a5mElAr1MjmPLWelYB gCyjSPAPj7LuZw3W8C5kbT1xUe14OXfvFyFa+OjLQoIcsc8p5hCg848Z+rLOs5LPF2mx RPaI4FlVIF6YGhR8cPXAMtfFVjByusBTO15YpZHvByJ7KiQ0MkYFbjN6RwtUYJUgUB96 nuPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/3ellrrw3RRS6LMNje2jXGNCoKHfCE6YcHPx1ro9PMg=; b=pJbF3k6LwaQEEYl6f81o1km1SKXLfKU+voV/9q0YH84UcadjN8r0BqTqHuqTfMdfXw Q7LqPcaMEx0nu8o4iwyPZ1FLO/Ul6LDPxUb/bs52xbs9RDtN1u+NYOcU/m+UWVo0BdZg J0tCo/13xjT1U8nOxx0hXbTzBAdrJl1OZt0+E20AOLpDkPPDO4Gex6fjLPXMiARK/9Wb Bpm3qkbZzVGKIS9HM0gK1OE1oZMrqsuiI/9zacj6mOArpggVhPjSIy7FRI/c0GmJ/GZA akNC8QrdrFGI+O3jVUT013o0ZIMTVJXleB3Cq+bCqLcJcNOLC5BP1J9VYB+yje9iXJYz teMQ== X-Gm-Message-State: ANhLgQ2nmtI5mo14tNnqlPLrP0tTuyrST34suSqBWiOLJ2yz+vM1fvnw 3aZl9GB5Z5ETEK0PELwS8Y88kgB8ajE= X-Google-Smtp-Source: ADFU+vsBwn7M8r+7oi5BqtcsMHBdTdeQDH4mpDaldrnszbBWM372Sp4GwYdSByvF2FLUCWv/LZ26Gw== X-Received: by 2002:a2e:9a0f:: with SMTP id o15mr2396260lji.108.1584628307411; Thu, 19 Mar 2020 07:31:47 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id j8sm1692298lfe.34.2020.03.19.07.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 07:31:45 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 79BF91021F8; Thu, 19 Mar 2020 17:31:48 +0300 (+03) Date: Thu, 19 Mar 2020 17:31:48 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-mm@kvack.org Subject: Re: [PATCH v2 2/8] mm: Rename arguments to find_subpage Message-ID: <20200319143148.apt24vjjv733fuw5@box> References: <20200318140253.6141-1-willy@infradead.org> <20200318140253.6141-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318140253.6141-3-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 18, 2020 at 07:02:47AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This isn't just a random struct page, it's known to be a head page, > and calling it head makes the function better self-documenting. > The pgoff_t is less confusing if it's named index instead of offset. > Also add a couple of comments to explain why we're doing various things. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov