All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
	hkallweit1@gmail.com, antoine.tenart@bootlin.com
Subject: [PATCH net-next 2/4] net: phy: mscc: accept all RGMII species in vsc85xx_mac_if_set
Date: Thu, 19 Mar 2020 23:16:47 +0200	[thread overview]
Message-ID: <20200319211649.10136-3-olteanv@gmail.com> (raw)
In-Reply-To: <20200319211649.10136-1-olteanv@gmail.com>

From: Vladimir Oltean <vladimir.oltean@nxp.com>

The helper for configuring the pinout of the MII side of the PHY should
do so irrespective of whether RGMII delays are used or not. So accept
the ID, TXID and RXID variants as well, not just the no-delay RGMII
variant.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/phy/mscc/mscc_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c
index d221583ed97a..67d96a3e0fad 100644
--- a/drivers/net/phy/mscc/mscc_main.c
+++ b/drivers/net/phy/mscc/mscc_main.c
@@ -491,6 +491,9 @@ static int vsc85xx_mac_if_set(struct phy_device *phydev,
 	reg_val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1);
 	reg_val &= ~(MAC_IF_SELECTION_MASK);
 	switch (interface) {
+	case PHY_INTERFACE_MODE_RGMII_TXID:
+	case PHY_INTERFACE_MODE_RGMII_RXID:
+	case PHY_INTERFACE_MODE_RGMII_ID:
 	case PHY_INTERFACE_MODE_RGMII:
 		reg_val |= (MAC_IF_SELECTION_RGMII << MAC_IF_SELECTION_POS);
 		break;
-- 
2.17.1


  parent reply	other threads:[~2020-03-19 21:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 21:16 [PATCH net-next 0/4] MSCC PHY: RGMII delays and VSC8502 support Vladimir Oltean
2020-03-19 21:16 ` [PATCH net-next 1/4] net: phy: mscc: rename enum rgmii_rx_clock_delay to rgmii_clock_delay Vladimir Oltean
2020-03-20 10:09   ` Andrew Lunn
2020-03-20 10:38     ` Vladimir Oltean
2020-03-20 11:04       ` Antoine Tenart
2020-03-20 11:32         ` Vladimir Oltean
2020-03-21 17:01           ` Andrew Lunn
2020-03-21 17:28             ` Vladimir Oltean
2020-03-20 20:59   ` Florian Fainelli
2020-03-19 21:16 ` Vladimir Oltean [this message]
2020-03-20 20:58   ` [PATCH net-next 2/4] net: phy: mscc: accept all RGMII species in vsc85xx_mac_if_set Florian Fainelli
2020-03-19 21:16 ` [PATCH net-next 3/4] net: phy: mscc: configure both RX and TX internal delays for RGMII Vladimir Oltean
2020-03-19 21:16 ` [PATCH net-next 4/4] net: phy: mscc: add support for VSC8502 Vladimir Oltean
2020-03-24  3:52 ` [PATCH net-next 0/4] MSCC PHY: RGMII delays and VSC8502 support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319211649.10136-3-olteanv@gmail.com \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.