From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D5EC4332E for ; Fri, 20 Mar 2020 01:01:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A65720754 for ; Fri, 20 Mar 2020 01:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584666093; bh=o0VFTujZMLncAeLGmepbNCZ7f0oxj0XpRGz9xU/4kSg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=j8RqBMnK5aeG2utPd440hIUcqhNkX+EbxYDNMafzqsn24pvrI+6rvZ/pkov7w5C+n NT7m+YYUDQ1j7IjYD/KD9glzdxUtqLeXDFWP51q8phJ5xL/lboX6/JCcKQ/Oc4OOKR 1RNRP9xcj51dNt1oXZhkrgJG+t6l9hh1pJ1sB6ZU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbgCTBBc (ORCPT ); Thu, 19 Mar 2020 21:01:32 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:40061 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727235AbgCTBBc (ORCPT ); Thu, 19 Mar 2020 21:01:32 -0400 Received: by mail-io1-f65.google.com with SMTP id h18so4341921ioh.7; Thu, 19 Mar 2020 18:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ot6m4hY0BwqCmo0YvvIottBecwmdUoxIdqh0iIdJLaE=; b=e0vc4wcMKbYfbI6kyipBnoZ1jmoO413EpOBpUIq2a2ONQx4SMkadKAsSv/al4OvhS6 dG7+iC9ejaWy2n9m67iLR0LfuJJRrO16XToJBG6D4gMWktjXSIXXtqIXGsQ8PnbCMMzG 9lLuVaC6YZ4S3JVRhPb+MOk8omHlUR97IDjmNEcaiZq6Xfw8YELFte7Jt984jB3i89u1 LWHsNliibdWRyBFuXfmvcQc8iS6WGC35TsBCfsUVOcCrcDEwfp8qd2crOiobfTfo5ASH fZFfZTfpHIhTtwr3BWH3T4yBBy8udnF6xjuYGP39Il1mZwA8G2Clm8bl4zldq2t0YQul zrQw== X-Gm-Message-State: ANhLgQ30r6Rr3/d1b7Q4/X+9aJ1ZLJDR4TAt+nZyIGHZjiCRjbDgmK/2 VIafk6fZhJ/UdZujRyk0EQ== X-Google-Smtp-Source: ADFU+vveriY9yvP9Jzlx6UROYD7yZzJxkqX2tb0ZEVFvDtSMM5LsoOiJpdoQMBneWm4Sh8Le1oz4Cg== X-Received: by 2002:a5e:9b09:: with SMTP id j9mr5198775iok.114.1584666091207; Thu, 19 Mar 2020 18:01:31 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id s18sm1290993ioc.0.2020.03.19.18.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 18:01:30 -0700 (PDT) Received: (nullmailer pid 17809 invoked by uid 1000); Fri, 20 Mar 2020 01:01:27 -0000 Date: Thu, 19 Mar 2020 19:01:27 -0600 From: Rob Herring To: Harigovindan P Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, sean@poorly.run Subject: Re: [PATCH v7 1/2] dt-bindings: display: add visionox rm69299 panel variant Message-ID: <20200320010127.GA8379@bogus> References: <20200316041647.27953-1-harigovi@codeaurora.org> <20200316041647.27953-2-harigovi@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316041647.27953-2-harigovi@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Mar 16, 2020 at 09:46:46AM +0530, Harigovindan P wrote: > Add bindings for visionox rm69299 panel. > > Signed-off-by: Harigovindan P > --- > > Changes in v2: > - Removed unwanted properties from description. > - Creating source files without execute permissions(Rob Herring). > Changes in v3: > - Changing txt file into yaml > Changes in v4: > - Updating license identifier. > - Moving yaml file inside panel directory. > - Removing pinctrl entries. > - Adding documentation for reset-gpios. > Changes in v5: > - No changes. Updated 2/2 Patch. > Changes in v6: > - Removing patternProperties. > - Added " |" after description. > - Setting port and reset-gpios to true. > - Removing @ae94000 for dsi node. > Changes in v7: > - Added reg property. > > .../display/panel/visionox,rm69299.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml b/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml > new file mode 100644 > index 000000000000..6ea1a7be3787 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/visionox,rm69299.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Visionox model RM69299 Panels Device Tree Bindings. > + > +maintainers: > + - Harigovindan P > + > +description: | > + This binding is for display panels using a Visionox RM692999 panel. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: visionox,rm69299-1080p-display > + > + reg: > + maxItems: 1 > + > + vdda-supply: > + description: | > + Phandle of the regulator that provides the vdda supply voltage. > + > + vdd3p3-supply: > + description: | > + Phandle of the regulator that provides the vdd3p3 supply voltage. > + > + ports: > + type: object > + description: | > + A node containing DSI input & output port nodes with endpoint > + definitions as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + Documentation/devicetree/bindings/graph.txt > + properties: > + port: true Need: additionalProperties: false > + > + reset-gpios: true > + > +required: > + - compatible > + - reg > + - vdda-supply > + - vdd3p3-supply > + - reset-gpios > + > +additionalProperties: false > + > +examples: > + - | > + dsi { > + reg = <0x0ae94000 0x400>; Either drop 'reg' or add a unit-address. > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "visionox,rm69299-1080p-display"; > + reg = <0x0ae94000 0x400>; Wrong address. > + > + vdda-supply = <&src_pp1800_l8c>; > + vdd3p3-supply = <&src_pp2800_l18a>; > + > + reset-gpios = <&pm6150l_gpio 3 0>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { This will fail with the above change. > + reg = <0>; > + panel0_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; > + }; > + > +... > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50D2C43332 for ; Fri, 20 Mar 2020 01:01:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8450320740 for ; Fri, 20 Mar 2020 01:01:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8450320740 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A034F6E0F8; Fri, 20 Mar 2020 01:01:33 +0000 (UTC) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A6936E0F8; Fri, 20 Mar 2020 01:01:32 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id q9so4373650iod.4; Thu, 19 Mar 2020 18:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ot6m4hY0BwqCmo0YvvIottBecwmdUoxIdqh0iIdJLaE=; b=Kw4c5tQUHzcd/e1ybN654QCz1VfoF9hneaQkj8iLFKRFZeSFK2HZHmvKmLJhKN89NB qNGP+eoq/fvcdMCYCi8EptCp26MuR0UxUYFHmA7hFVD+MolZZrE9qjoFEfk9URQnoHMN sqtKiXpxNBUNHZ2fWjO2hmuFlLQzQgX7vR/La9W4s+Sprgjwsj1wEDYlz+2TBiKBm96I 3zgIFkbLrYEq7ylhAiM7eGPq5s6r/2XeC4o09stUk9lNwfzsKakemMaACujoO0NfVL8w aALvHhynRqO1we16KjCQz8U+T4dkYsMTQmz2AqxkoruHzpOadrEclBn9yVCeX/RishDY qW4Q== X-Gm-Message-State: ANhLgQ3HzYX7byLwPZ30USlo1n+jQADFFl0BScqENLKVBD/LFL16MlP/ ZsVa6Ll1ZNLEd0A/EX93AQ== X-Google-Smtp-Source: ADFU+vveriY9yvP9Jzlx6UROYD7yZzJxkqX2tb0ZEVFvDtSMM5LsoOiJpdoQMBneWm4Sh8Le1oz4Cg== X-Received: by 2002:a5e:9b09:: with SMTP id j9mr5198775iok.114.1584666091207; Thu, 19 Mar 2020 18:01:31 -0700 (PDT) Received: from rob-hp-laptop ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id s18sm1290993ioc.0.2020.03.19.18.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 18:01:30 -0700 (PDT) Received: (nullmailer pid 17809 invoked by uid 1000); Fri, 20 Mar 2020 01:01:27 -0000 Date: Thu, 19 Mar 2020 19:01:27 -0600 From: Rob Herring To: Harigovindan P Subject: Re: [PATCH v7 1/2] dt-bindings: display: add visionox rm69299 panel variant Message-ID: <20200320010127.GA8379@bogus> References: <20200316041647.27953-1-harigovi@codeaurora.org> <20200316041647.27953-2-harigovi@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200316041647.27953-2-harigovi@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sean@poorly.run, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 16, 2020 at 09:46:46AM +0530, Harigovindan P wrote: > Add bindings for visionox rm69299 panel. > > Signed-off-by: Harigovindan P > --- > > Changes in v2: > - Removed unwanted properties from description. > - Creating source files without execute permissions(Rob Herring). > Changes in v3: > - Changing txt file into yaml > Changes in v4: > - Updating license identifier. > - Moving yaml file inside panel directory. > - Removing pinctrl entries. > - Adding documentation for reset-gpios. > Changes in v5: > - No changes. Updated 2/2 Patch. > Changes in v6: > - Removing patternProperties. > - Added " |" after description. > - Setting port and reset-gpios to true. > - Removing @ae94000 for dsi node. > Changes in v7: > - Added reg property. > > .../display/panel/visionox,rm69299.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml b/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml > new file mode 100644 > index 000000000000..6ea1a7be3787 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/visionox,rm69299.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Visionox model RM69299 Panels Device Tree Bindings. > + > +maintainers: > + - Harigovindan P > + > +description: | > + This binding is for display panels using a Visionox RM692999 panel. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: visionox,rm69299-1080p-display > + > + reg: > + maxItems: 1 > + > + vdda-supply: > + description: | > + Phandle of the regulator that provides the vdda supply voltage. > + > + vdd3p3-supply: > + description: | > + Phandle of the regulator that provides the vdd3p3 supply voltage. > + > + ports: > + type: object > + description: | > + A node containing DSI input & output port nodes with endpoint > + definitions as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + Documentation/devicetree/bindings/graph.txt > + properties: > + port: true Need: additionalProperties: false > + > + reset-gpios: true > + > +required: > + - compatible > + - reg > + - vdda-supply > + - vdd3p3-supply > + - reset-gpios > + > +additionalProperties: false > + > +examples: > + - | > + dsi { > + reg = <0x0ae94000 0x400>; Either drop 'reg' or add a unit-address. > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "visionox,rm69299-1080p-display"; > + reg = <0x0ae94000 0x400>; Wrong address. > + > + vdda-supply = <&src_pp1800_l8c>; > + vdd3p3-supply = <&src_pp2800_l18a>; > + > + reset-gpios = <&pm6150l_gpio 3 0>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { This will fail with the above change. > + reg = <0>; > + panel0_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; > + }; > + > +... > -- > 2.25.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel