From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240D7C4332E for ; Fri, 20 Mar 2020 12:58:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B53D820776 for ; Fri, 20 Mar 2020 12:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="IvTQLQxf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B53D820776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 18A636B0005; Fri, 20 Mar 2020 08:58:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B2B6B0006; Fri, 20 Mar 2020 08:58:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 001DC6B0007; Fri, 20 Mar 2020 08:58:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id D9B786B0005 for ; Fri, 20 Mar 2020 08:58:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 93A3B824556B for ; Fri, 20 Mar 2020 12:58:16 +0000 (UTC) X-FDA: 76615743792.01.step67_e03976f20415 X-HE-Tag: step67_e03976f20415 X-Filterd-Recvd-Size: 4899 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Mar 2020 12:58:16 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id w5so2841074qvp.11 for ; Fri, 20 Mar 2020 05:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7tshdo6c8ufpkvS21qNDq3o1JI++3fGdgC9NNzUitoU=; b=IvTQLQxfTudOZo6mQWXcw0MoAViFLghOoPbxW/9yZkUMgOiZ4Pv9Z04Csj2TJq5vca qb/NOPGNHtZJ6s24cM+QRSb5JuK21NJyav0y6/cJqE7vqjvLZeiPQwWPggHqBJHigTLB ymmND/5GQ89u7BiyP07RYIjAcCIa+vFjUpz4zOgJSTVCkcudYccK0vOVEQgM0fc99dpd Vs62xPG18t0GhZadO3Oap9mTCctOwTr0CiUfvnOTXVINl2qtmYv1/+hwvSX1r+r/EA1v Ke5XvA9K39riwOsICVFnrILW1mFcLwADDE6udlfAI2AZmQRk3mQ4NBUc46ebi+QLcJNF 7/Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7tshdo6c8ufpkvS21qNDq3o1JI++3fGdgC9NNzUitoU=; b=m7km8CWANxuNjeQZxKgDYc2EtcnAzZHNKHDpUjGuVi68oy3Aj9seXj6Si9sCTTjvfe UCI9Ccjyx08K+Bm/rn2iIc7mne32RkMCkyRoqoWBsk3BLKftSwhQ1Yj6Ny2BtWL2dhVw tsNPusJ+zSkMcAvj/+CHCkhRi+durMxL+HxCg+5sCU5tjUlwNLiDQ2WUxtYuEQDFz3ZC dg/fpWi0OPZDgIFt/CgmTrTZkbK5wUMCWjmvBaQjqlNTRBcMrexYTah/tSYKU9odvFnE 1LgmROF0n4rPI3irYhIEvBSBP+b0pVEQIoXae5KW46KBuoRz3MrKN116hU6+M/AQBSRk xF3Q== X-Gm-Message-State: ANhLgQ1/ctv9HL/Ne6tZwDPEOVlvOvDKZg469Q7/6bk4rgcYAaU5UA+x JiVFpXJ8baIjWFlA9r/GbG8OcA== X-Google-Smtp-Source: ADFU+vvR+3vAV1p7d+fDNfmTEDRX1I6s0r0r+8MeuA2PAqUC3MBTAsQJGe+LIm8TG0FJxBXCYdsOGw== X-Received: by 2002:a0c:ec02:: with SMTP id y2mr7683694qvo.171.1584709095500; Fri, 20 Mar 2020 05:58:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id y15sm4157894qky.33.2020.03.20.05.58.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Mar 2020 05:58:14 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jFHE5-0007Cq-2w; Fri, 20 Mar 2020 09:58:13 -0300 Date: Fri, 20 Mar 2020 09:58:13 -0300 From: Jason Gunthorpe To: Ralph Campbell Cc: Christoph Hellwig , Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= , Ben Skeggs , Jerome Glisse , kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Message-ID: <20200320125813.GQ20941@ziepe.ca> References: <20200316193216.920734-4-hch@lst.de> <7256f88d-809e-4aba-3c46-a223bd8cc521@nvidia.com> <20200317121536.GQ20941@ziepe.ca> <20200317122445.GA11662@lst.de> <20200317122813.GA11866@lst.de> <20200317124755.GR20941@ziepe.ca> <20200317125955.GA12847@lst.de> <24fca825-3b0f-188f-bcf2-fadcf3a9f05a@nvidia.com> <20200320001428.GA9199@ziepe.ca> <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 19, 2020 at 06:33:04PM -0700, Ralph Campbell wrote: > > > + .default_flags = dmirror_hmm_flags[HMM_PFN_VALID] | > > > + (write ? dmirror_hmm_flags[HMM_PFN_WRITE] : 0), > > > + .dev_private_owner = dmirror->mdevice, > > > + }; > > > + int ret = 0; > > > > > +static int dmirror_snapshot(struct dmirror *dmirror, > > > + struct hmm_dmirror_cmd *cmd) > > > +{ > > > + struct mm_struct *mm = dmirror->mm; > > > + unsigned long start, end; > > > + unsigned long size = cmd->npages << PAGE_SHIFT; > > > + unsigned long addr; > > > + unsigned long next; > > > + uint64_t pfns[64]; > > > + unsigned char perm[64]; > > > + char __user *uptr; > > > + struct hmm_range range = { > > > + .pfns = pfns, > > > + .flags = dmirror_hmm_flags, > > > + .values = dmirror_hmm_values, > > > + .pfn_shift = DPT_SHIFT, > > > + .pfn_flags_mask = ~0ULL, > > > > Same here, especially since this is snapshot > > > > Jason > > Actually, snapshot ignores pfn_flags_mask and default_flags. Yes, so no reason to set them to not 0.. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Date: Fri, 20 Mar 2020 09:58:13 -0300 Message-ID: <20200320125813.GQ20941@ziepe.ca> References: <20200316193216.920734-4-hch@lst.de> <7256f88d-809e-4aba-3c46-a223bd8cc521@nvidia.com> <20200317121536.GQ20941@ziepe.ca> <20200317122445.GA11662@lst.de> <20200317122813.GA11866@lst.de> <20200317124755.GR20941@ziepe.ca> <20200317125955.GA12847@lst.de> <24fca825-3b0f-188f-bcf2-fadcf3a9f05a@nvidia.com> <20200320001428.GA9199@ziepe.ca> <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <8d549ef6-14ae-7055-58c8-d56de8bf4ba6-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ralph Campbell Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Ben Skeggs , Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= List-Id: nouveau.vger.kernel.org On Thu, Mar 19, 2020 at 06:33:04PM -0700, Ralph Campbell wrote: > > > + .default_flags = dmirror_hmm_flags[HMM_PFN_VALID] | > > > + (write ? dmirror_hmm_flags[HMM_PFN_WRITE] : 0), > > > + .dev_private_owner = dmirror->mdevice, > > > + }; > > > + int ret = 0; > > > > > +static int dmirror_snapshot(struct dmirror *dmirror, > > > + struct hmm_dmirror_cmd *cmd) > > > +{ > > > + struct mm_struct *mm = dmirror->mm; > > > + unsigned long start, end; > > > + unsigned long size = cmd->npages << PAGE_SHIFT; > > > + unsigned long addr; > > > + unsigned long next; > > > + uint64_t pfns[64]; > > > + unsigned char perm[64]; > > > + char __user *uptr; > > > + struct hmm_range range = { > > > + .pfns = pfns, > > > + .flags = dmirror_hmm_flags, > > > + .values = dmirror_hmm_values, > > > + .pfn_shift = DPT_SHIFT, > > > + .pfn_flags_mask = ~0ULL, > > > > Same here, especially since this is snapshot > > > > Jason > > Actually, snapshot ignores pfn_flags_mask and default_flags. Yes, so no reason to set them to not 0.. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77560C4332B for ; Sat, 21 Mar 2020 10:44:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A8D9206F9 for ; Sat, 21 Mar 2020 10:44:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="IvTQLQxf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A8D9206F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 879966E2F2; Sat, 21 Mar 2020 10:44:37 +0000 (UTC) Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 889626EB2C for ; Fri, 20 Mar 2020 12:58:16 +0000 (UTC) Received: by mail-qv1-xf43.google.com with SMTP id m2so2836855qvu.13 for ; Fri, 20 Mar 2020 05:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7tshdo6c8ufpkvS21qNDq3o1JI++3fGdgC9NNzUitoU=; b=IvTQLQxfTudOZo6mQWXcw0MoAViFLghOoPbxW/9yZkUMgOiZ4Pv9Z04Csj2TJq5vca qb/NOPGNHtZJ6s24cM+QRSb5JuK21NJyav0y6/cJqE7vqjvLZeiPQwWPggHqBJHigTLB ymmND/5GQ89u7BiyP07RYIjAcCIa+vFjUpz4zOgJSTVCkcudYccK0vOVEQgM0fc99dpd Vs62xPG18t0GhZadO3Oap9mTCctOwTr0CiUfvnOTXVINl2qtmYv1/+hwvSX1r+r/EA1v Ke5XvA9K39riwOsICVFnrILW1mFcLwADDE6udlfAI2AZmQRk3mQ4NBUc46ebi+QLcJNF 7/Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7tshdo6c8ufpkvS21qNDq3o1JI++3fGdgC9NNzUitoU=; b=fgqPWP2jkGTiu7sgSPdlr2m03siwK+s2LFQeLfitSt5NBsHhy84wdP5/YfG0sAp1ly JD+uYb7ZmnlOFsxzR3VjZ04TPrWdSvHlPR8S+nyzvsqnDLSkXNMYWNpA6PFrRJPRLxSP FHC+mImEGleqS53QEC6slc0cIw058KiIFPIfzWjDaXP8h/SVms31viMfwHG4+9zR0ynz C2jdfDLgHzy4e+IV7+KVWI6MTq6enpBWQOdf4U9ormJksStZukuUxrJJVVTUq/ZsPonX E9rO+UdRFLJjCJX7lb0ZEEVJ5XvMU6NR9oGdt0/uFiYxWh1ws+C9Ud3gDFzQ5aCD+0Wk Vxng== X-Gm-Message-State: ANhLgQ2dzIpdfL8VQ3M3exveVWiJvbVF9klUAVWqqep7sAUk68DvKYOA GWpAzywbDCyJHJbJX3HAastQIg== X-Google-Smtp-Source: ADFU+vvR+3vAV1p7d+fDNfmTEDRX1I6s0r0r+8MeuA2PAqUC3MBTAsQJGe+LIm8TG0FJxBXCYdsOGw== X-Received: by 2002:a0c:ec02:: with SMTP id y2mr7683694qvo.171.1584709095500; Fri, 20 Mar 2020 05:58:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id y15sm4157894qky.33.2020.03.20.05.58.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Mar 2020 05:58:14 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jFHE5-0007Cq-2w; Fri, 20 Mar 2020 09:58:13 -0300 Date: Fri, 20 Mar 2020 09:58:13 -0300 From: Jason Gunthorpe To: Ralph Campbell Subject: Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Message-ID: <20200320125813.GQ20941@ziepe.ca> References: <20200316193216.920734-4-hch@lst.de> <7256f88d-809e-4aba-3c46-a223bd8cc521@nvidia.com> <20200317121536.GQ20941@ziepe.ca> <20200317122445.GA11662@lst.de> <20200317122813.GA11866@lst.de> <20200317124755.GR20941@ziepe.ca> <20200317125955.GA12847@lst.de> <24fca825-3b0f-188f-bcf2-fadcf3a9f05a@nvidia.com> <20200320001428.GA9199@ziepe.ca> <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Sat, 21 Mar 2020 10:44:25 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kvm-ppc@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Jerome Glisse , Ben Skeggs , Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 19, 2020 at 06:33:04PM -0700, Ralph Campbell wrote: > > > + .default_flags = dmirror_hmm_flags[HMM_PFN_VALID] | > > > + (write ? dmirror_hmm_flags[HMM_PFN_WRITE] : 0), > > > + .dev_private_owner = dmirror->mdevice, > > > + }; > > > + int ret = 0; > > > > > +static int dmirror_snapshot(struct dmirror *dmirror, > > > + struct hmm_dmirror_cmd *cmd) > > > +{ > > > + struct mm_struct *mm = dmirror->mm; > > > + unsigned long start, end; > > > + unsigned long size = cmd->npages << PAGE_SHIFT; > > > + unsigned long addr; > > > + unsigned long next; > > > + uint64_t pfns[64]; > > > + unsigned char perm[64]; > > > + char __user *uptr; > > > + struct hmm_range range = { > > > + .pfns = pfns, > > > + .flags = dmirror_hmm_flags, > > > + .values = dmirror_hmm_values, > > > + .pfn_shift = DPT_SHIFT, > > > + .pfn_flags_mask = ~0ULL, > > > > Same here, especially since this is snapshot > > > > Jason > > Actually, snapshot ignores pfn_flags_mask and default_flags. Yes, so no reason to set them to not 0.. Jason _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2182C4332B for ; Fri, 20 Mar 2020 14:46:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C25520739 for ; Fri, 20 Mar 2020 14:46:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="IvTQLQxf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C25520739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BB2C89F77; Fri, 20 Mar 2020 14:46:34 +0000 (UTC) Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 883C06EB2B for ; Fri, 20 Mar 2020 12:58:16 +0000 (UTC) Received: by mail-qv1-xf42.google.com with SMTP id h20so2840391qvr.12 for ; Fri, 20 Mar 2020 05:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7tshdo6c8ufpkvS21qNDq3o1JI++3fGdgC9NNzUitoU=; b=IvTQLQxfTudOZo6mQWXcw0MoAViFLghOoPbxW/9yZkUMgOiZ4Pv9Z04Csj2TJq5vca qb/NOPGNHtZJ6s24cM+QRSb5JuK21NJyav0y6/cJqE7vqjvLZeiPQwWPggHqBJHigTLB ymmND/5GQ89u7BiyP07RYIjAcCIa+vFjUpz4zOgJSTVCkcudYccK0vOVEQgM0fc99dpd Vs62xPG18t0GhZadO3Oap9mTCctOwTr0CiUfvnOTXVINl2qtmYv1/+hwvSX1r+r/EA1v Ke5XvA9K39riwOsICVFnrILW1mFcLwADDE6udlfAI2AZmQRk3mQ4NBUc46ebi+QLcJNF 7/Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7tshdo6c8ufpkvS21qNDq3o1JI++3fGdgC9NNzUitoU=; b=PuE44IXmuhKH+0isR8EqdVCe7C2szeMknqMUpiLDbreepKqDEMa63nUt6QdCdO9Pzb MGtHQQMqMQDgCWFnCsDfyH2zLQ6AnSUdWcEyEmp32fM4WzaoVTMN3wcCxFvsLYQa5OK4 vJoSL0VIFyE/8TU+XIm8nF1iMPsT8k6YHMwzwDJgKLAavvj/qBQxZ9DukUHeJUf3GJDp ZlotFHjaGxdRHQt9MI+ph40tMUd0DO/YaYqmjmr96yDuYDOZyDJDAuGALlDoFFVnCOr7 i59pkRHFsUHyaYWJJz1PA7o11xRGG8VHRud2OjVE5Pd74B8YmCzXr8Ol8k2mqn2O4MLV vxvg== X-Gm-Message-State: ANhLgQ1uynAFc+zaF5pRcqxJL0u4JieGs2i3lrQaHIlZnNPyI9/y4ZV0 UaojymnLs5p3RJxg5C9BBDlMvg== X-Google-Smtp-Source: ADFU+vvR+3vAV1p7d+fDNfmTEDRX1I6s0r0r+8MeuA2PAqUC3MBTAsQJGe+LIm8TG0FJxBXCYdsOGw== X-Received: by 2002:a0c:ec02:: with SMTP id y2mr7683694qvo.171.1584709095500; Fri, 20 Mar 2020 05:58:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id y15sm4157894qky.33.2020.03.20.05.58.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Mar 2020 05:58:14 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jFHE5-0007Cq-2w; Fri, 20 Mar 2020 09:58:13 -0300 Date: Fri, 20 Mar 2020 09:58:13 -0300 From: Jason Gunthorpe To: Ralph Campbell Subject: Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Message-ID: <20200320125813.GQ20941@ziepe.ca> References: <20200316193216.920734-4-hch@lst.de> <7256f88d-809e-4aba-3c46-a223bd8cc521@nvidia.com> <20200317121536.GQ20941@ziepe.ca> <20200317122445.GA11662@lst.de> <20200317122813.GA11866@lst.de> <20200317124755.GR20941@ziepe.ca> <20200317125955.GA12847@lst.de> <24fca825-3b0f-188f-bcf2-fadcf3a9f05a@nvidia.com> <20200320001428.GA9199@ziepe.ca> <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Fri, 20 Mar 2020 14:46:33 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kvm-ppc@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Jerome Glisse , Ben Skeggs , Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, Mar 19, 2020 at 06:33:04PM -0700, Ralph Campbell wrote: > > > + .default_flags = dmirror_hmm_flags[HMM_PFN_VALID] | > > > + (write ? dmirror_hmm_flags[HMM_PFN_WRITE] : 0), > > > + .dev_private_owner = dmirror->mdevice, > > > + }; > > > + int ret = 0; > > > > > +static int dmirror_snapshot(struct dmirror *dmirror, > > > + struct hmm_dmirror_cmd *cmd) > > > +{ > > > + struct mm_struct *mm = dmirror->mm; > > > + unsigned long start, end; > > > + unsigned long size = cmd->npages << PAGE_SHIFT; > > > + unsigned long addr; > > > + unsigned long next; > > > + uint64_t pfns[64]; > > > + unsigned char perm[64]; > > > + char __user *uptr; > > > + struct hmm_range range = { > > > + .pfns = pfns, > > > + .flags = dmirror_hmm_flags, > > > + .values = dmirror_hmm_values, > > > + .pfn_shift = DPT_SHIFT, > > > + .pfn_flags_mask = ~0ULL, > > > > Same here, especially since this is snapshot > > > > Jason > > Actually, snapshot ignores pfn_flags_mask and default_flags. Yes, so no reason to set them to not 0.. Jason _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Fri, 20 Mar 2020 12:58:13 +0000 Subject: Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Message-Id: <20200320125813.GQ20941@ziepe.ca> List-Id: References: <20200316193216.920734-4-hch@lst.de> <7256f88d-809e-4aba-3c46-a223bd8cc521@nvidia.com> <20200317121536.GQ20941@ziepe.ca> <20200317122445.GA11662@lst.de> <20200317122813.GA11866@lst.de> <20200317124755.GR20941@ziepe.ca> <20200317125955.GA12847@lst.de> <24fca825-3b0f-188f-bcf2-fadcf3a9f05a@nvidia.com> <20200320001428.GA9199@ziepe.ca> <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> In-Reply-To: <8d549ef6-14ae-7055-58c8-d56de8bf4ba6@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ralph Campbell Cc: Christoph Hellwig , Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= , Ben Skeggs , Jerome Glisse , kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-mm@kvack.org On Thu, Mar 19, 2020 at 06:33:04PM -0700, Ralph Campbell wrote: > > > + .default_flags = dmirror_hmm_flags[HMM_PFN_VALID] | > > > + (write ? dmirror_hmm_flags[HMM_PFN_WRITE] : 0), > > > + .dev_private_owner = dmirror->mdevice, > > > + }; > > > + int ret = 0; > > > > > +static int dmirror_snapshot(struct dmirror *dmirror, > > > + struct hmm_dmirror_cmd *cmd) > > > +{ > > > + struct mm_struct *mm = dmirror->mm; > > > + unsigned long start, end; > > > + unsigned long size = cmd->npages << PAGE_SHIFT; > > > + unsigned long addr; > > > + unsigned long next; > > > + uint64_t pfns[64]; > > > + unsigned char perm[64]; > > > + char __user *uptr; > > > + struct hmm_range range = { > > > + .pfns = pfns, > > > + .flags = dmirror_hmm_flags, > > > + .values = dmirror_hmm_values, > > > + .pfn_shift = DPT_SHIFT, > > > + .pfn_flags_mask = ~0ULL, > > > > Same here, especially since this is snapshot > > > > Jason > > Actually, snapshot ignores pfn_flags_mask and default_flags. Yes, so no reason to set them to not 0.. Jason