From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89979C4332D for ; Fri, 20 Mar 2020 13:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C56320754 for ; Fri, 20 Mar 2020 13:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584712568; bh=bQLfnNJ21tARCpyrrG8kAbYnLEtL50j8Wc8tG/DdL90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lL4DSaGDY+HrTE/TxwWUasPwQH//s2KK8HPoGZwaN+tcEyPTZdjjLbrFUcr4THCkY /04eev0jBbG2Qtnw5OF6u6suHwc4dTWtRXkINmeZ5E/JjXiASpoRlsTKe72/HhCTYS wpjUrT7uj4H+UQvIkURrlplYgiauEqsYmfDicgq8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbgCTN4H (ORCPT ); Fri, 20 Mar 2020 09:56:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:58052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbgCTN4H (ORCPT ); Fri, 20 Mar 2020 09:56:07 -0400 Received: from localhost (unknown [122.167.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D559720709; Fri, 20 Mar 2020 13:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584712566; bh=bQLfnNJ21tARCpyrrG8kAbYnLEtL50j8Wc8tG/DdL90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NavK74h2sYbbhdArU4x0jD1mqxNRojoZeiD2Qy9BRwIEIPCfkuC+cttylna7mGG05 3T+ScfauWK8yJSIU57Kgg7uh7YuKBXjGJzKIjUsdwR+KV3jL0gVuXPAk+tXokSx3AM NAtOipTPMM2f+0SYs0ggJCObPHK0GAaWtS0N/pmY= Date: Fri, 20 Mar 2020 19:26:02 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: broonie@kernel.org, pierre-louis.bossart@linux.intel.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 1/2] soundwire: stream: Add read_only_wordlength flag to port properties Message-ID: <20200320135602.GF4885@vkoul-mobl> References: <20200311113545.23773-1-srinivas.kandagatla@linaro.org> <20200311113545.23773-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311113545.23773-2-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-03-20, 11:35, Srinivas Kandagatla wrote: > According to SoundWire Specification Version 1.2. > "A Data Port number X (in the range 0-14) which supports only one > value of WordLength may implement the WordLength field in the > DPX_BlockCtrl1 Register as Read-Only, returning the fixed value of > WordLength in response to reads." > > As WSA881x interfaces in PDM mode making the only field "WordLength" > in DPX_BlockCtrl1" fixed and read-only. Behaviour of writing to this > register on WSA881x soundwire slave with Qualcomm Soundwire Controller > is throwing up an error. Not sure how other controllers deal with > writing to readonly registers, but this patch provides a way to avoid > writes to DPN_BlockCtrl1 register by providing a read_only_wordlength > flag in struct sdw_dpn_prop Applied, thanks I will send a tag, so that mark can apply the second patch for asoc Thanks -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E47C4332B for ; Fri, 20 Mar 2020 13:57:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 772DA20754 for ; Fri, 20 Mar 2020 13:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="DUxiifhT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NavK74h2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 772DA20754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C70CC17D0; Fri, 20 Mar 2020 14:56:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C70CC17D0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584712622; bh=bQLfnNJ21tARCpyrrG8kAbYnLEtL50j8Wc8tG/DdL90=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DUxiifhTMSC8RHtIBvONLGQC6ObtoAubefXe1MLD6YdO5cNxaEeltfkGEepwno6gG ipEqbnF+GkIfQ8LEb3aPdkc0/0PykWg3dPkvREzEfeHjTPGDVJ1/ILCM/et8V4o0D7 CUfN8frv3A9jCvWUSon8eWPsMXygSqhPFYHEyOPQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 57C10F800DD; Fri, 20 Mar 2020 14:56:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C3C7CF8015B; Fri, 20 Mar 2020 14:56:11 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42AB9F800DD for ; Fri, 20 Mar 2020 14:56:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42AB9F800DD Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NavK74h2" Received: from localhost (unknown [122.167.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D559720709; Fri, 20 Mar 2020 13:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584712566; bh=bQLfnNJ21tARCpyrrG8kAbYnLEtL50j8Wc8tG/DdL90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NavK74h2sYbbhdArU4x0jD1mqxNRojoZeiD2Qy9BRwIEIPCfkuC+cttylna7mGG05 3T+ScfauWK8yJSIU57Kgg7uh7YuKBXjGJzKIjUsdwR+KV3jL0gVuXPAk+tXokSx3AM NAtOipTPMM2f+0SYs0ggJCObPHK0GAaWtS0N/pmY= Date: Fri, 20 Mar 2020 19:26:02 +0530 From: Vinod Koul To: Srinivas Kandagatla Subject: Re: [PATCH 1/2] soundwire: stream: Add read_only_wordlength flag to port properties Message-ID: <20200320135602.GF4885@vkoul-mobl> References: <20200311113545.23773-1-srinivas.kandagatla@linaro.org> <20200311113545.23773-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311113545.23773-2-srinivas.kandagatla@linaro.org> Cc: alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11-03-20, 11:35, Srinivas Kandagatla wrote: > According to SoundWire Specification Version 1.2. > "A Data Port number X (in the range 0-14) which supports only one > value of WordLength may implement the WordLength field in the > DPX_BlockCtrl1 Register as Read-Only, returning the fixed value of > WordLength in response to reads." > > As WSA881x interfaces in PDM mode making the only field "WordLength" > in DPX_BlockCtrl1" fixed and read-only. Behaviour of writing to this > register on WSA881x soundwire slave with Qualcomm Soundwire Controller > is throwing up an error. Not sure how other controllers deal with > writing to readonly registers, but this patch provides a way to avoid > writes to DPN_BlockCtrl1 register by providing a read_only_wordlength > flag in struct sdw_dpn_prop Applied, thanks I will send a tag, so that mark can apply the second patch for asoc Thanks -- ~Vinod