From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8AE4C3F2CD for ; Mon, 23 Mar 2020 16:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A175520722 for ; Mon, 23 Mar 2020 16:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727458AbgCWQis (ORCPT ); Mon, 23 Mar 2020 12:38:48 -0400 Received: from mga12.intel.com ([192.55.52.136]:30481 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727234AbgCWQis (ORCPT ); Mon, 23 Mar 2020 12:38:48 -0400 IronPort-SDR: Rriv0Z8hJsGqsw3IoOkPAtgtiPO6JHB23PHs7p4zPBv+48a/GJlbM73vt8QMk6fMAwnqRW4mjh p3JleAiIVMMg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 09:38:46 -0700 IronPort-SDR: BNtv86v3w8JwvH4wJojnjAtNBR5zND3RBh/ddNAj1/0KWdAuOS7J1X36McxoHrFDWlrsVZa05+ xW30ri8rHyMA== X-IronPort-AV: E=Sophos;i="5.72,297,1580803200"; d="scan'208";a="269933222" Received: from smtp.ostc.intel.com ([10.54.29.231]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 09:38:45 -0700 Received: from localhost (mtg-dev.jf.intel.com [10.54.74.10]) by smtp.ostc.intel.com (Postfix) with ESMTP id E3150636B; Mon, 23 Mar 2020 16:38:43 +0000 (UTC) Date: Mon, 23 Mar 2020 09:38:44 -0700 From: mark gross To: Thomas Gleixner Cc: Andy Shevchenko , LKML , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Greg Kroah-Hartman , Tony Luck , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Paolo Bonzini , Darren Hart , Andy Shevchenko , Viresh Kumar , Linux PM , Srinivas Pandruvada , linux-edac@vger.kernel.org, Platform Driver , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, Zhang Rui , Daniel Lezcano , Amit Kucheria , Chanwoo Choi , Jacob Pan , Adrian Hunter , Ulf Hansson , linux-mmc , Bjorn Helgaas , linux-pci@vger.kernel.org, Takashi Iwai , ALSA Development Mailing List , Herbert Xu , "David S. Miller" , linux-crypto Subject: Re: [patch 08/22] ACPI: Convert to new X86 CPU match macros Message-ID: <20200323163844.GB123290@mtg-dev.jf.intel.com> Reply-To: mgross@linux.intel.com References: <20200320131345.635023594@linutronix.de> <20200320131509.467730627@linutronix.de> <87bloqpy1x.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bloqpy1x.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, Mar 20, 2020 at 09:32:26PM +0100, Thomas Gleixner wrote: > Andy Shevchenko writes: > > > On Fri, Mar 20, 2020 at 3:19 PM Thomas Gleixner wrote: > >> > >> The new macro set has a consistent namespace and uses C99 initializers > >> instead of the grufty C89 ones. > >> > >> Rename the local macro wrapper to X86_MATCH for consistency. It stays for > >> readability sake. > > > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_SILVERMONT, NULL), > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_AIRMONT, NULL), > > > >> -#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, } > >> +#define X86_MATCH(model) X86_MATCH_INTEL_FAM6_MODEL(model, NULL) > > > > Maybe we can do a generic macro to avoid all these ', NULL' repetitions? > > I opted for having the data argument everywhere to keep the macro maze > small. And we have enough places where data is actually used. +1 --mark > Thanks, > > tglx From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark gross Subject: Re: [patch 08/22] ACPI: Convert to new X86 CPU match macros Date: Mon, 23 Mar 2020 09:38:44 -0700 Message-ID: <20200323163844.GB123290@mtg-dev.jf.intel.com> References: <20200320131345.635023594@linutronix.de> <20200320131509.467730627@linutronix.de> <87bloqpy1x.fsf@nanos.tec.linutronix.de> Reply-To: mgross@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87bloqpy1x.fsf@nanos.tec.linutronix.de> Sender: linux-crypto-owner@vger.kernel.org To: Thomas Gleixner Cc: Andy Shevchenko , LKML , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Greg Kroah-Hartman , Tony Luck , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Paolo Bonzini , Darren Hart , Andy Shevchenko , Viresh Kumar , Linux PM , Srinivas Pandruvada , linux-edac@vger.kernel.org, Platform Driver , Jean Delvare , Guenter Roeck List-Id: platform-driver-x86.vger.kernel.org On Fri, Mar 20, 2020 at 09:32:26PM +0100, Thomas Gleixner wrote: > Andy Shevchenko writes: > > > On Fri, Mar 20, 2020 at 3:19 PM Thomas Gleixner wrote: > >> > >> The new macro set has a consistent namespace and uses C99 initializers > >> instead of the grufty C89 ones. > >> > >> Rename the local macro wrapper to X86_MATCH for consistency. It stays for > >> readability sake. > > > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_SILVERMONT, NULL), > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_AIRMONT, NULL), > > > >> -#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, } > >> +#define X86_MATCH(model) X86_MATCH_INTEL_FAM6_MODEL(model, NULL) > > > > Maybe we can do a generic macro to avoid all these ', NULL' repetitions? > > I opted for having the data argument everywhere to keep the macro maze > small. And we have enough places where data is actually used. +1 --mark > Thanks, > > tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0CBAC43331 for ; Thu, 26 Mar 2020 07:55:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06A0B20719 for ; Thu, 26 Mar 2020 07:55:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NptULqIg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06A0B20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 435111662; Thu, 26 Mar 2020 08:54:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 435111662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585209331; bh=uATRW5fn+34kUQBETUkaJ83Oo1p/tNjIlBqvTJCZB7E=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=NptULqIg6bpR82GDhGSREGYmvdotOMDnNUQPh89w/4NTNlBQpq3GwoJLah8w0fi2p Z9xsjtkhoLlUVIINU1NyMTvq7v6fXq3GaNKXHHDubCKNXbiAKZiqqSLKGZNGyeHi03 SRpK1PgO5PV+W9v2PHGZC7BVcnlcUWIPhHun2j5A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B087AF8011B; Thu, 26 Mar 2020 08:54:40 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 766B7F80095; Mon, 23 Mar 2020 17:39:03 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5A974F80095 for ; Mon, 23 Mar 2020 17:38:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5A974F80095 IronPort-SDR: FT2x3W+xD6KVMr5dJVdN5NiObJJSlba9VPANfwxrlO7csO2qQTxXMBTTQflzAOUwJk/jByt0l3 NolfA9bMSVkg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 09:38:46 -0700 IronPort-SDR: BNtv86v3w8JwvH4wJojnjAtNBR5zND3RBh/ddNAj1/0KWdAuOS7J1X36McxoHrFDWlrsVZa05+ xW30ri8rHyMA== X-IronPort-AV: E=Sophos;i="5.72,297,1580803200"; d="scan'208";a="269933222" Received: from smtp.ostc.intel.com ([10.54.29.231]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 09:38:45 -0700 Received: from localhost (mtg-dev.jf.intel.com [10.54.74.10]) by smtp.ostc.intel.com (Postfix) with ESMTP id E3150636B; Mon, 23 Mar 2020 16:38:43 +0000 (UTC) Date: Mon, 23 Mar 2020 09:38:44 -0700 From: mark gross To: Thomas Gleixner Subject: Re: [patch 08/22] ACPI: Convert to new X86 CPU match macros Message-ID: <20200323163844.GB123290@mtg-dev.jf.intel.com> References: <20200320131345.635023594@linutronix.de> <20200320131509.467730627@linutronix.de> <87bloqpy1x.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bloqpy1x.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Thu, 26 Mar 2020 08:54:37 +0100 Cc: Ulf Hansson , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Viresh Kumar , ALSA Development Mailing List , Platform Driver , Jacob Pan , Srinivas Pandruvada , Amit Kucheria , Herbert Xu , Chanwoo Choi , Daniel Lezcano , ACPI Devel Maling List , Andy Shevchenko , linux-pci@vger.kernel.org, Darren Hart , Zhang Rui , Guenter Roeck , Len Brown , Jean Delvare , Linux PM , linux-mmc , Bjorn Helgaas , Takashi Iwai , Adrian Hunter , linux-edac@vger.kernel.org, linux-hwmon@vger.kernel.org, Tony Luck , Greg Kroah-Hartman , "Rafael J. Wysocki" , LKML , linux-crypto , Paolo Bonzini , "David S. Miller" , Andy Shevchenko X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: mgross@linux.intel.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Mar 20, 2020 at 09:32:26PM +0100, Thomas Gleixner wrote: > Andy Shevchenko writes: > > > On Fri, Mar 20, 2020 at 3:19 PM Thomas Gleixner wrote: > >> > >> The new macro set has a consistent namespace and uses C99 initializers > >> instead of the grufty C89 ones. > >> > >> Rename the local macro wrapper to X86_MATCH for consistency. It stays for > >> readability sake. > > > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_SILVERMONT, NULL), > >> + X86_MATCH_INTEL_FAM6_MODEL(ATOM_AIRMONT, NULL), > > > >> -#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, } > >> +#define X86_MATCH(model) X86_MATCH_INTEL_FAM6_MODEL(model, NULL) > > > > Maybe we can do a generic macro to avoid all these ', NULL' repetitions? > > I opted for having the data argument everywhere to keep the macro maze > small. And we have enough places where data is actually used. +1 --mark > Thanks, > > tglx