From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>,
guaneryu@gmail.com, jtulak@redhat.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfstests: remove xfs/191-input-validation
Date: Tue, 24 Mar 2020 09:43:04 +0100 [thread overview]
Message-ID: <20200324084304.GA25318@lst.de> (raw)
In-Reply-To: <20200319043306.GK14282@dhcp-12-102.nay.redhat.com>
On Thu, Mar 19, 2020 at 12:33:06PM +0800, Zorro Lang wrote:
> On Wed, Mar 18, 2020 at 06:21:15PM +0100, Christoph Hellwig wrote:
> > This test has constantly failed since it was added, and the promised
> > input validation never materialized.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
>
> Hmm... that's truth this case always fails. But a mkfs.xfs sanity test is
> good.
>
> We have a RHEL internal mkfs.xfs sanity test case, but it takes long time to
> run, can't port to xfstests directly.
> I don't know if Jan would like to improve this case, might make it simple,
> remove those unstable test lines, rewrite the case to avoid unstable test
> results? Or we remove this case, then write a new one?
> I can do that too, if the xfs-devel thinks it worth.
Fine with me, but we really need to get rid of tests failing for no
good reason. And given that there hasn't been any action for years
just removing this test seems like the by far best option.
next prev parent reply other threads:[~2020-03-24 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 17:21 [PATCH] xfstests: remove xfs/191-input-validation Christoph Hellwig
2020-03-18 17:26 ` Eric Sandeen
2020-03-18 18:04 ` Darrick J. Wong
2020-03-19 4:33 ` Zorro Lang
2020-03-24 8:43 ` Christoph Hellwig [this message]
2020-03-24 9:43 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324084304.GA25318@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.