From: David Wu <david.wu@rock-chips.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, joabreu@synopsys.com,
alexandre.torgue@st.com, peppe.cavallaro@st.com,
linux-kernel@vger.kernel.org, David Wu <david.wu@rock-chips.com>
Subject: [RFC,PATCH 1/2] netdevice: Add netif_tx_lock_q
Date: Tue, 24 Mar 2020 17:38:27 +0800 [thread overview]
Message-ID: <20200324093828.30019-1-david.wu@rock-chips.com> (raw)
It is similar to netif_tx_lock, but only locks one queue,
so it seems to be suitable for multiple queues.
If the current queue status is frozen, it will requeue skb,
which will not block the current thread, it improve performance
when tested.
Signed-off-by: David Wu <david.wu@rock-chips.com>
---
include/linux/netdevice.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index b6fedd54cd8e..30054a94210e 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4085,6 +4085,16 @@ static inline void netif_tx_lock(struct net_device *dev)
}
}
+static inline void netif_tx_lock_q(struct netdev_queue *txq)
+{
+ int cpu;
+
+ cpu = smp_processor_id();
+ __netif_tx_lock(txq, cpu);
+ set_bit(__QUEUE_STATE_FROZEN, &txq->state);
+ __netif_tx_unlock(txq);
+}
+
static inline void netif_tx_lock_bh(struct net_device *dev)
{
local_bh_disable();
@@ -4108,6 +4118,12 @@ static inline void netif_tx_unlock(struct net_device *dev)
spin_unlock(&dev->tx_global_lock);
}
+static inline void netif_tx_unlock_q(struct netdev_queue *txq)
+{
+ clear_bit(__QUEUE_STATE_FROZEN, &txq->state);
+ netif_schedule_queue(txq);
+}
+
static inline void netif_tx_unlock_bh(struct net_device *dev)
{
netif_tx_unlock(dev);
--
2.19.1
next reply other threads:[~2020-03-24 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 9:38 David Wu [this message]
2020-03-24 9:38 ` [RFC,PATCH 2/2] net: stmmac: Change the tx clean lock David Wu
2020-04-13 14:31 ` Jose Abreu
2020-04-16 10:46 ` David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324093828.30019-1-david.wu@rock-chips.com \
--to=david.wu@rock-chips.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.