From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35105C43331 for ; Tue, 24 Mar 2020 15:42:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB31120714 for ; Tue, 24 Mar 2020 15:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JCyaJcV6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB31120714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VNOn3sxi4rdJyHAIwiyaZ/xrlw7gbkOnak042lVwpRk=; b=JCyaJcV6JI6J9D ACZjKSPxUNu2nVa6cPyGlagfdA414SmVXqGgKn6RvyiJ2VMqymXaBE/TYIQuNGCl5Y0Iw5vpW8ycb vqwqzcpBQdZ6J8dlntb2/KilxLmy31YJ7TQXE8Cx5NyWiPcsUzyBUKGrjOclQ36bSxw967oJUJCu9 wYttXIazLXMHK/zQ4yDpYJZCRQbu6Wo2vTo8pEoC3kbrXpSAI/9lCLVwP23YFSW5f+2g9nl1KsBGp UjTEFf/YGZvz0mE+IDUcYKAZcllvyD1d+3nLvmj56zc6HH0qTrsrVTqZRJa3GF/qbOmbzTI8/aPPJ TTuTvpjk2I+os3pmeisw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGlhf-0003JZ-LO; Tue, 24 Mar 2020 15:42:55 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGlhd-0003IW-3E for linux-nvme@lists.infradead.org; Tue, 24 Mar 2020 15:42:54 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 43F7468AFE; Tue, 24 Mar 2020 16:42:51 +0100 (CET) Date: Tue, 24 Mar 2020 16:42:50 +0100 From: Christoph Hellwig To: Israel Rukshin Subject: Re: [PATCH 4/7] nvme: Make nvme_uninit_ctrl symmetric to nvme_init_ctrl Message-ID: <20200324154250.GC22197@lst.de> References: <1585063785-14268-1-git-send-email-israelr@mellanox.com> <1585063785-14268-5-git-send-email-israelr@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1585063785-14268-5-git-send-email-israelr@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200324_084253_305877_7C1203EB X-CRM114-Status: UNSURE ( 9.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shlomi Nimrodi , Max Gurtovoy , Sagi Grimberg , Linux-nvme , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Mar 24, 2020 at 05:29:42PM +0200, Israel Rukshin wrote: > Put the ctrl reference count at nvme_uninit_ctrl as opposed to > nvme_init_ctrl which takes it. This decrease the reference count at the > core layer instead of decreasing it on each transport separately. > Also move the call of nvme_uninit_ctrl at PCI driver after calling to > nvme_release_prp_pools and nvme_dev_unmap, in order to put the reference > count after using the dev. This is safe because those functions use > nvme_dev which is freed only later at nvme_pci_free_ctrl. > > Signed-off-by: Israel Rukshin Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme