All of lore.kernel.org
 help / color / mirror / Atom feed
* [MPTCP] [PATCH 0/3] mptcp: fix "fn parameter not described" warnings
@ 2020-03-24 16:57 Matthieu Baerts
  0 siblings, 0 replies; only message in thread
From: Matthieu Baerts @ 2020-03-24 16:57 UTC (permalink / raw)
  To: mptcp

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

When checking for extra warnings using 'make W=1' [1], I saw this:

  $ make W=1 net/mptcp/token.o
  net/mptcp/token.c:53: warning: Function parameter or member 'req' not described in 'mptcp_token_new_request'
  net/mptcp/token.c:98: warning: Function parameter or member 'sk' not described in 'mptcp_token_new_connect'
  net/mptcp/token.c:133: warning: Function parameter or member 'conn' not described in 'mptcp_token_new_accept'
  net/mptcp/token.c:153: warning: Function parameter or member 'token' not described in 'mptcp_token_get_sock'
  net/mptcp/token.c:178: warning: Function parameter or member 'token' not described in 'mptcp_token_destroy_request'
  net/mptcp/token.c:191: warning: Function parameter or member 'token' not described in 'mptcp_token_destroy'

This doesn't stop the build if KCFLAGS='-Werror' is used but better to fix them.

One of these warnings has been introduced in commits from the 'export' branch
but the rest is from two already published commits.

[1] https://github.com/multipath-tcp/mptcp_net-next/commit/2069cff66f186b0d4edf23af5ca02977d8806dc1

Matthieu Baerts (3):
  mptcp: fix "fn parameter not described" warning
  mptcp: fix "fn parameter not described" warnings
  mptcp: fix "fn parameter not described" warning

 net/mptcp/token.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

-- 
2.25.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-24 16:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-24 16:57 [MPTCP] [PATCH 0/3] mptcp: fix "fn parameter not described" warnings Matthieu Baerts

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.