From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB2BC10DCE for ; Tue, 24 Mar 2020 22:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61D4120722 for ; Tue, 24 Mar 2020 22:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="JHxWKsrH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727384AbgCXWte (ORCPT ); Tue, 24 Mar 2020 18:49:34 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:41846 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727209AbgCXWte (ORCPT ); Tue, 24 Mar 2020 18:49:34 -0400 Received: by mail-qt1-f194.google.com with SMTP id i3so505698qtv.8 for ; Tue, 24 Mar 2020 15:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wyre3unUyh1VElX8qQhfnuJe+QdabugraqvEEHKN5YY=; b=JHxWKsrHre+Ce4pqLceZTwJslN4U/dAs+9ebExo+k14lMpfIb+6utSRVDoFt3DfKB6 gmgtze8t9WvmSoxBdR4uF+gQQcAqqQgaNzZRNa2Qkvq3FxtuiL1+oEBVzipVmSLeZH1u AkPQnXx4ZR2YjQfROHmvO8kUd48krZ++1H5PMkkewe9zzLOMy3si5FWidbfOEzzRxIYw lVsP2uXCaktz7Jag9+j2HvUJFu9wpvD2gdwIKbS6oRPDgPA2lm62qgL5ZdJrrzaZMUqf 1edRMPYdNHRPxhXrONQsHyyJ+ynwEZINfJRyaPSk7m5QPXMhpHbbk7IlW/HFkz3A8M3k klkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wyre3unUyh1VElX8qQhfnuJe+QdabugraqvEEHKN5YY=; b=Bss79lLUwIqTwcDvhsVVHPPOGzfPnRif+u5hR4WytghFm7capTEBv9GNtM6NdUw2Uj lNTYm6uIfyJPELIqn673r4bHGIXiXh85vuw1vG/KEW733EhTdiCayEBD4fETkJ0mSiaO McZttUdc72TJuM67QrXsN3nMdAESqdg99EcBjSQjFBaD2KLoTxwcUbI3d0tQrNgaJLM5 s62Uy9TCszlXeRBvC8/Xcqc7fwS6/fwQABeTT72dyTZZ9iwa1SdpCCRG2096jLxe4FVo NQAYRuSeP0wsU1s8kVDmrDXCVTy5k+VvNAnVoKoG/7C1q9w4TxFvEyReWWbJ+8j8RYHm 5XcQ== X-Gm-Message-State: ANhLgQ19OcBANDa7jV/vU+7YtFSv4RJBzHuix1jpQkhPNESJ0HfsfztV qhyysgKalzgG1K0y91oiv7rlXg== X-Google-Smtp-Source: ADFU+vt9bpUw3FK771MMLlRTjLi7t80bcVF9NWM8TbZifYI3XyUssP/a/KNH8DQ1koq0V4GiQsASMw== X-Received: by 2002:aed:2a55:: with SMTP id k21mr185313qtf.159.1585090173412; Tue, 24 Mar 2020 15:49:33 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id v126sm14541082qkb.107.2020.03.24.15.49.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Mar 2020 15:49:32 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jGsMW-0007PL-37; Tue, 24 Mar 2020 19:49:32 -0300 Date: Tue, 24 Mar 2020 19:49:32 -0300 From: Jason Gunthorpe To: Dan Carpenter Cc: Leon Romanovsky , Yishai Hadas , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] IB/mlx5: Fix a NULL vs IS_ERR() check Message-ID: <20200324224932.GA28435@ziepe.ca> References: <20200320132641.GF95012@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320132641.GF95012@mwanda> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Mar 20, 2020 at 04:26:41PM +0300, Dan Carpenter wrote: > The kzalloc() function returns NULL, not error pointers. > > Fixes: 30f2fe40c72b ("IB/mlx5: Introduce UAPIs to manage packet pacing") > Signed-off-by: Dan Carpenter > Acked-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/qos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to for-next, thanks Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Tue, 24 Mar 2020 22:49:32 +0000 Subject: Re: [PATCH] IB/mlx5: Fix a NULL vs IS_ERR() check Message-Id: <20200324224932.GA28435@ziepe.ca> List-Id: References: <20200320132641.GF95012@mwanda> In-Reply-To: <20200320132641.GF95012@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Leon Romanovsky , Yishai Hadas , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, Mar 20, 2020 at 04:26:41PM +0300, Dan Carpenter wrote: > The kzalloc() function returns NULL, not error pointers. > > Fixes: 30f2fe40c72b ("IB/mlx5: Introduce UAPIs to manage packet pacing") > Signed-off-by: Dan Carpenter > Acked-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/qos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to for-next, thanks Jason