From: Julien Thierry <jthierry@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jpoimboe@redhat.com, peterz@infradead.org, raphael.gault@arm.com,
Julien Thierry <jthierry@redhat.com>
Subject: [PATCH 06/10] objtool: check: Use arch specific values in restore_reg()
Date: Wed, 25 Mar 2020 08:41:59 +0000 [thread overview]
Message-ID: <20200325084203.17005-7-jthierry@redhat.com> (raw)
In-Reply-To: <20200325084203.17005-1-jthierry@redhat.com>
Initial register state is set up by arch specific code. Use the value
the arch code has set when restoring registers from the stack.
Suggested-by: Raphael Gault <raphael.gault@arm.com>
Signed-off-by: Julien Thierry <jthierry@redhat.com>
---
tools/objtool/check.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index b8c288c02c99..7bf4dbc2e31f 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1501,8 +1501,8 @@ static void save_reg(struct insn_state *state, unsigned char reg, int base,
static void restore_reg(struct insn_state *state, unsigned char reg)
{
- state->regs[reg].base = CFI_UNDEFINED;
- state->regs[reg].offset = 0;
+ state->regs[reg].base = initial_func_cfi.regs[reg].base;
+ state->regs[reg].offset = initial_func_cfi.regs[reg].offset;
}
/*
--
2.21.1
next prev parent reply other threads:[~2020-03-25 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 8:41 [PATCH 00/10] Objtool updates for easier portability Julien Thierry
2020-03-25 8:41 ` [PATCH 01/10] objtool: Move header sync-check ealier in build Julien Thierry
2020-03-25 8:41 ` [PATCH 02/10] objtool: check: Remove redundant checks on operand type Julien Thierry
2020-03-25 8:41 ` [PATCH 03/10] objtool: check: Clean instruction state before each function validation Julien Thierry
2020-03-25 8:41 ` [PATCH 04/10] objtool: check: Ignore empty alternative groups Julien Thierry
2020-03-25 8:41 ` [PATCH 05/10] objtool: check: Remove check preventing branches within alternative Julien Thierry
2020-03-25 8:41 ` Julien Thierry [this message]
2020-03-25 8:42 ` [PATCH 07/10] objtool: check: Allow save/restore hint in non standard function symbols Julien Thierry
2020-03-25 8:42 ` [PATCH 08/10] objtool: Add abstraction for computation of symbols offsets Julien Thierry
2020-03-25 8:42 ` [PATCH 09/10] objtool: Split generic and arch specific CFI definitions Julien Thierry
2020-03-25 8:42 ` [PATCH 10/10] objtool: Support multiple stack_op per instruction Julien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325084203.17005-7-jthierry@redhat.com \
--to=jthierry@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=raphael.gault@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.